Cleanup some incorrect return annotations
authorErik Bernhardson <ebernhardson@wikimedia.org>
Thu, 8 Dec 2016 05:04:53 +0000 (21:04 -0800)
committerErik Bernhardson <ebernhardson@wikimedia.org>
Mon, 12 Dec 2016 18:15:05 +0000 (10:15 -0800)
commitd67197fa116acc366419faedeeacd91158a98f8b
treee61e97bf32cdb5f83e236b6e25948b8fb7fd6a19
parentf5b4bd19b2719e039a8b6a9ec35f88c1385abca0
Cleanup some incorrect return annotations

Most of these are simply changing annotations to reflect
reality. If a function can return false to indicate failure
the @return should indicate it.

Some are fixing preg_match calls, preg match returns 1, 0 or false,
but the functions all claim to return booleans.

This is far from all the incorrect return types in mediawiki, there
are around 250 detected by phan, but have to start somewhere.

Change-Id: I1bbdfee6190747bde460f8a7084212ccafe169ef
45 files changed:
includes/Category.php
includes/EditPage.php
includes/GitInfo.php
includes/GlobalFunctions.php
includes/HistoryBlob.php
includes/OutputPage.php
includes/PathRouter.php
includes/ProtectionForm.php
includes/Revision.php
includes/SiteConfiguration.php
includes/Title.php
includes/WebRequest.php
includes/WikiMap.php
includes/api/ApiBase.php
includes/api/ApiParamInfo.php
includes/api/ApiQueryBase.php
includes/api/ApiQueryCategoryMembers.php
includes/api/ApiStashEdit.php
includes/cache/FileCacheBase.php
includes/cache/localisation/LocalisationCache.php
includes/db/DatabaseMssql.php
includes/db/DatabaseOracle.php
includes/debug/logger/LegacyLogger.php
includes/diff/DairikiDiff.php
includes/diff/DifferenceEngine.php
includes/filerepo/FileRepo.php
includes/filerepo/ForeignAPIRepo.php
includes/filerepo/RepoGroup.php
includes/filerepo/file/ArchivedFile.php
includes/filerepo/file/File.php
includes/filerepo/file/ForeignDBFile.php
includes/htmlform/HTMLFormField.php
includes/htmlform/fields/HTMLButtonField.php
includes/htmlform/fields/HTMLMultiSelectField.php
includes/htmlform/fields/HTMLSizeFilterField.php
includes/http/Http.php
includes/installer/Installer.php
includes/installer/LocalSettingsGenerator.php
includes/interwiki/ClassicInterwikiLookup.php
includes/jobqueue/aggregator/JobQueueAggregatorRedis.php
includes/libs/ExplodeIterator.php
includes/libs/HashRing.php
includes/libs/filebackend/FileBackendStore.php
includes/libs/filebackend/SwiftFileBackend.php
languages/Language.php