Fix silent failure in PHP 5.1.x or older. The callback for static functions is array...
[lhc/web/wiklou.git] / includes / api / ApiQueryRevisions.php
index c76c380..491cff0 100644 (file)
@@ -33,7 +33,7 @@ if (!defined('MEDIAWIKI')) {
  * Various pieces of information may be shown - flags, comments, and the actual wiki markup of the rev.
  * In the enumeration mode, ranges of revisions may be requested and filtered.
  *
- * @addtogroup API
+ * @ingroup API
  */
 class ApiQueryRevisions extends ApiQueryBase {
 
@@ -44,6 +44,35 @@ class ApiQueryRevisions extends ApiQueryBase {
        private $fld_ids = false, $fld_flags = false, $fld_timestamp = false, $fld_size = false,
                        $fld_comment = false, $fld_user = false, $fld_content = false;
 
+       protected function getTokenFunctions() {
+               // tokenname => function
+               // function prototype is func($pageid, $title, $rev)
+               // should return token or false
+
+               // Don't call the hooks twice
+               if(isset($this->tokenFunctions))
+                       return $this->tokenFunctions;
+
+               // If we're in JSON callback mode, no tokens can be obtained
+               if(!is_null($this->getMain()->getRequest()->getVal('callback')))
+                       return array();
+
+               $this->tokenFunctions = array(
+                       'rollback' => array( 'ApiQueryRevisions','getRollbackToken' )
+               );
+               wfRunHooks('APIQueryRevisionsTokens', array(&$this->tokenFunctions));
+               return $this->tokenFunctions;
+       }
+
+       public static function getRollbackToken($pageid, $title, $rev)
+       {
+               global $wgUser;
+               if(!$wgUser->isAllowed('rollback'))
+                       return false;
+               return $wgUser->editToken($title->getPrefixedText(),
+                                               $rev->getUserText());
+       }
+
        public function execute() {
                $limit = $startid = $endid = $start = $end = $dir = $prop = $user = $excludeuser = $expandtemplates = $section = $token = null;
                extract($this->extractRequestParams(false));
@@ -70,34 +99,25 @@ class ApiQueryRevisions extends ApiQueryBase {
                        $this->dieUsage('titles, pageids or a generator was used to supply multiple pages, but the limit, startid, endid, dirNewer, user, excludeuser, start and end parameters may only be used on a single page.', 'multpages');
 
                $this->addTables('revision');
-               $this->addWhere('rev_deleted=0');
+               $this->addFields( Revision::selectFields() );
 
                $prop = array_flip($prop);
 
-               // These field are needed regardless of the client requesting them
-               $this->addFields('rev_id');
-               $this->addFields('rev_page');
-
                // Optional fields
                $this->fld_ids = isset ($prop['ids']);
                // $this->addFieldsIf('rev_text_id', $this->fld_ids); // should this be exposed?
-               $this->fld_flags = $this->addFieldsIf('rev_minor_edit', isset ($prop['flags']));
-               $this->fld_timestamp = $this->addFieldsIf('rev_timestamp', isset ($prop['timestamp']));
-               $this->fld_comment = $this->addFieldsIf('rev_comment', isset ($prop['comment']));
-               $this->fld_size = $this->addFieldsIf('rev_len', isset ($prop['size']));
-               $this->tok_rollback = false; // Prevent PHP undefined property notice
-               if(!is_null($token))
-               {
-                       $this->tok_rollback = $this->getTokenFlag($token, 'rollback');
-               }
-
-               if (isset ($prop['user'])) {
-                       $this->addFields('rev_user');
-                       $this->addFields('rev_user_text');
-                       $this->fld_user = true;
+               $this->fld_flags = isset ($prop['flags']);
+               $this->fld_timestamp = isset ($prop['timestamp']);
+               $this->fld_comment = isset ($prop['comment']);
+               $this->fld_size = isset ($prop['size']);
+               $this->fld_user = isset ($prop['user']);
+               $this->token = $token;
+
+               if ( !is_null($this->token) || ( $this->fld_content && $this->expandTemplates ) || $pageCount > 0) {
+                       $this->addTables( 'page' );
+                       $this->addWhere('page_id=rev_page');
+                       $this->addFields( Revision::selectPageFields() );
                }
-               else if($this->tok_rollback)
-                       $this->addFields('rev_user_text');
 
                if (isset ($prop['content'])) {
 
@@ -112,8 +132,7 @@ class ApiQueryRevisions extends ApiQueryBase {
                        $this->addTables('text');
                        $this->addWhere('rev_text_id=old_id');
                        $this->addFields('old_id');
-                       $this->addFields('old_text');
-                       $this->addFields('old_flags');
+                       $this->addFields( Revision::selectTextFields() );
 
                        $this->fld_content = true;
 
@@ -181,7 +200,6 @@ class ApiQueryRevisions extends ApiQueryBase {
                elseif ($pageCount > 0) {
                        // When working in multi-page non-enumeration mode,
                        // limit to the latest revision only
-                       $this->addTables('page');
                        $this->addWhere('page_id=rev_page');
                        $this->addWhere('page_latest=rev_id');
                        $this->validateLimit('page_count', $pageCount, 1, $userMax, $botMax);
@@ -211,14 +229,15 @@ class ApiQueryRevisions extends ApiQueryBase {
                                break;
                        }
 
+                       $revision = new Revision( $row );
                        $this->getResult()->addValue(
                                array (
                                        'query',
                                        'pages',
-                                       intval($row->rev_page),
+                                       $revision->getPage(),
                                        'revisions'),
                                null,
-                               $this->extractRowInfo($row));
+                               $this->extractRowInfo( $revision ));
                }
                $db->freeResult($res);
 
@@ -234,55 +253,64 @@ class ApiQueryRevisions extends ApiQueryBase {
                }
        }
 
-       private function extractRowInfo($row) {
+       private function extractRowInfo( $revision ) {
 
                $vals = array ();
 
                if ($this->fld_ids) {
-                       $vals['revid'] = intval($row->rev_id);
+                       $vals['revid'] = $revision->getId();
                        // $vals['oldid'] = intval($row->rev_text_id);  // todo: should this be exposed?
                }
 
-               if ($this->fld_flags && $row->rev_minor_edit)
+               if ($this->fld_flags && $revision->isMinor())
                        $vals['minor'] = '';
 
                if ($this->fld_user) {
-                       $vals['user'] = $row->rev_user_text;
-                       if (!$row->rev_user)
+                       $vals['user'] = $revision->getUserText();
+                       if (!$revision->getUser())
                                $vals['anon'] = '';
                }
 
                if ($this->fld_timestamp) {
-                       $vals['timestamp'] = wfTimestamp(TS_ISO_8601, $row->rev_timestamp);
+                       $vals['timestamp'] = wfTimestamp(TS_ISO_8601, $revision->getTimestamp());
                }
 
-               if ($this->fld_size && !is_null($row->rev_len)) {
-                       $vals['size'] = intval($row->rev_len);
+               if ($this->fld_size && !is_null($revision->getSize())) {
+                       $vals['size'] = $revision->getSize();
                }
 
-               if ($this->fld_comment && !empty ($row->rev_comment)) {
-                       $vals['comment'] = $row->rev_comment;
+               if ($this->fld_comment) {
+                       $comment = $revision->getComment();
+                       if (!empty($comment))           
+                               $vals['comment'] = $comment;
                }
 
-               if($this->tok_rollback || ($this->fld_content && $this->expandTemplates))
-                       $title = Title::newFromID($row->rev_page);
+               if(!is_null($this->token) || ($this->fld_content && $this->expandTemplates))
+                       $title = $revision->getTitle();
 
-               if($this->tok_rollback) {
-                       global $wgUser;
-                       $vals['rollbacktoken'] = $wgUser->editToken(array($title->getPrefixedText(), $row->rev_user_text));
+               if(!is_null($this->token))
+               {
+                       $tokenFunctions = $this->getTokenFunctions();
+                       foreach($this->token as $t)
+                       {
+                               $val = call_user_func($tokenFunctions[$t], $title->getArticleID(), $title, $revision);
+                               if($val === false)
+                                       $this->setWarning("Action '$t' is not allowed for the current user");
+                               else
+                                       $vals[$t . 'token'] = $val;
+                       }
                }
 
-
                if ($this->fld_content) {
                        global $wgParser;
-                       $text = Revision :: getRevisionText($row);
+                       $text = $revision->getText();
                        # Expand templates after getting section content because
                        # template-added sections don't count and Parser::preprocess()
                        # will have less input
                        if ($this->section !== false) {
                                $text = $wgParser->getSection( $text, $this->section, false);
                                if($text === false)
-                                       $this->dieUsage("There is no section {$this->section} in r{$row->rev_id}", 'nosuchsection');
+                                       $this->dieUsage("There is no section {$this->section} in r".$revision->getId(), 'nosuchsection');
                        }
                        if ($this->expandTemplates) {
                                $text = $wgParser->preprocess( $text, $title, new ParserOptions() );
@@ -344,9 +372,7 @@ class ApiQueryRevisions extends ApiQueryBase {
                                ApiBase :: PARAM_TYPE => 'integer'
                        ),
                        'token' => array(
-                               ApiBase :: PARAM_TYPE => array(
-                                       'rollback'
-                               ),
+                               ApiBase :: PARAM_TYPE => array_keys($this->getTokenFunctions()),
                                ApiBase :: PARAM_ISMULTI => true
                        ),
                );