*/
protected $numRows;
+ protected $cachedTimestamp = null;
+
/**
* Wheter to show prev/next links
*/
- var $shownavigation = true;
+ protected $shownavigation = true;
/**
* A mutator for $this->listoutput;
* join_conds => JOIN conditions
*
* Note that the query itself should return the following three columns:
- * 'namespace', 'title', and 'value'
- * *in that order*. 'value' is used for sorting.
+ * 'namespace', 'title', and 'value'. 'value' is used for sorting.
*
* These may be stored in the querycache table for expensive queries,
* and that cached data will be returned sometimes, so the presence of
function getQueryInfo() {
return null;
}
-
+
/**
* For back-compat, subclasses may return a raw SQL query here, as a string.
* This is stronly deprecated; getQueryInfo() should be overridden instead.
* @return string
- * @deprecated since 1.18
*/
function getSQL() {
+ /* Implement getQueryInfo() instead */
throw new MWException( "Bug in a QueryPage: doesn't implement getQueryInfo() nor getQuery() properly" );
}
if ( !$this->isCacheable() ) {
return 0;
}
-
+
$fname = get_class( $this ) . '::recache';
$dbw = wfGetDB( DB_MASTER );
$dbr = wfGetDB( DB_SLAVE, array( $this->getName(), __METHOD__, 'vslow' ) );
*/
function reallyDoQuery( $limit, $offset = false ) {
$fname = get_class( $this ) . "::reallyDoQuery";
+ $dbr = wfGetDB( DB_SLAVE );
$query = $this->getQueryInfo();
$order = $this->getOrderFields();
if ( $this->sortDescending() ) {
$options['OFFSET'] = intval( $offset );
}
- $dbr = wfGetDB( DB_SLAVE );
$res = $dbr->select( $tables, $fields, $conds, $fname,
$options, $join_conds
);
$sql = $this->getSQL();
$sql .= ' ORDER BY ' . implode( ', ', $order );
$sql = $dbr->limitResult( $sql, $limit, $offset );
- $res = $dbr->query( $sql );
+ $res = $dbr->query( $sql, $fname );
}
return $dbr->resultObject( $res );
}
/**
- * Parameters and order changed in 1.18
+ * Somewhat deprecated, you probably want to be using execute()
*/
- function doQuery( $limit, $offset = false ) {
+ function doQuery( $offset = false, $limit = false ) {
if ( $this->isCached() && $this->isCacheable() ) {
return $this->fetchFromCache( $limit, $offset );
} else {
if ( $offset !== false ) {
$options['OFFSET'] = intval( $offset );
}
+ if ( $this->sortDescending() ) {
+ $options['ORDER BY'] = 'qc_value DESC';
+ } else {
+ $options['ORDER BY'] = 'qc_value ASC';
+ }
$res = $dbr->select( 'querycache', array( 'qc_type',
'qc_namespace AS namespace',
'qc_title AS title',
return $dbr->resultObject( $res );
}
+ public function getCachedTimestamp() {
+ if ( !is_null( $this->cachedTimestamp ) ) {
+ $dbr = wfGetDB( DB_SLAVE );
+ $fname = get_class( $this ) . '::getCachedTimestamp';
+ $this->cachedTimestamp = $dbr->selectField( 'querycache_info', 'qci_timestamp',
+ array( 'qci_type' => $this->getName() ), $fname );
+ }
+ return $this->cachedTimestamp;
+ }
+
/**
* This is the actual workhorse. It does everything needed to make a
* real, honest-to-gosh query page.
if ( $this->limit == 0 && $this->offset == 0 )
list( $this->limit, $this->offset ) = wfCheckLimits();
- $sname = $this->getName();
- $fname = get_class( $this ) . '::doQuery';
$dbr = wfGetDB( DB_SLAVE );
$this->setHeaders();
if ( !$this->listoutput ) {
# Fetch the timestamp of this update
- $tRes = $dbr->select( 'querycache_info', array( 'qci_timestamp' ), array( 'qci_type' => $sname ), $fname );
- $tRow = $dbr->fetchObject( $tRes );
-
- if ( $tRow ) {
- $updated = $wgLang->timeanddate( $tRow->qci_timestamp, true, true );
- $updateddate = $wgLang->date( $tRow->qci_timestamp, true, true );
- $updatedtime = $wgLang->time( $tRow->qci_timestamp, true, true );
- $wgOut->addMeta( 'Data-Cache-Time', $tRow->qci_timestamp );
- $wgOut->addInlineScript( "var dataCacheTime = '{$tRow->qci_timestamp}';" );
+ $ts = $this->getCachedTimestamp();
+
+ if ( $ts ) {
+ $updated = $wgLang->timeanddate( $ts, true, true );
+ $updateddate = $wgLang->date( $ts, true, true );
+ $updatedtime = $wgLang->time( $ts, true, true );
+ $wgOut->addMeta( 'Data-Cache-Time', $ts );
+ $wgOut->addInlineScript( "var dataCacheTime = '$ts';" );
$wgOut->addWikiMsg( 'perfcachedts', $updated, $updateddate, $updatedtime );
} else {
$wgOut->addWikiMsg( 'perfcached' );
if ( $num > 0 ) {
$html = array();
- if ( !$this->listoutput )
+ if ( !$this->listoutput ) {
$html[] = $this->openList( $offset );
+ }
# $res might contain the whole 1,000 rows, so we read up to
# $num [should update this to use a Pager]
}
}
- if ( !$this->listoutput )
+ if ( !$this->listoutput ) {
$html[] = $this->closeList();
+ }
$html = $this->listoutput
? $wgContLang->listToText( $html )
$this->feedUrl() );
$feed->outHeader();
- $dbr = wfGetDB( DB_SLAVE );
$res = $this->reallyDoQuery( $limit, 0 );
foreach ( $res as $obj ) {
$item = $this->feedResult( $obj );