From: Brian Wolff <bawolff+wn@gmail.com>
Date: Wed, 28 Mar 2018 01:20:07 +0000 (+0000)
Subject: Fix --memory-limit option to maintenance scripts
X-Git-Tag: 1.31.0-rc.0~175^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/Kategorie:Great?a=commitdiff_plain;h=fba014820b8c210d40685d064ce081cbead0d02a;p=lhc%2Fweb%2Fwiklou.git

Fix --memory-limit option to maintenance scripts

Follow up 2f293bd0. Previously this option was marked as not
taking an argument, thus if present it would have the value of
true (aka 1). Setting memory limit to 1 results in setting to
256kb, which is way too small.

Change-Id: I2a6e512e384c5ef882f7ba2877091ecb8fe01e35
---

diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php
index 0c79bd51e5..e3b5f72efb 100644
--- a/maintenance/Maintenance.php
+++ b/maintenance/Maintenance.php
@@ -508,7 +508,9 @@ abstract class Maintenance {
 		$this->addOption(
 			'memory-limit',
 			'Set a specific memory limit for the script, '
-				. '"max" for no limit or "default" to avoid changing it'
+				. '"max" for no limit or "default" to avoid changing it',
+			false,
+			true
 		);
 		$this->addOption( 'server', "The protocol and server name to use in URLs, e.g. " .
 			"http://en.wikipedia.org. This is sometimes necessary because " .