From 95985d0e4951622ebeb0ed18f29b832280981110 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 13 Jun 2019 19:33:46 +0100 Subject: [PATCH] resourceloader: Remove redundant 'group' setting for StartupModule This feaure exists for controlling cache fragmentation of modules that are queued for loading. However, the startup module is never "queued" for loading. It's loading is hardwired into ResourceLoaderClientHtml and doesn't use any batching and couldn't logically, given that by design it has to be the first thing that loads and cannot be combined with other code (because we need to be able to return early and control what else gets loaded from there). [0] https://www.mediawiki.org/wiki/ResourceLoader/Architecture#Balance Change-Id: If8900c538ce623f6a9a68a3bbef0927b4b6ae346 --- includes/resourceloader/ResourceLoaderStartUpModule.php | 7 ------- 1 file changed, 7 deletions(-) diff --git a/includes/resourceloader/ResourceLoaderStartUpModule.php b/includes/resourceloader/ResourceLoaderStartUpModule.php index efed418106..26e64d18c1 100644 --- a/includes/resourceloader/ResourceLoaderStartUpModule.php +++ b/includes/resourceloader/ResourceLoaderStartUpModule.php @@ -425,11 +425,4 @@ class ResourceLoaderStartUpModule extends ResourceLoaderModule { // and hash it to determine the version (as used by E-Tag HTTP response header). return true; } - - /** - * @return string - */ - public function getGroup() { - return 'startup'; - } } -- 2.20.1