From dfb7d5d2061b9f65f1f65a552767588b880cd5bb Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Tue, 14 Feb 2012 07:25:48 +0000 Subject: [PATCH] Reverted r111186, r111226: broken per CR --- CREDITS | 1 - includes/ChangeTags.php | 6 +++--- includes/specials/SpecialRecentchanges.php | 6 +++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/CREDITS b/CREDITS index 4f4563f1f2..9b001597eb 100644 --- a/CREDITS +++ b/CREDITS @@ -114,7 +114,6 @@ following names for their contribution to the product. * Harry Burt * Ireas * Jaska Zedlik -* Jarry1250 * Jeremy Baron * Jidanni * Jimmy Xu diff --git a/includes/ChangeTags.php b/includes/ChangeTags.php index 4b9b0e0415..63d3732707 100644 --- a/includes/ChangeTags.php +++ b/includes/ChangeTags.php @@ -209,8 +209,8 @@ class ChangeTags { if ( !$wgUseTagFilter || !count( self::listDefinedTags() ) ) return $fullForm ? '' : array(); - $data = array( Html::rawElement( 'label', array( 'for' => 'tagfilter' ), wfMsgExt( 'tag-filter', 'parseinline' ), - Xml::input( 'tagfilter', 20, $selected, array( 'class' => 'tagfilter-input' ) ) ) ); + $data = array( Html::rawElement( 'label', array( 'for' => 'tagfilter' ), wfMsgExt( 'tag-filter', 'parseinline' ) ), + Xml::input( 'tagfilter', 20, $selected ) ); if ( !$fullForm ) { return $data; @@ -219,7 +219,7 @@ class ChangeTags { $html = implode( ' ', $data ); $html .= "\n" . Xml::element( 'input', array( 'type' => 'submit', 'value' => wfMsg( 'tag-filter-submit' ) ) ); $html .= "\n" . Html::hidden( 'title', $title->getPrefixedText() ); - $html = Xml::tags( 'form', array( 'action' => $title->getLocalURL(), 'class' => 'tagfilter-form', 'method' => 'get' ), $html ); + $html = Xml::tags( 'form', array( 'action' => $title->getLocalURL(), 'method' => 'get' ), $html ); return $html; } diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index 22bdd36879..f8828ea3ff 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -568,14 +568,14 @@ class SpecialRecentChanges extends IncludableSpecialPage { $submit = ' ' . Xml::submitbutton( wfMsg( 'allpagessubmit' ) ); $out = Xml::openElement( 'table', array( 'class' => 'mw-recentchanges-table' ) ); - foreach( $extraOpts as $name=>$optionRow ) { + foreach( $extraOpts as $optionRow ) { # Add submit button to the last row only ++$count; - $addSubmit = ( $count === $extraOptsCount ) ? $submit : ''; + $addSubmit = $count === $extraOptsCount ? $submit : ''; $out .= Xml::openElement( 'tr' ); if( is_array( $optionRow ) ) { - $out .= Xml::tags( 'td', array( 'class' => 'mw-label ' . $name . '-label' ), $optionRow[0] ); + $out .= Xml::tags( 'td', array( 'class' => 'mw-label' ), $optionRow[0] ); $out .= Xml::tags( 'td', array( 'class' => 'mw-input' ), $optionRow[1] . $addSubmit ); } else { $out .= Xml::tags( 'td', array( 'class' => 'mw-input', 'colspan' => 2 ), $optionRow . $addSubmit ); -- 2.20.1