From 9f3297d0e87acaefca59433293065afd70f54ebf Mon Sep 17 00:00:00 2001 From: Krinkle Date: Sun, 8 Jan 2012 00:52:50 +0000 Subject: [PATCH] Remove action=history from submit on HistoryAction * Not needed, and not used. Is internally converted to "view" as much as possible. * Fixes bug 33587 * See also https://bugzilla.wikimedia.org/show_bug.cgi?id=25800#c6 * Other diff links from MediaWiki don't do this either --- RELEASE-NOTES-1.19 | 1 + includes/actions/HistoryAction.php | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.19 b/RELEASE-NOTES-1.19 index 5e4e608ae8..e8d0b153f8 100644 --- a/RELEASE-NOTES-1.19 +++ b/RELEASE-NOTES-1.19 @@ -228,6 +228,7 @@ production. all pages. * Files with IPTC blocks we can't read no longer prevent extraction of exif or other metadata. +* (bug 33587) Remove action "historysubmit" from history pages. === API changes in 1.19 === * (bug 19838) siprop=interwikimap can now use the interwiki cache. diff --git a/includes/actions/HistoryAction.php b/includes/actions/HistoryAction.php index aa1ec45c70..8a34aa4ced 100644 --- a/includes/actions/HistoryAction.php +++ b/includes/actions/HistoryAction.php @@ -407,7 +407,6 @@ class HistoryPager extends ReverseChronologicalPager { $s = Html::openElement( 'form', array( 'action' => $wgScript, 'id' => 'mw-history-compare' ) ) . "\n"; $s .= Html::hidden( 'title', $this->getTitle()->getPrefixedDbKey() ) . "\n"; - $s .= Html::hidden( 'action', 'historysubmit' ) . "\n"; $s .= '
' . $this->submitButton( $this->msg( 'compareselectedversions' )->text(), array( 'class' => 'historysubmit' ) ) . "\n"; -- 2.20.1