From 98d7ec136bb1301315084d52bdd0e85c5097e638 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Sun, 15 Jan 2017 13:51:21 +0100 Subject: [PATCH] mw.htmlform: Fix 'hide-if' disabling OOUI fields Follow-up to 5d5dbc83da4bc339e6c2f7fb3d346ba259192b68. The logic here is supposed to be the same as in the block above, but it was inverted. I think this code used to be `.setRequired( false )` at some point, and I changed the 'setRequired' but forgot the 'false'. Change-Id: Iabb112d3d0519df079bc2c9afab7d4436fff6562 --- resources/src/mediawiki/htmlform/hide-if.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/src/mediawiki/htmlform/hide-if.js b/resources/src/mediawiki/htmlform/hide-if.js index f9cb5de685..157ac06211 100644 --- a/resources/src/mediawiki/htmlform/hide-if.js +++ b/resources/src/mediawiki/htmlform/hide-if.js @@ -277,7 +277,7 @@ if ( self.wasDisabled === undefined ) { self.wasDisabled = self.fieldWidget.isDisabled(); } - self.fieldWidget.setDisabled( false ); + self.fieldWidget.setDisabled( true ); } else if ( self.wasDisabled !== undefined ) { self.fieldWidget.setDisabled( self.wasDisabled ); } -- 2.20.1