From 84fed26fd49c8aec4fe8b703b07a2bb9806fdafa Mon Sep 17 00:00:00 2001
From: Sam Reed <reedy@users.mediawiki.org>
Date: Sat, 6 Nov 2010 15:10:18 +0000
Subject: [PATCH] Add missing credits from r75975

Remove a few unused array keys in API foreach loops

Remove part of Html::Hidden comment
---
 CREDITS                     | 1 +
 includes/Html.php           | 3 +--
 includes/api/ApiMain.php    | 4 ++--
 includes/api/ApiPageSet.php | 2 +-
 includes/api/ApiParse.php   | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/CREDITS b/CREDITS
index 03e9f82aba..935b656354 100644
--- a/CREDITS
+++ b/CREDITS
@@ -91,6 +91,7 @@ following names for their contribution to the product.
 * Jidanni
 * Jimmy Xu
 * John Du Hart
+* Jonathan Wiltshire
 * Karun Dambietz
 * Kim Hyun-Joon
 * Lee Worden
diff --git a/includes/Html.php b/includes/Html.php
index a1768df04e..6c802ca333 100644
--- a/includes/Html.php
+++ b/includes/Html.php
@@ -547,8 +547,7 @@ class Html {
 	}
 
 	/**
-	 * Convenience function to produce an input element with type=hidden, like
-	 * Xml::hidden.
+	 * Convenience function to produce an input element with type=hidden
 	 *
 	 * @param $name    string name attribute
 	 * @param $value   string value attribute
diff --git a/includes/api/ApiMain.php b/includes/api/ApiMain.php
index 2f21201f7e..4fcb0b202e 100644
--- a/includes/api/ApiMain.php
+++ b/includes/api/ApiMain.php
@@ -833,7 +833,7 @@ class ApiMain extends ApiBase {
 
 		$astriks = str_repeat( '*** ', 10 );
 		$msg .= "\n\n$astriks Modules  $astriks\n\n";
-		foreach ( $this->mModules as $moduleName => $unused ) {
+		foreach ( $this->mModules as $moduleName ) {
 			$module = new $this->mModules[$moduleName] ( $this, $moduleName );
 			$msg .= self::makeHelpMsgHeader( $module, 'action' );
 			$msg2 = $module->makeHelpMsg();
@@ -852,7 +852,7 @@ class ApiMain extends ApiBase {
 		}
 
 		$msg .= "\n$astriks Formats  $astriks\n\n";
-		foreach ( $this->mFormats as $formatName => $unused ) {
+		foreach ( $this->mFormats as $formatName ) {
 			$module = $this->createPrinterByName( $formatName );
 			$msg .= self::makeHelpMsgHeader( $module, 'format' );
 			$msg2 = $module->makeHelpMsg();
diff --git a/includes/api/ApiPageSet.php b/includes/api/ApiPageSet.php
index f54f1f8e84..3b1fd59829 100644
--- a/includes/api/ApiPageSet.php
+++ b/includes/api/ApiPageSet.php
@@ -501,7 +501,7 @@ class ApiPageSet extends ApiQueryBase {
 			if ( $processTitles ) {
 				// The remaining titles in $remaining are non-existent pages
 				foreach ( $remaining as $ns => $dbkeys ) {
-					foreach ( $dbkeys as $dbkey => $unused ) {
+					foreach ( $dbkeys as $dbkey ) {
 						$title = Title::makeTitle( $ns, $dbkey );
 						$this->mAllPages[$ns][$dbkey] = $this->mFakePageId;
 						$this->mMissingTitles[$this->mFakePageId] = $title;
diff --git a/includes/api/ApiParse.php b/includes/api/ApiParse.php
index de3b371e80..f6edbb0373 100644
--- a/includes/api/ApiParse.php
+++ b/includes/api/ApiParse.php
@@ -345,7 +345,7 @@ class ApiParse extends ApiBase {
 	private function formatIWLinks( $iw ) {
 		$result = array();
 		foreach ( $iw as $prefix => $titles ) {
-			foreach ( $titles as $title => $id ) {
+			foreach ( $titles as $title ) {
 				$entry = array();
 				$entry['prefix'] = $prefix;
 
-- 
2.20.1