From: Platonides <platonides@users.mediawiki.org>
Date: Thu, 30 Dec 2010 16:16:16 +0000 (+0000)
Subject: ResourceLoader::register() works differently since r77011.
X-Git-Tag: 1.31.0-rc.0~32979
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/?a=commitdiff_plain;h=cd1f6888ddb243d7a31fab219addb48f37ff5909;p=lhc%2Fweb%2Fwiklou.git

ResourceLoader::register() works differently since r77011.
This test isn't useful anymore.
---

diff --git a/tests/phpunit/includes/ResourceLoaderTest.php b/tests/phpunit/includes/ResourceLoaderTest.php
index 8de178a951..76f0ba874c 100644
--- a/tests/phpunit/includes/ResourceLoaderTest.php
+++ b/tests/phpunit/includes/ResourceLoaderTest.php
@@ -46,20 +46,6 @@ class ResourceLoaderTest extends PHPUnit_Framework_TestCase {
 		$resourceLoader->register( $name, $module );
 		$this->assertEquals( $module, $resourceLoader->getModule( $name ) );
 	}
-
-	/**
-	 * Allthough ResourceLoader::register uses type hinting to prevent arbitrary information being passed through as a
-	 * ResourceLoaderModule object, null can still get through.
-	 *
-	 * @depends testCreatingNewResourceLoaderCallsRegistrationHook
-	 * @covers ResourceLoader::register
-	 * @covers ResourceLoader::getModule
-	 * @expectedException MWException
-	 */
-	public function testRegisteringNullModuleThrowsAnException( ResourceLoader $resourceLoader ) {
-		$this->markTestIncomplete( "Broken by r77011" );
-		$resourceLoader->register( 'TEST.nullModule', null );
-	}
 }
 
 /* Stubs */
@@ -68,4 +54,4 @@ class ResourceLoaderTestModule extends ResourceLoaderModule { }
 
 /* Hooks */
 global $wgHooks;
-$wgHooks['ResourceLoaderRegisterModules'][] = 'ResourceLoaderTest::resourceLoaderRegisterModules';
\ No newline at end of file
+$wgHooks['ResourceLoaderRegisterModules'][] = 'ResourceLoaderTest::resourceLoaderRegisterModules';