resourceloader: Fix undefined $filename in safeFileHash()

Follows-up 28f6d7fbdee.

This was causing versions to stay stuck at their current version.
It worked fine for the initial deployment since the rest of the
definition summary is still fine, but subsequent deploys that changed
only the file were ineffective due to these silently becoming
empty strings.

Thanks to suppressWarnings() we never saw these anywhere in the
tests or in production.

Change-Id: Ib4371255fe970442bcc0041219bce633a7f6f6dd

diff --git a/includes/resourceloader/ResourceLoaderModule.php b/includes/resourceloader/ResourceLoaderModule.php
index 8e53c3e..ade99e2 100644 (file)
--- a/includes/resourceloader/ResourceLoaderModule.php
+++ b/includes/resourceloader/ResourceLoaderModule.php
@@ -857,7 +857,7 @@ abstract class ResourceLoaderModule {
         */
        protected static function safeFileHash( $filePath ) {
                MediaWiki\suppressWarnings();
-               $hash = sha1_file( $filename ) ?: '';
+               $hash = sha1_file( $filePath ) ?: '';
                MediaWiki\restoreWarnings();
                return $hash;
        }