Don't pass $this by reference to SkinVectorStyleModules hook.
authorAlexandre Emsenhuber <ialex.wiki@gmail.com>
Sun, 15 Dec 2013 13:58:20 +0000 (14:58 +0100)
committerReedy <reedy@wikimedia.org>
Thu, 23 Jan 2014 23:11:19 +0000 (23:11 +0000)
Fix for Ica0b69ad95 (8b6ed4d0).

$this cannot be changed, so there is not any reason to pass
it by reference.

Change-Id: I916ccabbaff9f60edb344550111f62c833bb137b

skins/Vector.php

index 00b920a..0dcfe46 100644 (file)
@@ -68,7 +68,7 @@ class SkinVector extends SkinTemplate {
                parent::setupSkinUserCss( $out );
 
                $styles = array( 'skins.common.interface', 'skins.vector.styles' );
-               wfRunHooks( 'SkinVectorStyleModules', array( &$this, &$styles ) );
+               wfRunHooks( 'SkinVectorStyleModules', array( $this, &$styles ) );
                $out->addModuleStyles( $styles );
        }