do not trust equality propagation, help optimizer a bit ;-)
authorDomas Mituzas <midom@users.mediawiki.org>
Wed, 25 Jan 2006 20:50:39 +0000 (20:50 +0000)
committerDomas Mituzas <midom@users.mediawiki.org>
Wed, 25 Jan 2006 20:50:39 +0000 (20:50 +0000)
includes/Revision.php

index 0398a9b..7908d56 100644 (file)
@@ -63,17 +63,13 @@ class Revision {
         * @access public
         */
        function loadFromPageId( &$db, $pageid, $id = 0 ) {
+               $conds=array('page_id=rev_page','rev_page'=>intval( $pageid ), 'page_id'=>intval( $pageid ));
                if( $id ) {
-                       $matchId = intval( $id );
+                       $conds['rev_id']=intval($id);
                } else {
-                       $matchId = 'page_latest';
+                       $conds[]='rev_id=page_latest';
                }
-               $ret = Revision::loadFromConds(
-                       $db,
-                       array( "rev_id=$matchId",
-                              'rev_page' => intval( $pageid ),
-                              'page_id=rev_page' ) );
-               return $ret;
+               return Revision::loadFromConds( $db, $conds );
        }
 
        /**