Add braces

Fix documentation

diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 066d3e3..c8e136d 100644 (file)
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -446,7 +446,7 @@ class ChangesList extends ContextSource {
 
        /** Inserts a rollback link
         *
-        * @param $s
+        * @param $s string
         * @param $rc RecentChange
         */
        public function insertRollback( &$s, &$rc ) {
@@ -469,10 +469,9 @@ class ChangesList extends ContextSource {
        }
 
        /**
-        * @param $s
+        * @param $s string
         * @param $rc RecentChange
         * @param $classes
-        * @return
         */
        public function insertTags( &$s, &$rc, &$classes ) {
                if ( empty($rc->mAttribs['ts_tags']) )

diff --git a/includes/filerepo/backend/lockmanager/DBLockManager.php b/includes/filerepo/backend/lockmanager/DBLockManager.php
index 004caa8..3110d5b 100644 (file)
--- a/includes/filerepo/backend/lockmanager/DBLockManager.php
+++ b/includes/filerepo/backend/lockmanager/DBLockManager.php
@@ -206,7 +206,7 @@ class DBLockManager extends LockManager {
                $votesLeft = count( $this->dbsByBucket[$bucket] ); // remaining DBs
                $quorum = floor( $votesLeft/2 + 1 ); // simple majority
                // Get votes for each DB, in order, until we have enough...
-               foreach ( $this->dbsByBucket[$bucket] as $index => $lockDb ) {
+               foreach ( $this->dbsByBucket[$bucket] as $lockDb ) {
                        // Check that DB is not *known* to be down
                        if ( $this->cacheCheckFailures( $lockDb ) ) {
                                try {

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 5c6255f..1c2cbff 100644 (file)
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -1228,7 +1228,7 @@ abstract class Installer {
 
        /**
         * Overridden by WebInstaller to provide lastPage parameters.
-        * @param $page stirng
+        * @param $page string
         * @return string
         */
        protected function getDocUrl( $page ) {

diff --git a/maintenance/commandLine.inc b/maintenance/commandLine.inc
index db0c560..4b6422a 100644 (file)
--- a/maintenance/commandLine.inc
+++ b/maintenance/commandLine.inc
@@ -41,8 +41,9 @@ class CommandLineInc extends Maintenance {
         * No help, it would just be misleading since it misses custom options
         */
        protected function maybeHelp( $force = false ) {
-               if ( !$force )
+               if ( !$force ) {
                        return;
+               }
                parent::maybeHelp( true );
        }
 

diff --git a/maintenance/runJobs.php b/maintenance/runJobs.php
index 0edf7ac..6068311 100644 (file)
--- a/maintenance/runJobs.php
+++ b/maintenance/runJobs.php
@@ -61,16 +61,18 @@ class RunJobs extends Maintenance {
                $dbw = wfGetDB( DB_MASTER );
                $n = 0;
                $conds = '';
-               if ( $type !== false )
+               if ( $type !== false ) {
                        $conds = "job_cmd = " . $dbw->addQuotes( $type );
+               }
 
                while ( $dbw->selectField( 'job', 'job_id', $conds, 'runJobs.php' ) ) {
                        $offset = 0;
                        for ( ; ; ) {
                                $job = !$type ? Job::pop( $offset ) : Job::pop_type( $type );
 
-                               if ( !$job )
+                               if ( !$job ) {
                                        break;
+                               }
 
                                wfWaitForSlaves();
                                $t = microtime( true );