put a @ on a chmod, since all other file ops in there are so marked.
authorBrion Vibber <brion@users.mediawiki.org>
Wed, 30 Jan 2008 01:06:28 +0000 (01:06 +0000)
committerBrion Vibber <brion@users.mediawiki.org>
Wed, 30 Jan 2008 01:06:28 +0000 (01:06 +0000)
redundant chmods can bring warnings if we don't own the file (even though it's already world-writable)

includes/filerepo/FSRepo.php

index 84ec9a2..86887d0 100644 (file)
@@ -422,7 +422,7 @@ class FSRepo extends FileRepo {
                                        $status->error( 'filerenameerror', $srcPath, $archivePath );
                                        $good = false;
                                } else {
-                                       chmod( $archivePath, 0644 );
+                                       @chmod( $archivePath, 0644 );
                                }
                        }
                        if ( $good ) {