*Syntax cleanup
authorAaron Schulz <aaron@users.mediawiki.org>
Thu, 15 Mar 2007 03:15:20 +0000 (03:15 +0000)
committerAaron Schulz <aaron@users.mediawiki.org>
Thu, 15 Mar 2007 03:15:20 +0000 (03:15 +0000)
skins/common/protect.js

index 7641236..26eddaa 100644 (file)
@@ -46,12 +46,10 @@ function allowCascade() {
        for (var i = 0; i < pr_types.length; i++) {
                if (pr_types[i].id.match(/^mwProtect-level-/)) {
                        var selected_level = pr_types[i].getElementsByTagName("option")[pr_types[i].selectedIndex].value;
-                       for (var k=0; k < wgCascadeableLevels.length; k++) {
-                               if ( wgCascadeableLevels[k] != selected_level ) {
-                                       document.getElementById('mwProtect-cascade').checked=false;
-                                       document.getElementById('mwProtect-cascade').disabled=true;
-                                       return false;
-                               }
+                       if ( !isCascadeableLevel(selected_level) ) {
+                               document.getElementById('mwProtect-cascade').checked=false;
+                               document.getElementById('mwProtect-cascade').disabled=true;
+                               return false;
                        }
                }
        }
@@ -59,6 +57,15 @@ function allowCascade() {
        return true;
 }
 
+function isCascadeableLevel( level ) {
+       for (var k = 0; k < wgCascadeableLevels.length; k++) {
+               if ( wgCascadeableLevels[k] == level ) {
+                       return true;
+               }
+       }
+       return false;
+}
+
 function protectLevelsUpdate(source) {
        if (!protectUnchained()) {
                protectUpdateAll(source.selectedIndex);