Add fixme note to replace 'mysql' command-line callout with proper usage of a second...

diff --git a/maintenance/populateSha1.php b/maintenance/populateSha1.php
index 4233cb2..72ef946 100644 (file)
--- a/maintenance/populateSha1.php
+++ b/maintenance/populateSha1.php
@@ -56,6 +56,7 @@ class PopulateSha1 extends Maintenance {
                $batch = array();
        
                if ( $method == 'pipe' ) {
+                       // @fixme kill this and replace with a second unbuffered DB connection.
                        global $wgDBuser, $wgDBserver, $wgDBpassword, $wgDBname;
                        $cmd = 'mysql -u' . wfEscapeShellArg( $wgDBuser ) . 
                                ' -h' . wfEscapeShellArg( $wgDBserver ) .