Avoid error in querypage API when there's no value field
authorGergő Tisza <tgr.huwiki@gmail.com>
Fri, 2 Aug 2019 13:41:36 +0000 (15:41 +0200)
committerGergő Tisza <tgr.huwiki@gmail.com>
Fri, 2 Aug 2019 14:05:01 +0000 (16:05 +0200)
QueryPage does not require a value field, and post I8b67268e omitting
it might even be useful, so the API should not error out when it's
not present.

Change-Id: I83b49d4451ba71bb2161459bddf17b9ac00088d2

includes/api/ApiQueryQueryPage.php

index ea20664..26c17c5 100644 (file)
@@ -122,9 +122,12 @@ class ApiQueryQueryPage extends ApiQueryGeneratorBase {
 
                        $title = Title::makeTitle( $row->namespace, $row->title );
                        if ( is_null( $resultPageSet ) ) {
-                               $data = [ 'value' => $row->value ];
-                               if ( $qp->usesTimestamps() ) {
-                                       $data['timestamp'] = wfTimestamp( TS_ISO_8601, $row->value );
+                               $data = [];
+                               if ( isset( $row->value ) ) {
+                                       $data['value'] = $row->value;
+                                       if ( $qp->usesTimestamps() ) {
+                                               $data['timestamp'] = wfTimestamp( TS_ISO_8601, $row->value );
+                                       }
                                }
                                self::addTitleInfo( $data, $title );