Disable "...able to change preferences" browser test

[lhc/web/wiklou.git] / tests / selenium / specs / user.js

diff --git a/tests/selenium/specs/user.js b/tests/selenium/specs/user.js
index 62aac05..4884ded 100644 (file)
--- a/tests/selenium/specs/user.js
+++ b/tests/selenium/specs/user.js
@@ -1,7 +1,9 @@
 const assert = require( 'assert' ),
        CreateAccountPage = require( '../pageobjects/createaccount.page' ),
        PreferencesPage = require( '../pageobjects/preferences.page' ),
-       UserLoginPage = require( '../pageobjects/userlogin.page' );
+       UserLoginPage = require( 'wdio-mediawiki/LoginPage' ),
+       Api = require( 'wdio-mediawiki/Api' ),
+       Util = require( 'wdio-mediawiki/Util' );
 
 describe( 'User', function () {
        var password,
@@ -15,8 +17,8 @@ describe( 'User', function () {
 
        beforeEach( function () {
                browser.deleteCookie();
-               username = `User-${Math.random().toString()}`;
-               password = Math.random().toString();
+               username = Util.getTestString( 'User-' );
+               password = Util.getTestString();
        } );
 
        it( 'should be able to create account', function () {
@@ -24,28 +26,29 @@ describe( 'User', function () {
                CreateAccountPage.createAccount( username, password );
 
                // check
-               assert.equal( CreateAccountPage.heading.getText(), `Welcome, ${username}!` );
+               assert.strictEqual( CreateAccountPage.heading.getText(), `Welcome, ${username}!` );
        } );
 
        it( 'should be able to log in', function () {
                // create
                browser.call( function () {
-                       return CreateAccountPage.apiCreateAccount( username, password );
+                       return Api.createAccount( username, password );
                } );
 
                // log in
                UserLoginPage.login( username, password );
 
                // check
-               assert.equal( UserLoginPage.userPage.getText(), username );
+               assert.strictEqual( UserLoginPage.userPage.getText(), username );
        } );
 
-       it( 'should be able to change preferences', function () {
-               var realName = Math.random().toString();
+       // Disabled due to flakiness (T199446)
+       it.skip( 'should be able to change preferences', function () {
+               var realName = Util.getTestString();
 
                // create
                browser.call( function () {
-                       return CreateAccountPage.apiCreateAccount( username, password );
+                       return Api.createAccount( username, password );
                } );
 
                // log in
@@ -55,6 +58,6 @@ describe( 'User', function () {
                PreferencesPage.changeRealName( realName );
 
                // check
-               assert.equal( PreferencesPage.realName.getValue(), realName );
+               assert.strictEqual( PreferencesPage.realName.getValue(), realName );
        } );
 } );