From 7922a4c78956b83002533658f8d14bc3789ed667 Mon Sep 17 00:00:00 2001 From: umherirrender Date: Sat, 16 Apr 2016 12:16:48 +0200 Subject: [PATCH] Remove dead code from CategoryPager Remove dead code about an alternate sort on Special:Categories. This also removes the unused system messages. To get a list of the count of categories, it is possible to use Special:MostLinkedCategories Change-Id: Ie41218a28cde52222809eafe2e9e92e4a4e38a2e --- includes/specials/pagers/CategoryPager.php | 14 -------------- languages/i18n/en.json | 2 -- languages/i18n/qqq.json | 2 -- 3 files changed, 18 deletions(-) diff --git a/includes/specials/pagers/CategoryPager.php b/includes/specials/pagers/CategoryPager.php index fd2ac1f75f..cba4952b6f 100644 --- a/includes/specials/pagers/CategoryPager.php +++ b/includes/specials/pagers/CategoryPager.php @@ -20,9 +20,6 @@ */ /** - * TODO: Allow sorting by count. We need to have a unique index to do this - * properly. - * * @ingroup Pager */ class CategoryPager extends AlphabeticPager { @@ -60,7 +57,6 @@ class CategoryPager extends AlphabeticPager { } function getIndexField() { -# return array( 'abc' => 'cat_title', 'count' => 'cat_pages' ); return 'cat_title'; } @@ -71,16 +67,6 @@ class CategoryPager extends AlphabeticPager { return $this->mDefaultQuery; } -# protected function getOrderTypeMessages() { -# return array( 'abc' => 'special-categories-sort-abc', -# 'count' => 'special-categories-sort-count' ); -# } - - protected function getDefaultDirections() { -# return array( 'abc' => false, 'count' => true ); - return false; - } - /* Override getBody to apply LinksBatch on resultset before actually outputting anything. */ public function getBody() { $batch = new LinkBatch; diff --git a/languages/i18n/en.json b/languages/i18n/en.json index 55ae93ef28..4bbfa2292d 100644 --- a/languages/i18n/en.json +++ b/languages/i18n/en.json @@ -1933,8 +1933,6 @@ "categories-submit": "Show", "categoriespagetext": "The following {{PLURAL:$1|category contains|categories contain}} pages or media.\n[[Special:UnusedCategories|Unused categories]] are not shown here.\nAlso see [[Special:WantedCategories|wanted categories]].", "categoriesfrom": "Display categories starting at:", - "special-categories-sort-count": "sort by count", - "special-categories-sort-abc": "sort alphabetically", "deletedcontributions": "Deleted user contributions", "deletedcontributions-summary": "", "deletedcontributions-title": "Deleted user contributions", diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json index 4975c2ec96..7a5eb935f8 100644 --- a/languages/i18n/qqq.json +++ b/languages/i18n/qqq.json @@ -2110,8 +2110,6 @@ "categories-submit": "Submit button on [[Special:Categories]]\n{{Identical|Show}}", "categoriespagetext": "{{doc-important|Do not translate or change links.}}\nText displayed in [[Special:Categories]].\n\nIn order to translate \"Unused categories\" and \"wanted categories\" see {{msg-mw|Unusedcategories}} and {{msg-mw|Wantedcategories}}.\n\nParameters:\n* $1 - number of categories", "categoriesfrom": "Used as label for the input box in [[Special:Categories]].\n\nThis message follows the fieldset label {{msg-mw|categories}}, and is followed by the input box.", - "special-categories-sort-count": "Commented out at this time.\n\nThis message is used on [[Special:Categories]] to sort the list by the number of members in the categories.\n\nSee also:\n* {{msg-mw|Special-categories-sort-abc}}", - "special-categories-sort-abc": "Commented out at this time.\n\nThis message is used on [[Special:Categories]] to sort the list by the category name.\n\nSee also:\n* {{msg-mw|Special-categories-sort-count}}\n{{Identical|Sort alphabetically}}", "deletedcontributions": "The message is shown as a link on [[Special:SpecialPages]] to [[Special:DeletedContributions]].\n\n{{Identical|Deleted user contributions}}", "deletedcontributions-summary": "{{doc-specialpagesummary|deletedcontributions}}", "deletedcontributions-title": "Title of [[Special:DeletedContributions]] (extension), a special page with a list of edits to pages which were deleted. Only viewable by sysops.\n\n{{Identical|Deleted user contributions}}", -- 2.20.1