From 77f1f0ace74b2e36a366532b0532f7fec469e1e1 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Fri, 21 Aug 2009 21:26:34 +0000 Subject: [PATCH] No need to store the value of the magic quotes check here; just use a local var for clarity. --- includes/WebRequest.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/includes/WebRequest.php b/includes/WebRequest.php index 157f09305d..22057d40d8 100644 --- a/includes/WebRequest.php +++ b/includes/WebRequest.php @@ -44,7 +44,7 @@ if ( !function_exists( '__autoload' ) ) { */ class WebRequest { protected $data, $headers = array(); - private $_response, $mFixMagicQuotes; + private $_response; public function __construct() { /// @fixme This preemptive de-quoting can interfere with other web libraries @@ -179,8 +179,9 @@ class WebRequest { * time could damage the values. */ private function checkMagicQuotes() { - $this->mFixMagicQuotes = function_exists( 'get_magic_quotes_gpc' ) && get_magic_quotes_gpc(); - if( $this->mFixMagicQuotes ) { + $mustFixQuotes = function_exists( 'get_magic_quotes_gpc' ) + && get_magic_quotes_gpc(); + if( $mustFixQuotes ) { $this->fix_magic_quotes( $_COOKIE ); $this->fix_magic_quotes( $_ENV ); $this->fix_magic_quotes( $_GET ); -- 2.20.1