From 0597984bd8ec648d3d040a54897b8d381d76d6f1 Mon Sep 17 00:00:00 2001
From: Reedy <reedy@wikimedia.org>
Date: Fri, 15 Jun 2012 15:05:49 +0100
Subject: [PATCH] Fixup some wrong documentation

Don't try and return the result of void functions

Change-Id: I7a4db738b3e3052aebcf43742d31753f8cc1f47a
---
 includes/Article.php   | 2 +-
 includes/EditPage.php  | 1 -
 includes/HTMLForm.php  | 4 ++--
 includes/SiteStats.php | 4 ++--
 includes/WikiPage.php  | 2 +-
 5 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/includes/Article.php b/includes/Article.php
index 15b2056146..eb931d2e3e 100644
--- a/includes/Article.php
+++ b/includes/Article.php
@@ -1408,7 +1408,7 @@ class Article extends Page {
 			}
 		}
 
-		return $this->confirmDelete( $reason );
+		$this->confirmDelete( $reason );
 	}
 
 	/**
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 9e337fde31..6e6f825f81 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -1063,7 +1063,6 @@ class EditPage {
 					'</div>';
 				return true;
 		}
-		return false;
 	}
 
 	/**
diff --git a/includes/HTMLForm.php b/includes/HTMLForm.php
index 4f696382e4..36008fb337 100644
--- a/includes/HTMLForm.php
+++ b/includes/HTMLForm.php
@@ -727,7 +727,7 @@ class HTMLForm extends ContextSource {
 	 * @param $msg String message key
 	 */
 	public function setSubmitTextMsg( $msg ) {
-		return $this->setSubmitText( $this->msg( $msg )->text() );
+		$this->setSubmitText( $this->msg( $msg )->text() );
 	}
 
 	/**
@@ -775,7 +775,7 @@ class HTMLForm extends ContextSource {
 	 * @param $msg String message key
 	 */
 	public function setWrapperLegendMsg( $msg ) {
-		return $this->setWrapperLegend( $this->msg( $msg )->escaped() );
+		$this->setWrapperLegend( $this->msg( $msg )->escaped() );
 	}
 
 	/**
diff --git a/includes/SiteStats.php b/includes/SiteStats.php
index 10aed9cc9a..7f3f65556f 100644
--- a/includes/SiteStats.php
+++ b/includes/SiteStats.php
@@ -391,7 +391,7 @@ class SiteStatsUpdate implements DeferrableUpdate {
 	/**
 	 * @param $type string
 	 * @param $sign string ('+' or '-')
-	 * @return void
+	 * @return string
 	 */
 	private function getTypeCacheKey( $type, $sign ) {
 		return wfMemcKey( 'sitestatsupdate', 'pendingdelta', $type, $sign );
@@ -443,7 +443,7 @@ class SiteStatsUpdate implements DeferrableUpdate {
 
 	/**
 	 * Reduce pending delta counters after updates have been applied
-	 * @param Array Result of getPendingDeltas(), used for DB update
+	 * @param Array $pd Result of getPendingDeltas(), used for DB update
 	 * @return void
 	 */
 	protected function removePendingDeltas( array $pd ) {
diff --git a/includes/WikiPage.php b/includes/WikiPage.php
index 0ba517a259..40e0ec3b99 100644
--- a/includes/WikiPage.php
+++ b/includes/WikiPage.php
@@ -2967,7 +2967,7 @@ class WikiPage extends Page {
 	public function quickEdit( $text, $comment = '', $minor = 0 ) {
 		wfDeprecated( __METHOD__, '1.18' );
 		global $wgUser;
-		return $this->doQuickEdit( $text, $wgUser, $comment, $minor );
+		$this->doQuickEdit( $text, $wgUser, $comment, $minor );
 	}
 
 	/**
-- 
2.20.1