From: Aaron Schulz <aschulz@wikimedia.org>
Date: Sat, 9 Sep 2017 20:57:35 +0000 (-0700)
Subject: Remove use of implicitGroupby() in WikiPage
X-Git-Tag: 1.31.0-rc.0~2046^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/%7B%7B%20url_for%28%27admin_users%27%29%20%7D%7D?a=commitdiff_plain;h=8555891d6827b1ba3b69501a2572c09e2b20beb3;p=lhc%2Fweb%2Fwiklou.git

Remove use of implicitGroupby() in WikiPage

Change-Id: I17cc3ae5a6e90ba49978606e9ca6a1cdcdb57c03
---

diff --git a/includes/page/WikiPage.php b/includes/page/WikiPage.php
index bf8a59710d..29ee533cee 100644
--- a/includes/page/WikiPage.php
+++ b/includes/page/WikiPage.php
@@ -982,18 +982,12 @@ class WikiPage implements Page, IDBAccessObject {
 
 		$dbr = wfGetDB( DB_REPLICA );
 
-		if ( $dbr->implicitGroupby() ) {
-			$realNameField = 'user_real_name';
-		} else {
-			$realNameField = 'MIN(user_real_name) AS user_real_name';
-		}
-
 		$tables = [ 'revision', 'user' ];
 
 		$fields = [
 			'user_id' => 'rev_user',
 			'user_name' => 'rev_user_text',
-			$realNameField,
+			'user_real_name' => 'MIN(user_real_name)',
 			'timestamp' => 'MAX(rev_timestamp)',
 		];