From: Niklas Laxström <nikerabbit@users.mediawiki.org>
Date: Fri, 18 Apr 2008 06:57:47 +0000 (+0000)
Subject: * Expiry handling is really sub-optimal here
X-Git-Tag: 1.31.0-rc.0~48210
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/%7B%7B%20url_for%28%27admin_users%27%29%20%7D%7D?a=commitdiff_plain;h=2b6cfa578c39158ffe3bd4ea26ffe2330605ee2a;p=lhc%2Fweb%2Fwiklou.git

* Expiry handling is really sub-optimal here
---

diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php
index 6f57bc2547..0929461b9d 100644
--- a/includes/ProtectionForm.php
+++ b/includes/ProtectionForm.php
@@ -54,7 +54,8 @@ class ProtectionForm {
 			} else if ( strlen($this->mTitle->mRestrictionsExpiry) == 0 ) {
 				$this->mExpiry = '';
 			} else {
-				$this->mExpiry = wfTimestamp( TS_RFC2822, $this->mTitle->mRestrictionsExpiry );
+				// FIXME: this format is not user friendly
+				$this->mExpiry = wfTimestamp( TS_ISO_8601, $this->mTitle->mRestrictionsExpiry );
 			}
 		}
 
@@ -170,6 +171,8 @@ class ProtectionForm {
 				return false;
 			}
 
+			// Fixme: non-qualified absolute times are not in users specified timezone
+			// and there isn't notice about it in the ui
 			$expiry = wfTimestamp( TS_MW, $expiry );
 
 			if ( $expiry < wfTimestampNow() ) {