From: Timo Tijhof <krinklemail@gmail.com>
Date: Wed, 4 Oct 2017 20:08:46 +0000 (+0100)
Subject: mediawiki.notification: Use css() instead of slow show()/hide()
X-Git-Tag: 1.31.0-rc.0~1874^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/%7B%7B%20url_for%28%27admin_users%27%29%20%7D%7D?a=commitdiff_plain;h=0a1d26210c379774b481a82e1c4ab5135906ec8e;p=lhc%2Fweb%2Fwiklou.git

mediawiki.notification: Use css() instead of slow show()/hide()

There is a lot of complexity and overhead involved with show()
and hide() methods for back-compat and edge cases that we don't
want to involve here (such as storing the last known display,
figuring out the default display, dealing with elements hidden
by default via CSS rules etc.).

We know the stylesheet does not hide the element by default, so
we merely need to set or unset the 'display: none;' inline style.

Ref T159911.

Change-Id: Ia22a2adddddf8514368124d93e3a753440814d97
---

diff --git a/resources/src/mediawiki/mediawiki.notification.js b/resources/src/mediawiki/mediawiki.notification.js
index dfacfc6650..c213cd2df4 100644
--- a/resources/src/mediawiki/mediawiki.notification.js
+++ b/resources/src/mediawiki/mediawiki.notification.js
@@ -102,7 +102,7 @@
 	Notification.prototype.start = function () {
 		var options, $notification, $tagMatches, autohideCount;
 
-		$area.show();
+		$area.css( 'display', '' );
 
 		if ( this.isOpen ) {
 			return;
@@ -230,7 +230,7 @@
 				if ( openNotificationCount === 0 ) {
 					// Hide the area after the last notification closes. Otherwise, the padding on
 					// the area can be obscure content, despite the area being empty/invisible (T54659). // FIXME
-					$area.hide();
+					$area.css( 'display', 'none' );
 					notif.$notification.remove();
 				} else {
 					notif.$notification.slideUp( 'fast', function () {
@@ -291,7 +291,7 @@
 		// Prepend the notification area to the content area and save it's object.
 		mw.util.$content.prepend( $area );
 		offset = $area.offset();
-		$area.hide();
+		$area.css( 'display', 'none' );
 
 		function updateAreaMode() {
 			var shouldFloat = window.pageYOffset > offset.top;