In QueryPage: fixing a misleading comment. value needn't be numeric.

In SpecialUncategorizedpages.php: Fixing embarrassing SQL stupidity
   on my part. The article that contains the category link is cl_from,
   not cl_to. Duh.

diff --git a/includes/QueryPage.php b/includes/QueryPage.php
index 0e8cef3..57d412d 100644 (file)
--- a/includes/QueryPage.php
+++ b/includes/QueryPage.php
@@ -16,11 +16,12 @@ class QueryPage {
 
        # Subclasses return an SQL query here.
        #
-       # Note that the query itself should return the following three columns:
-       # 'type' (your special page's name), 'namespace, 'title', and 'value'
-       # (numeric) *in that order*. These may be stored in the querycache table
-       # for expensive queries, and that cached data will be returned sometimes,
-       # so the presence of extra fields can't be relied on.
+       # Note that the query itself should return the following four columns:
+       # 'type' (your special page's name), 'namespace', 'title', and 'value'
+       # *in that order*. 'value' is used for sorting. These may be stored in
+       # the querycache table for expensive queries, and that cached data will
+       # be returned sometimes, so the presence of extra fields can't be
+       # relied upon.
        #
        # Don't include an ORDER or LIMIT clause, this will be added.
 

diff --git a/includes/SpecialUncategorizedpages.php b/includes/SpecialUncategorizedpages.php
index 6c374d8..8faeff6 100755 (executable)
--- a/includes/SpecialUncategorizedpages.php
+++ b/includes/SpecialUncategorizedpages.php
@@ -21,8 +21,8 @@ class UncategorizedPagesPage extends PageQueryPage {
                extract( $dbr->tableNames( 'cur', 'categorylinks' ) );
 
                return "SELECT 'Uncategorizedpages' as type, cur_namespace AS namespace, cur_title AS title, cur_title AS value " .
-                       "FROM $cur LEFT JOIN $categorylinks ON cur_id=cl_to ".
-                       "WHERE cl_to IS NULL AND cur_namespace=0 AND cur_is_redirect=0";
+                       "FROM $cur LEFT JOIN $categorylinks ON cur_id=cl_from ".
+                       "WHERE cl_from IS NULL AND cur_namespace=0 AND cur_is_redirect=0";
        }
 }