* (bug 21234) Moving subpages of titles containing \\ now works properly

Per http://www.php.net/manual/en/function.preg-replace.php \ must be doubled in $replacement

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 3fe43f9..fc3a38d 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -584,6 +584,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 21161) Changing $wgCacheEpoch now always invalidates file cache
 * (bug 20268) Fixed row count estimation on SQLite backend
 * (bug 20275) Fixed LIKE queries on SQLite backend
+* (bug 21234) Moving subpages of titles containing \\ now works properly
 
 == API changes in 1.16 ==
 

diff --git a/includes/Title.php b/includes/Title.php
index 44df731..e461529 100644 (file)
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -3114,7 +3114,8 @@ class Title {
                                continue;
                        $newPageName = preg_replace(
                                        '#^'.preg_quote( $this->getDBkey(), '#' ).'#',
-                                       $nt->getDBkey(), $oldSubpage->getDBkey() );
+                                       str_replace( '\\', '\\\\', $nt->getDBkey() ), # bug 21234
+                                       $oldSubpage->getDBkey() );
                        if( $oldSubpage->isTalkPage() ) {
                                $newNs = $nt->getTalkPage()->getNamespace();
                        } else {

diff --git a/includes/specials/SpecialMovepage.php b/includes/specials/SpecialMovepage.php
index ed5d03c..391cfbb 100644 (file)
--- a/includes/specials/SpecialMovepage.php
+++ b/includes/specials/SpecialMovepage.php
@@ -458,7 +458,7 @@ class MovePageForm {
 
                        $newPageName = preg_replace(
                                '#^'.preg_quote( $ot->getDBkey(), '#' ).'#',
-                               $nt->getDBkey(),
+                               str_replace( '\\', '\\\\', $nt->getDBkey() ), # bug 21234
                                $oldSubpage->getDBkey()
                        );
                        if( $oldSubpage->isTalkPage() ) {