From efe4525d2c407437a33de0c11b14f89d4208e201 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Fri, 15 Apr 2011 23:28:13 +0000 Subject: [PATCH] Merge r81448 from REL1_17: reverting RevisionMove feature back out until somebody has the time to work on it again. Reverts r67094 and its followups in trunk: r67099, r67111, r67112, r67115, r67398, r81425, r81427 --- includes/Article.php | 10 +- includes/AutoLoader.php | 1 - includes/DefaultSettings.php | 1 - includes/HistoryPage.php | 8 +- includes/LogPage.php | 2 +- includes/SpecialPage.php | 1 - includes/Wiki.php | 5 - includes/specials/SpecialRevisionMove.php | 400 ---------------------- languages/messages/MessagesEn.php | 23 -- maintenance/language/messageTypes.inc | 1 - maintenance/language/messages.inc | 22 -- 11 files changed, 5 insertions(+), 469 deletions(-) delete mode 100644 includes/specials/SpecialRevisionMove.php diff --git a/includes/Article.php b/includes/Article.php index dbb78f526e..7dd19ddd41 100644 --- a/includes/Article.php +++ b/includes/Article.php @@ -1762,12 +1762,10 @@ class Article { * on. * @param $lastRevIsRedirect Boolean: if given, will optimize adding and * removing rows in redirect table. - * @param $setNewFlag Boolean: Set to true if a page flag should be set - * Needed when $lastRevision has to be set to sth. !=0 * @return bool true on success, false on failure * @private */ - public function updateRevisionOn( &$dbw, $revision, $lastRevision = null, $lastRevIsRedirect = null, $setNewFlag = false ) { + public function updateRevisionOn( &$dbw, $revision, $lastRevision = null, $lastRevIsRedirect = null ) { wfProfileIn( __METHOD__ ); $text = $revision->getText(); @@ -1780,15 +1778,11 @@ class Article { $conditions['page_latest'] = $lastRevision; } - if ( !$setNewFlag ) { - $setNewFlag = ( $lastRevision === 0 ); - } - $dbw->update( 'page', array( /* SET */ 'page_latest' => $revision->getId(), 'page_touched' => $dbw->timestamp(), - 'page_is_new' => $setNewFlag, + 'page_is_new' => ( $lastRevision === 0 ) ? 1 : 0, 'page_is_redirect' => $rt !== null ? 1 : 0, 'page_len' => strlen( $text ), ), diff --git a/includes/AutoLoader.php b/includes/AutoLoader.php index a19433be9a..7ede724ee7 100644 --- a/includes/AutoLoader.php +++ b/includes/AutoLoader.php @@ -673,7 +673,6 @@ $wgAutoloadLocalClasses = array( 'RevDel_ArchivedFileItem' => 'includes/revisiondelete/RevisionDelete.php', 'RevDel_LogList' => 'includes/revisiondelete/RevisionDelete.php', 'RevDel_LogItem' => 'includes/revisiondelete/RevisionDelete.php', - 'SpecialRevisionMove' => 'includes/specials/SpecialRevisionMove.php', 'ShortPagesPage' => 'includes/specials/SpecialShortpages.php', 'SpecialActiveUsers' => 'includes/specials/SpecialActiveusers.php', 'SpecialAllpages' => 'includes/specials/SpecialAllpages.php', diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index bc147c443b..3080df4cef 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -4834,7 +4834,6 @@ $wgLogActions = array( 'upload/revert' => 'uploadedimage', 'move/move' => '1movedto2', 'move/move_redir' => '1movedto2_redir', - 'move/move_rev' => 'moverevlogentry', 'import/upload' => 'import-logentry-upload', 'import/interwiki' => 'import-logentry-interwiki', 'merge/merge' => 'pagemerge-logentry', diff --git a/includes/HistoryPage.php b/includes/HistoryPage.php index 8c584f9483..961e8639eb 100644 --- a/includes/HistoryPage.php +++ b/includes/HistoryPage.php @@ -403,9 +403,6 @@ class HistoryPager extends ReverseChronologicalPager { if ( $wgUser->isAllowed( 'deleterevision' ) ) { $s .= $this->getRevisionButton( 'revisiondelete', 'showhideselectedversions' ); } - if ( $wgUser->isAllowed( 'revisionmove' ) ) { - $s .= $this->getRevisionButton( 'revisionmove', 'revisionmoveselectedversions' ); - } $this->buttons .= ''; $s .= '