From: Fomafix <fomafix@googlemail.com>
Date: Sat, 1 Sep 2018 14:07:57 +0000 (+0200)
Subject: resourceloader: Avoid duplicate existence check
X-Git-Tag: 1.34.0-rc.0~4210
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/supprimer.php?a=commitdiff_plain;h=c407ffc869704125ad26cc9643a655fe1fec0c13;p=lhc%2Fweb%2Fwiklou.git

resourceloader: Avoid duplicate existence check

The check above with the mw.loader.register( name ) ensures that
  hasOwn.call( registry, name )
is always true.

Change-Id: I10e2a23bd5c11fbf53fd4fc59ba2e5d94f157254
---

diff --git a/resources/src/startup/mediawiki.js b/resources/src/startup/mediawiki.js
index f927aade54..e665403ddb 100644
--- a/resources/src/startup/mediawiki.js
+++ b/resources/src/startup/mediawiki.js
@@ -1828,7 +1828,7 @@
 						mw.loader.register( name );
 					}
 					// Check for duplicate implementation
-					if ( hasOwn.call( registry, name ) && registry[ name ].script !== undefined ) {
+					if ( registry[ name ].script !== undefined ) {
 						throw new Error( 'module already implemented: ' + name );
 					}
 					if ( version ) {