From ae31d3f7cc33abbd19453f9e878229fd1d4f013a Mon Sep 17 00:00:00 2001 From: Domas Mituzas Date: Sun, 2 Dec 2007 16:17:30 +0000 Subject: [PATCH] mark unused images as expensive, and fix queries to be cacheable --- includes/SpecialUnusedimages.php | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/includes/SpecialUnusedimages.php b/includes/SpecialUnusedimages.php index 52aa19d26b..9e9b3932f0 100644 --- a/includes/SpecialUnusedimages.php +++ b/includes/SpecialUnusedimages.php @@ -9,7 +9,9 @@ * @addtogroup SpecialPage */ class UnusedimagesPage extends ImageQueryPage { - + + function isExpensive() { return true; } + function getName() { return 'Unusedimages'; } @@ -26,16 +28,18 @@ class UnusedimagesPage extends ImageQueryPage { if ( $wgCountCategorizedImagesAsUsed ) { list( $page, $image, $imagelinks, $categorylinks ) = $dbr->tableNamesN( 'page', 'image', 'imagelinks', 'categorylinks' ); - return 'SELECT img_name as title, img_user, img_user_text, img_timestamp as value, img_description - FROM ((('.$page.' AS I LEFT JOIN '.$categorylinks.' AS L ON I.page_id = L.cl_from) - LEFT JOIN '.$imagelinks.' AS P ON I.page_title = P.il_to) - INNER JOIN '.$image.' AS G ON I.page_title = G.img_name) - WHERE I.page_namespace = '.NS_IMAGE.' AND L.cl_from IS NULL AND P.il_to IS NULL'; + return "SELECT 'Unusedimages' as type, 6 as namespace, img_name as title, img_timestamp as value, + img_user, img_user_text, img_description + FROM ((($page AS I LEFT JOIN $categorylinks AS L ON I.page_id = L.cl_from) + LEFT JOIN $imagelinks AS P ON I.page_title = P.il_to) + INNER JOIN $image AS G ON I.page_title = G.img_name) + WHERE I.page_namespace = ".NS_IMAGE." AND L.cl_from IS NULL AND P.il_to IS NULL"; } else { list( $image, $imagelinks ) = $dbr->tableNamesN( 'image','imagelinks' ); - return 'SELECT img_name as title, img_user, img_user_text, img_timestamp as value, img_description' . - ' FROM '.$image.' LEFT JOIN '.$imagelinks.' ON img_name=il_to WHERE il_to IS NULL '; + return "SELECT 'Unusedimages' as type, 6 as namespace, img_name as title, img_timestamp as value, + img_user, img_user_text, img_description + FROM $image LEFT JOIN $imagelinks ON img_name=il_to WHERE il_to IS NULL "; } } -- 2.20.1