From 466c29847d91d1da7e5808a1dea91226ab76a177 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Sat, 28 Feb 2015 18:25:33 +0100 Subject: [PATCH] installer: Remove unused references to wgResourceLoaderMaxQueryLength * Added in 40e18e45343. * Removed in 648bed9f839 (r87494). The latter left the Installer::values array still populating this variable eventhough it was no longer used in the generators output. The example in overrides.php is also outdated as modifying this variable there would have no effect. Change-Id: I0c86e94a004c034702c5fcd83257c0f4c3d15a57 --- includes/installer/Installer.php | 1 - includes/installer/LocalSettingsGenerator.php | 2 +- mw-config/overrides.php | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php index 1036dcda08..91195e9144 100644 --- a/includes/installer/Installer.php +++ b/includes/installer/Installer.php @@ -186,7 +186,6 @@ abstract class Installer { 'wgUseInstantCommons', 'wgUpgradeKey', 'wgDefaultSkin', - 'wgResourceLoaderMaxQueryLength', ); /** diff --git a/includes/installer/LocalSettingsGenerator.php b/includes/installer/LocalSettingsGenerator.php index c0ba300d36..8724e0df33 100644 --- a/includes/installer/LocalSettingsGenerator.php +++ b/includes/installer/LocalSettingsGenerator.php @@ -63,7 +63,7 @@ class LocalSettingsGenerator { 'wgRightsText', 'wgMainCacheType', 'wgEnableUploads', 'wgMainCacheType', '_MemCachedServers', 'wgDBserver', 'wgDBuser', 'wgDBpassword', 'wgUseInstantCommons', 'wgUpgradeKey', 'wgDefaultSkin', - 'wgMetaNamespace', 'wgResourceLoaderMaxQueryLength', 'wgLogo', + 'wgMetaNamespace', 'wgLogo', ), $db->getGlobalNames() ); diff --git a/mw-config/overrides.php b/mw-config/overrides.php index 57581525c8..40b3ddee2d 100644 --- a/mw-config/overrides.php +++ b/mw-config/overrides.php @@ -38,7 +38,7 @@ Then add the following to the bottom of this file: class MyLocalSettingsGenerator extends LocalSettingsGenerator { function getText() { // Modify an existing setting - $this->values['wgResourceLoaderMaxQueryLength'] = 512; + $this->values['wgDefaultSkin'] = 'vector'; // add a new setting $ls = parent::getText(); return $ls . "\n\$wgUseTex = true;\n"; -- 2.20.1