Jure Kajzer [Wed, 27 Oct 2010 14:52:18 +0000 (14:52 +0000)]
* installers skips recreation of existing user
* updater for 16->17 schema changes
* i dedicate this revision to my greatest supporter ... Reedy :)
Platonides [Wed, 27 Oct 2010 14:46:58 +0000 (14:46 +0000)]
r75540 CR
Platonides [Wed, 27 Oct 2010 14:38:31 +0000 (14:38 +0000)]
Make update.php obey --quiet
Platonides [Wed, 27 Oct 2010 13:56:58 +0000 (13:56 +0000)]
Follow up r75474
Chad Horohoe [Wed, 27 Oct 2010 13:18:14 +0000 (13:18 +0000)]
Don't show new and ok message at the same time
Chad Horohoe [Wed, 27 Oct 2010 12:19:56 +0000 (12:19 +0000)]
Remove unnecessary writable config dir check
Roan Kattouw [Wed, 27 Oct 2010 11:50:20 +0000 (11:50 +0000)]
Followup to r75266: remove warning "rvlimit may not be less than 1 (set to )" when rvparse is set but rvlimit is not set
Siebrand Mazeland [Wed, 27 Oct 2010 11:18:13 +0000 (11:18 +0000)]
Follow-up r75499: initialise $anchorclose to prevent PHP Notice: Undefined variable: anchorclose on line 390.
Derk-Jan Hartman [Wed, 27 Oct 2010 01:56:23 +0000 (01:56 +0000)]
Line endings in wikitext can introduce <p>'s, which was not really the intent here for the fullMedia div.
Derk-Jan Hartman [Wed, 27 Oct 2010 01:50:07 +0000 (01:50 +0000)]
Make the image page more consistent. Now all pages will have the fullMedia div. (with link, and file description)
Perhaps we should move the "Size of this preview:" and "No higher resolution available" markers into that div as well ? Feedback welcome.
Trevor Parscal [Wed, 27 Oct 2010 00:16:32 +0000 (00:16 +0000)]
Mostly reverted r75487, making use of a new version of mediaWiki.msg.
Trevor Parscal [Wed, 27 Oct 2010 00:04:33 +0000 (00:04 +0000)]
* Cleaned up comments
* Added mediaWiki.msg back, this time as the return a string version of mediaWiki.message
* Removed use of that variable in mediaWiki.loader, getting ready to make loader a prototyped object.
Trevor Parscal [Tue, 26 Oct 2010 23:47:09 +0000 (23:47 +0000)]
Improved comments, whitespace and simplicity.
Trevor Parscal [Tue, 26 Oct 2010 23:44:31 +0000 (23:44 +0000)]
Simplified extending of mediaWiki object
Trevor Parscal [Tue, 26 Oct 2010 23:40:26 +0000 (23:40 +0000)]
Introducing mediaWiki.language, and mediaWiki.message which are modeled after their PHP counterparts Language and wfMessage respectively.
Platonides [Tue, 26 Oct 2010 22:34:18 +0000 (22:34 +0000)]
Address my own CR in r75332.
Platonides [Tue, 26 Oct 2010 22:17:42 +0000 (22:17 +0000)]
Provide a proper implementation for passing environment variables to wfShellExec()
The quick fix of r74821 is no longer needed.
Platonides [Tue, 26 Oct 2010 21:42:49 +0000 (21:42 +0000)]
Keep maintenance/update.php php4 compatible up to the point where we can give a maeningful error. Check based in install_version_checks()
Follow up conversion to new maintenance format in r72539
Platonides [Tue, 26 Oct 2010 20:54:29 +0000 (20:54 +0000)]
Reorder to shortcut some more php_uname() calls.
Note that PHP 5.2.1 can't run on Windows 9x since it wouldn't be able to
link with the GetBinaryType() function (added in PHP r225464)
Trevor Parscal [Tue, 26 Oct 2010 20:17:32 +0000 (20:17 +0000)]
Fixes comment mistakes in r75107
Antoine Musso [Tue, 26 Oct 2010 20:16:19 +0000 (20:16 +0000)]
Follow up r75446 : use a default for --count
This also fix a division per zero error since $count was 0 and used to calculate average time.
Antoine Musso [Tue, 26 Oct 2010 20:09:58 +0000 (20:09 +0000)]
Follow up r75446 : simpler bench function, correct parenthesis.
Bryan Tong Minh [Tue, 26 Oct 2010 19:31:47 +0000 (19:31 +0000)]
Follow-up r75282
* Use addWhere instead of addWhereFld
* Don't add properties twice if there is a continue
* Add comments
Antoine Musso [Tue, 26 Oct 2010 17:21:35 +0000 (17:21 +0000)]
Follow up r75429 : benchmark for wfIsWindows();
Also implements a basic class to build new benchmarks.
Chad Horohoe [Tue, 26 Oct 2010 17:18:21 +0000 (17:18 +0000)]
Tweak UPGRADE, no longer need to move LocalSettings. Postgres caveat doesn't apply anymore
Sam Reed [Tue, 26 Oct 2010 17:12:58 +0000 (17:12 +0000)]
Followup r75431, bug 24853. Add to RELEASE-NOTES
Sam Reed [Tue, 26 Oct 2010 16:37:15 +0000 (16:37 +0000)]
Followup r75282, remove now unused class variables
Chad Horohoe [Tue, 26 Oct 2010 16:24:44 +0000 (16:24 +0000)]
Moving new-index.php to index.php. This is pretty much done and I can't see us backing this out of 1.17 at this point. The UI is still a little rough (hopefullly some work coming on that soon). mySQL, SQLite support is complete. Postgres is nearly complete, Oracle as well.
Wanted to get more feedback before we branch. Please see http://mediawiki.org/wiki/New-installer_issues for known problems and to report other things.
Chad Horohoe [Tue, 26 Oct 2010 16:24:17 +0000 (16:24 +0000)]
Make way for move
Platonides [Tue, 26 Oct 2010 15:14:56 +0000 (15:14 +0000)]
Cache the results of wfIsWindows()
Each php_uname() call produces a uname syscall.
The cached one is three times faster (3.
197545885) which is liklely to be the difference between a php var lookup and a syscall on my system.
== Test script ==
<?php
function wfIsWindows() {
if ( substr( php_uname(), 0, 7 ) == 'Windows' ) {
return true;
} else {
return false;
}
}
function wfIsWindowsCached() {
static $isWindows = null;
if ( $isWindows === null ) {
$isWindows = substr( php_uname(), 0, 7 ) == 'Windows';
}
return $isWindows;
}
$win = $nonwin = 0;
$time = microtime( true );
for ( $i = 1; $i < 5e8; $i++ ) {
if ( wfIsWindowsCached() ) {
$win++;
} else {
$nonwin++;
}
}
$time = microtime( true ) - $time;
echo "Time elapsed: $time\n";
Platonides [Tue, 26 Oct 2010 14:31:13 +0000 (14:31 +0000)]
Place into an else branch in the odd case where we are in safe_mode and passthru is additionally blocked.
Platonides [Tue, 26 Oct 2010 14:08:33 +0000 (14:08 +0000)]
Keep it in Title.php Having it on Defines would allow to use it wrong.
Follow up r75379 (r74035, r74034)
Platonides [Tue, 26 Oct 2010 14:03:27 +0000 (14:03 +0000)]
make noparser shouldn't try to run Broken tests
Platonides [Tue, 26 Oct 2010 13:56:14 +0000 (13:56 +0000)]
Marking parsertests as broken until r74646 is fixed.
Platonides [Tue, 26 Oct 2010 13:54:47 +0000 (13:54 +0000)]
Follow up r75245.
Fix PHP Fatal error: Call to a member function ucfirst() on a non-object
Raimond Spekking [Tue, 26 Oct 2010 12:51:30 +0000 (12:51 +0000)]
Revert r75415 after a talk with demon. The linebreaks are not shown in the output but Translatewiki like them to make the translation process a bit easier.
Chad Horohoe [Tue, 26 Oct 2010 12:05:57 +0000 (12:05 +0000)]
Reduce more WebInstaller bloat, move getFieldset(Start|End) to WebInstallerPage where its used
Chad Horohoe [Tue, 26 Oct 2010 12:02:23 +0000 (12:02 +0000)]
Clarify some visibilities based on actual usage
Chad Horohoe [Tue, 26 Oct 2010 11:56:18 +0000 (11:56 +0000)]
Reduce linebreaks
Chad Horohoe [Tue, 26 Oct 2010 11:55:47 +0000 (11:55 +0000)]
rm unused code
Chad Horohoe [Tue, 26 Oct 2010 11:45:21 +0000 (11:45 +0000)]
Followup r75392: reduce some duplication, eliminate bool param
Brion Vibber [Mon, 25 Oct 2010 23:49:03 +0000 (23:49 +0000)]
Followup for r75314 (bug 23923) -- regression fix for prefix of '0' being ignored since r75314
Don't forget that the string '0' evaluates to false in boolean context!
Chad Horohoe [Mon, 25 Oct 2010 23:18:47 +0000 (23:18 +0000)]
(bug 198: Easy, secure in-place upgrade) Introduce new $wgUpgradeKey. When set in LocalSettings, it allows the user to unlock the installer/upgrader with a hidden key. The days of having to move LocalSettings.php in order to perform an upgrade are gone. The key is the only thing loaded by the installer, you still have to provide the SQL information yourself (as an extra layer of sanity to keep unauthorized users from running it)
Chad Horohoe [Mon, 25 Oct 2010 21:46:35 +0000 (21:46 +0000)]
Followup r75371, use MediaWiki default user and content language for messages
Chad Horohoe [Mon, 25 Oct 2010 20:25:43 +0000 (20:25 +0000)]
Followup r74035, add GAID_FOR_UPDATE to the defines for back-compat
Raimond Spekking [Mon, 25 Oct 2010 19:51:56 +0000 (19:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-25 19:28:00 UTC)
Sam Reed [Mon, 25 Oct 2010 19:41:54 +0000 (19:41 +0000)]
failfunction is dead
Jure Kajzer [Mon, 25 Oct 2010 18:57:44 +0000 (18:57 +0000)]
* moved installMainpage to CoreInstaller as requested in r75366
Max Semenik [Mon, 25 Oct 2010 17:45:46 +0000 (17:45 +0000)]
Removed overzealous cleanup that was responsible for failures of tests in CruiseControl. Will investigate this further later, now fixing just enough to make things work.
Platonides [Mon, 25 Oct 2010 17:12:16 +0000 (17:12 +0000)]
Unused since r74966 $wgHandheldStyle is handled by the resourceloader.
Jure Kajzer [Mon, 25 Oct 2010 16:49:59 +0000 (16:49 +0000)]
* DatabaseOracle - throw connection exception instead of debug+false
* DatabaseOracle - fixed $wgContLang local usage in update
* Installer - added Main Page insertion as a new installation step (fixes bug 22308)
Antoine Musso [Mon, 25 Oct 2010 16:28:15 +0000 (16:28 +0000)]
Follow up r75361 : removing a work in progress test case
Antoine Musso [Mon, 25 Oct 2010 16:23:56 +0000 (16:23 +0000)]
* bypassers ($force, --help) moved to the top. Less error prone.
* prefix parameters with double dashes '--'
* get ride of spaces before semi-column ':'
* some comments to help us read the code
tip: reviewers should strip white spaces (svn diff -x -ub)
Platonides [Mon, 25 Oct 2010 16:06:00 +0000 (16:06 +0000)]
$wgRequest usage removed in r75272
Chad Horohoe [Mon, 25 Oct 2010 14:41:13 +0000 (14:41 +0000)]
Revert mainpage part of r75347. Should go in its own method, with messages, proper error handling, and should fix bug 22308 (trivial)
Jure Kajzer [Mon, 25 Oct 2010 12:06:37 +0000 (12:06 +0000)]
* fixed accidental revert of r75343
Jure Kajzer [Mon, 25 Oct 2010 11:07:55 +0000 (11:07 +0000)]
* Installer for Oracle fixes
* added Main Page creation within install
* added MEDIAWIKI_INSTALL constant; some scripts still use it
* started OracleUpgrader scripts for upgrade from 1.16
* fixed some not null defaults that comply with mysql data type default on not null fields
* FKs made defferable
Jure Kajzer [Mon, 25 Oct 2010 10:56:07 +0000 (10:56 +0000)]
* null value => default value handling
* duplicateTable call fix
* some internal calls to query replaced with doQuery
* added update method overload
Sam Reed [Sun, 24 Oct 2010 21:27:33 +0000 (21:27 +0000)]
(bug 24853) Kill failFunction - Fixed! :D
Sam Reed [Sun, 24 Oct 2010 21:02:57 +0000 (21:02 +0000)]
Comment out unused if (code inside it is commented out
Sam Reed [Sun, 24 Oct 2010 20:48:48 +0000 (20:48 +0000)]
Start of bug 24853, killing off 'functional' parts of failfunction code. Seems when the constructors start getting changed, it starts borking. Using this as a point of reversion/stashing
Krinkle [Sun, 24 Oct 2010 19:32:11 +0000 (19:32 +0000)]
added support for standard, cologneblue, nostalgia in mw.util.addPortletLink + updated the test suite
Raimond Spekking [Sun, 24 Oct 2010 19:30:56 +0000 (19:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-10-24 19:14:00 UTC)
Sam Reed [Sun, 24 Oct 2010 19:16:46 +0000 (19:16 +0000)]
* If a action=parse request provides an oldid that is actually the current revision id, try the parser cache, and save it to it if necessary
Priyanka Dhanda [Sun, 24 Oct 2010 18:57:25 +0000 (18:57 +0000)]
bug25289 Hook that optionally adds custom content instead of article content on diff pages. Now only used by FlaggedRevs to not load the content on history pages when pending changes are enabled.
Krinkle [Sun, 24 Oct 2010 17:52:19 +0000 (17:52 +0000)]
Moving test suit to Special:Blankpage instead
Krinkle [Sun, 24 Oct 2010 17:40:22 +0000 (17:40 +0000)]
adding debug test suit for mediaWiki.util, visible on Special:MWUtilTest?debug=true
Alexandre Emsenhuber [Sun, 24 Oct 2010 16:05:46 +0000 (16:05 +0000)]
Fix for r75313: add array_unique(), otherwise groups are listed twice if they are both in $wgGroupPermissions and $wgRevokePermissions
Bryan Tong Minh [Sun, 24 Oct 2010 15:33:00 +0000 (15:33 +0000)]
(bug 23923) Special:Prefixindex no longer shows results if nothing was requested.
I believe that this was the intention of the original code anyway, but isset was used on places where it should not have been.
Bryan Tong Minh [Sun, 24 Oct 2010 15:24:04 +0000 (15:24 +0000)]
(bug 23934) Groups defined in $wgRevokePermissions but not in $wgGroupPermissions now appear on Special:ListGroupRights
Mark A. Hershberger [Sun, 24 Oct 2010 15:12:13 +0000 (15:12 +0000)]
eol whitespace cleanup
Priyanka Dhanda [Sun, 24 Oct 2010 15:09:13 +0000 (15:09 +0000)]
Moved tests to a dub directory. Added a stub smoke test that we're going to start populating
Bryan Tong Minh [Sun, 24 Oct 2010 14:56:13 +0000 (14:56 +0000)]
Remove unnecessary @error surpressing operator. $pageSet is always defined and getGoodTitles() always returns an array
Alexandre Emsenhuber [Sun, 24 Oct 2010 07:59:01 +0000 (07:59 +0000)]
Removed trailing whitespaces
Krinkle [Sat, 23 Oct 2010 21:08:58 +0000 (21:08 +0000)]
added string trimming for older browsers
Alexandre Emsenhuber [Sat, 23 Oct 2010 21:01:54 +0000 (21:01 +0000)]
Fixed some doxygen warnings and consistency in documentation
Krinkle [Sat, 23 Oct 2010 20:12:56 +0000 (20:12 +0000)]
added mw.util.getWikilink and ported enableCheckboxShiftClick to jQuery
Bryan Tong Minh [Sat, 23 Oct 2010 18:53:39 +0000 (18:53 +0000)]
Follow-up r70638:
* Use a single query to get the page_props instead of one per page
* Removed the $wgPageProps global
* Removed a lot of useless crap
Mark A. Hershberger [Sat, 23 Oct 2010 18:07:02 +0000 (18:07 +0000)]
Use more descriptive names for the test methods.
Roan Kattouw [Sat, 23 Oct 2010 17:48:08 +0000 (17:48 +0000)]
Revert r70703 and followup r70715: broke &redirect for API edit with a fatal error
Chad Horohoe [Sat, 23 Oct 2010 17:33:37 +0000 (17:33 +0000)]
Release notes for r75272.
Mark A. Hershberger [Sat, 23 Oct 2010 17:28:39 +0000 (17:28 +0000)]
Update documentation a bit more.
Krinkle [Sat, 23 Oct 2010 17:24:07 +0000 (17:24 +0000)]
adding begin of mediaWiki.util and loading it by default + trailing whitespace cleanup in mediawiki.js
Roan Kattouw [Sat, 23 Oct 2010 17:22:38 +0000 (17:22 +0000)]
BREAKING CHANGE: Per r70640 CR, salt patrol tokens with rcid in the API too. This means patrol tokens are now different for every recentchanges entry.
Mark A. Hershberger [Sat, 23 Oct 2010 17:08:03 +0000 (17:08 +0000)]
Add examples of depends
Chad Horohoe [Sat, 23 Oct 2010 17:04:45 +0000 (17:04 +0000)]
Remove action=raw from Special:Statistics. We wanted to keep it for back-compat (see lists.wikimedia.org/pipermail/wikitech-l/2008-August/039202.html), but it's been two years since then. All of this info is available through the API with meta=siteinfo&siprop=statistics. Also a followup to r65059, finalize removal of job queue from Special:Statistics.
Markus Glaser [Sat, 23 Oct 2010 17:02:08 +0000 (17:02 +0000)]
include JUnit logger instead of requireing it
Roan Kattouw [Sat, 23 Oct 2010 16:56:07 +0000 (16:56 +0000)]
Revert r70640 per CR: don't expose unsalted edit tokens in URLs. Should instead change the API's patrol functionality to salt patrol tokens (coming up shortly)
Mark A. Hershberger [Sat, 23 Oct 2010 16:41:49 +0000 (16:41 +0000)]
Add a test for capitalization to the data provider
Bryan Tong Minh [Sat, 23 Oct 2010 16:41:20 +0000 (16:41 +0000)]
Added rvparse to parse revisions. For performance reasons if this option is used, rvlimit is enforced to 1.
Mark A. Hershberger [Sat, 23 Oct 2010 16:41:03 +0000 (16:41 +0000)]
Example data provider
Mark A. Hershberger [Sat, 23 Oct 2010 16:05:41 +0000 (16:05 +0000)]
use the install-phpunit.sh script
Mark A. Hershberger [Sat, 23 Oct 2010 16:05:02 +0000 (16:05 +0000)]
Initial check in for install script for PHPunit
Chad Horohoe [Sat, 23 Oct 2010 16:02:34 +0000 (16:02 +0000)]
Fix r63813, r64717 (session path detection in new installer). Surprise surprise, the PHP documentation doesn't match what happens in practice :p
Markus Glaser [Sat, 23 Oct 2010 15:54:27 +0000 (15:54 +0000)]
updated sample configuration with option to run against grid
Markus Glaser [Sat, 23 Oct 2010 15:52:12 +0000 (15:52 +0000)]
added settings to run tests against a selenium grid
Roan Kattouw [Sat, 23 Oct 2010 15:42:19 +0000 (15:42 +0000)]
Per r72349 CR, bring gen=js behavior back, at least for now. It'd be nasty to serve weird stuff to people still hitting gen=js with old code.
Bryan Tong Minh [Sat, 23 Oct 2010 15:40:55 +0000 (15:40 +0000)]
Added iiprop=parsedcomment to prop=imageinfo, similar to prop=revisions
Chad Horohoe [Sat, 23 Oct 2010 15:32:31 +0000 (15:32 +0000)]
Revert r73976 (Implements bug 24343 "localurl discards section id"). Per BZ feedback, this doesn't actually fix the original issue, it adds a new parser function to work around the issue.
Niklas Laxström [Sat, 23 Oct 2010 15:24:08 +0000 (15:24 +0000)]
Fix immediate issues in r72900. I'd still like more testing and perhaps requests from language communities before adding the rest.