Derick Alangi [Wed, 12 Jun 2019 19:10:25 +0000 (20:10 +0100)]
PHPDoc: Fix non-carnonical order of elements in phpdoc
Change-Id: I21330e14629b5cd085f55c1b6c6232a4a6f4afcf
Fomafix [Wed, 12 Jun 2019 18:05:55 +0000 (18:05 +0000)]
Merge "Remove unnecessary semi-colons"
jenkins-bot [Wed, 12 Jun 2019 16:28:33 +0000 (16:28 +0000)]
Merge "Fix and re-enable ApiQueryLanguageinfoTest"
jenkins-bot [Wed, 12 Jun 2019 16:18:10 +0000 (16:18 +0000)]
Merge "resourceloader: Convert test for FileModule versionHash to data provider"
jenkins-bot [Wed, 12 Jun 2019 15:44:39 +0000 (15:44 +0000)]
Merge "Set min-width on rcfilter dropdown"
Lucas Werkmeister [Fri, 7 Jun 2019 13:25:14 +0000 (15:25 +0200)]
Fix and re-enable ApiQueryLanguageinfoTest
Anomie discovered (T225244#
5250241) that we need to clear the language
cache here; with that, the test should work again, so re-enable it.
Bug: T225244
Change-Id: I67e8446a4ff64d12ab3a3a52a432a728d4139a69
Jan Drewniak [Wed, 12 Jun 2019 11:02:12 +0000 (13:02 +0200)]
Removes updateIfHeightChanged override on rcfilters
This override causes the rcfilter dropdown menu to be incorrectly
positioned when the height of the "tag box" changes,
i.e. when a tag is added and an additional row is created.
This override was originally added as part of T198399 in commit
a9fc286, but given
bb15314 prevents the resize event from firing on
pageload, that change should mitigate the performance impact of
this function.
Bug: T225499
Change-Id: I4a296c7d3c277d5415144aee6434b63a5035d275
Timo Tijhof [Wed, 12 Jun 2019 14:05:09 +0000 (15:05 +0100)]
resourceloader: Convert test for FileModule versionHash to data provider
In prep for the next commit.
Change-Id: If08c3d8b769b6ec03faf8ff24f216ce9f670f6ac
Derick Alangi [Wed, 12 Jun 2019 13:35:59 +0000 (14:35 +0100)]
Remove unnecessary semi-colons
Change-Id: I9eb65bdfbd3aa581effc14ead801b9e89b0359c3
Jan Drewniak [Wed, 12 Jun 2019 10:46:32 +0000 (12:46 +0200)]
Set min-width on rcfilter dropdown
Setting a min-width on the body of the rcfilter dropdown menu
prevents it from dropping to width=0 when the browser is
narrower than 650px.
Bug: T225499
Change-Id: I8e7281994af45a52b994fe277fc513db2ae2c4d6
jenkins-bot [Tue, 11 Jun 2019 23:11:58 +0000 (23:11 +0000)]
Merge "ResourceLoaderOOUIIconPackModule: Always use MW core 'localBasePath'"
Bartosz Dziewoński [Tue, 11 Jun 2019 22:50:02 +0000 (00:50 +0200)]
ResourceLoaderOOUIIconPackModule: Always use MW core 'localBasePath'
Otherwise, extensions defining icon pack modules in extension.json
would need to specify "localBasePath": "../..", which is silly.
Follow-up to
a8dae2212cc5e23e181023af2ba1891078b14355.
Change-Id: If8f02867955d649c809b6b41de0f77e594b633d6
Gergő Tisza [Sat, 2 Mar 2019 03:06:54 +0000 (19:06 -0800)]
Exempt structure tests from @covers checks
@covers does not make any sense for structure tests, which either
do not cover any PHP lines (they test things like configuration or
messages), or cover lines which cannot be determined at the time
of writing the tests (e.g. they cover all classes implementing a
certain interface). Requiring @coversNothing to be manually added
for all of them is a waste of developer time.
tests/phpunit/suite.xml has forceCoversAnnotation=true so removing
the annotations will not change test coverage, these files will
still be skipped.
Change-Id: I27cb58e92341b9b1a76f109701f5bc843adbaa9b
jenkins-bot [Tue, 11 Jun 2019 20:55:44 +0000 (20:55 +0000)]
Merge "Inline trivial object creation helpers in tests"
jenkins-bot [Tue, 11 Jun 2019 20:22:38 +0000 (20:22 +0000)]
Merge "jquery.suggestions: Load initial suggestions only when focused"
jenkins-bot [Tue, 11 Jun 2019 19:51:21 +0000 (19:51 +0000)]
Merge "Installer: Update link to PHP intl away from old PECL package"
Karsten Hoffmeyer [Tue, 11 Jun 2019 19:24:16 +0000 (21:24 +0200)]
Installer: Update link to PHP intl away from old PECL package
PHP 5.5 was the last version supported by PECL intl package. Now the
PHP intl extension is used instead.
Bug: T225558
Change-Id: I68cb7a549c899e69da9a8cfea5a69b9acb41e8ae
Derick Alangi [Sat, 18 May 2019 13:13:46 +0000 (14:13 +0100)]
maintenance: Use addDescription() instead of accessing mDescription directly
Change-Id: I705a3fab4a6b151b81b45a3e2d7559f554986378
Bartosz Dziewoński [Mon, 12 Feb 2018 19:41:44 +0000 (20:41 +0100)]
Allow loading styles for arbitrary OOUI icon packs
You can now create ResourceLoader modules for arbitrary sets of OOUI
icons. This is an alternative to I8af783666a2b23a938af93c1b56fee619219eaf5.
Update dependencies of OOUI's modules to use custom icon packs instead
of default icon packs.
Bug: T160690
Change-Id: Icf9560da79c91e56c7a3f4c0de01dd057f5aa00d
jenkins-bot [Tue, 11 Jun 2019 17:42:57 +0000 (17:42 +0000)]
Merge "resources: Remove unused jquery.effects.* modules"
jenkins-bot [Tue, 11 Jun 2019 15:58:09 +0000 (15:58 +0000)]
Merge "Normalize dir path in AutoLoaderStructureTest"
jenkins-bot [Tue, 11 Jun 2019 15:16:00 +0000 (15:16 +0000)]
Merge "Move cookie-blocking methods to BlockManager"
Derick Alangi [Fri, 19 Apr 2019 18:25:14 +0000 (19:25 +0100)]
resources: Remove unused jquery.effects.* modules
* jquery.ui.effect-bounce [removed]
* jquery.ui.effect-explode [removed]
* jquery.ui.effect-fold [removed]
* jquery.ui.effect-pulsate [removed]
* jquery.ui.effect-slide [removed]
* jquery.ui.effect-transfer [removed]
Bug: T219604
Change-Id: I9a9acd8ed3d4a3b6c50f57fbb11e6038713a2a09
jenkins-bot [Tue, 11 Jun 2019 14:39:55 +0000 (14:39 +0000)]
Merge "Have ServiceContainer implement PSR-11"
jenkins-bot [Tue, 11 Jun 2019 14:23:24 +0000 (14:23 +0000)]
Merge "Replace some uses of deprecated wfFindFile() and wfLocalFile()"
jenkins-bot [Tue, 11 Jun 2019 14:20:09 +0000 (14:20 +0000)]
Merge "Fix return type of File::restore()"
Thalia [Thu, 6 Jun 2019 18:00:20 +0000 (14:00 -0400)]
Move cookie-blocking methods to BlockManager
Move the cookie blocking logic into one place. Specifically, move
these methods to the BlockManager:
* User::trackBlockWithCookie
* DatabaseBlock::setCookie
* DatabaseBlock::clearCookie
* DatabaseBlock::getCookieValue
* DatabaseBlock::getIdFromCookieValue
* AbstractBlock::shouldTrackWithCookie
After this, BlockManager::trackBlockWithCookie should be called to
track a block, and BlockManager::clearBlockCookie should be called
to unset the cookie. The other methods in the above list are
helper methods that are made private or marked internal.
Also update places in core that call User::trackBlockWithCookie to
BlockManager::trackBlockWithCookie
Bug: T225141
Change-Id: I818962c6932c01c841a549a101637e00a7593e48
jenkins-bot [Tue, 11 Jun 2019 13:53:05 +0000 (13:53 +0000)]
Merge "Set cache types to APC/APCu/WinCache in DevelopmentSettings.php"
Derick Alangi [Tue, 14 May 2019 17:00:34 +0000 (18:00 +0100)]
Replace some uses of deprecated wfFindFile() and wfLocalFile()
These global functions were deprecated in 1.34 and services made
available to replace them. See services below;
* wfFindFile() - MediaWikiServices::getInstance()->getRepoGroup()->findFile()
* wfLocalFind() - MediaWikiServices::getInstance()->getRepoGroup()->getLocalRepo()->newFile()
NOTES:
* wfFindFile() and wfLocalFind() usages in tests have been ignored
in this change per @Timo's comments about state of objects.
* includes/upload/UploadBase.php also maintained for now as it causes
some failures I don't fully understand, will investigate and handle
it in a follow up patch.
* Also, includes/MovePage.php
Change-Id: I9437494de003f40fbe591321da7b42d16bb732d6
Lucas Werkmeister [Tue, 11 Jun 2019 12:35:23 +0000 (14:35 +0200)]
Fix return type of File::restore()
The only real implementation, LocalFile::restore(), has not returned an
int|bool since commit
ca76169bbe, almost twelve years ago. (MediaWiki
code search [1] finds no other implementations.)
This discrepancy became more visible when we moved from wfLocalFile() to
FileRepo::findFile(), because wfLocalFile() (incorrectly, as it just
calls FileRepo::findFile()) is declared to return a LocalFile, rather
than any File as FileRepo::findFile() does, so the incorrect return type
on File::returnType() was not seen by wfLocalFile() users.
[1]: https://codesearch.wmflabs.org/search/?q=function%20restore\(&files=\.php%24
Change-Id: Idaf73074eaddc5be1782ae484d75a0f0c129b980
jenkins-bot [Tue, 11 Jun 2019 11:54:07 +0000 (11:54 +0000)]
Merge "Remove return value from SpecialUploadStash::execute"
jenkins-bot [Tue, 11 Jun 2019 11:53:59 +0000 (11:53 +0000)]
Merge "api: Temporarily disable ApiQueryLanguageinfoTest"
Amir Sarabadani [Tue, 11 Jun 2019 11:21:54 +0000 (13:21 +0200)]
Set cache types to APC/APCu/WinCache in DevelopmentSettings.php
Bug: T225496
Change-Id: I14dd3fea9795a501e29383a3cae2b3e9a0077e69
jenkins-bot [Tue, 11 Jun 2019 00:28:34 +0000 (00:28 +0000)]
Merge "Allow MediaWikiTestCase::editPage to use given User"
jenkins-bot [Mon, 10 Jun 2019 23:57:23 +0000 (23:57 +0000)]
Merge "build: Upgrade stylelint-config-wikimedia from 0.5.0 to 0.6.0 and make pass"
jenkins-bot [Mon, 10 Jun 2019 23:50:22 +0000 (23:50 +0000)]
Merge "jquery.suggestions: Combine two isRTL checks"
jenkins-bot [Mon, 10 Jun 2019 23:44:07 +0000 (23:44 +0000)]
Merge "resourceloader: Add explicit tests for isValidModuleName()"
jenkins-bot [Mon, 10 Jun 2019 23:43:21 +0000 (23:43 +0000)]
Merge "resourceloader: Warn on ResourceLoader::construct without Config"
James D. Forrester [Mon, 3 Jun 2019 21:04:54 +0000 (14:04 -0700)]
build: Upgrade stylelint-config-wikimedia from 0.5.0 to 0.6.0 and make pass
Change-Id: I062bed7889cdfcc48eab9594200fc1d4767dda8c
jenkins-bot [Mon, 10 Jun 2019 21:40:46 +0000 (21:40 +0000)]
Merge "build: Commit package-lock.json"
jenkins-bot [Mon, 10 Jun 2019 21:28:20 +0000 (21:28 +0000)]
Merge "mediawiki.Title: Remove dead code and streamline newFromUserInput()"
James D. Forrester [Mon, 10 Jun 2019 21:24:21 +0000 (14:24 -0700)]
build: Commit package-lock.json
First step towards making our developers less vulnerable to
credential-stealing attacks through the npm registry.
Per T211784 and
5a300c77c302, mediawiki-core now uses Node 10
for at least one of the jobs that runs 'npm install'.
Change-Id: Ia4c59d3fc18ce0e13a4e5c3a00804e54dcb015a3
jenkins-bot [Mon, 10 Jun 2019 21:23:33 +0000 (21:23 +0000)]
Merge "foreign-resources.yaml: Add jquery.chosen"
jenkins-bot [Mon, 10 Jun 2019 20:27:02 +0000 (20:27 +0000)]
Merge "watcheditem: Do not create the same TitleValue object twice"
jenkins-bot [Mon, 10 Jun 2019 20:19:28 +0000 (20:19 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Mon, 10 Jun 2019 20:18:53 +0000 (20:18 +0000)]
Merge "Fix documentation of Maintenance::updateSearchIndex"
Translation updater bot [Mon, 10 Jun 2019 20:18:44 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I695bfdbedde246b905e0fb7573a4070ffb0e4f78
Umherirrender [Fri, 7 Jun 2019 14:28:31 +0000 (16:28 +0200)]
watcheditem: Do not create the same TitleValue object twice
Minor optimization in getWatchedItemsForUser(). Follows-up
7c12727fff0.
Change-Id: I29f40f2c09c334eea33c7aaf351e1f1a93de9c13
jenkins-bot [Mon, 10 Jun 2019 19:59:10 +0000 (19:59 +0000)]
Merge "Remove RELEASE-NOTES-1.33"
MusikAnimal [Mon, 3 Jun 2019 19:52:46 +0000 (15:52 -0400)]
Allow MediaWikiTestCase::editPage to use given User
Sometimes you need to edit pages with a non-sysop.
This is a follow-up to I9e48f7c00efbce8c2de3f5db3a74462d47ae8f64
Change-Id: I5a101638f57709c343a2e42ca0ae11527bee8cce
Kunal Mehta [Thu, 6 Jun 2019 01:12:45 +0000 (21:12 -0400)]
Have ServiceContainer implement PSR-11
Bug: T222410
Change-Id: Ifab2602972ba385a975a0d8279605d2c4802ca9f
Depends-On: I5629e287208b2f038753d88d328989ebdc934c0f
Timo Tijhof [Mon, 10 Jun 2019 15:00:16 +0000 (16:00 +0100)]
resourceloader: Warn on ResourceLoader::construct without Config
The only remaining use of 'new ResourceLoader' is in tests, which have
been migrated in this commit to either passing the real config explicitly
(for integration tests), or by passing a HashConfig from a new
'getMinimalConfig' method which has only the keys required for the tests
to pass (e.g. avoid any ConfigExeption for unknown keys).
Also clean up some related code quality issues:
* Migrate wfScript() to $conf->get() so that the local Config is used,
instead of implicitly using global variables. This isn't deprecated for
MediaWiki generally, but done here to prepare ResourceLoader for becoming
a standalone library.
* Remove mocking of 'CacheEpoch' config, this is no longer used anywhere
in ResourceLoader.
* Change EmptyResourceLoader to use the minimal config by default and
remove code duplication by calling the parent.
Update the small number of uses that are integration tests, to explicitly
pass in the live config as needed. And for the one case that tests the
'startup' module, it no longer needs to register it manually given this
is part of ResourceLoader::__construct() by default.
Bug: T32956
Change-Id: I127346fd530fa66f205156e545758b1c29d0fac0
Adam Wight [Thu, 6 Jun 2019 10:55:32 +0000 (12:55 +0200)]
selenium: Skip flaky Rollback test
Sometimes the element doesn't appear. This is breaking during gate-and-submit,
so skipping until it can be fixed properly.
Bug: T219440
Change-Id: I7286eb5499e34146acf5da3180b665436569a18c
Timo Tijhof [Mon, 10 Jun 2019 15:13:19 +0000 (16:13 +0100)]
api: Temporarily disable ApiQueryLanguageinfoTest
Bug: T225244
Change-Id: I0f778f1b4f8bd53bd8d52540afbe6927a14b583a
jenkins-bot [Mon, 10 Jun 2019 15:00:12 +0000 (15:00 +0000)]
Merge "resourceloader: Add coverage for DerivativeRLContext::getDirection inheritance"
Timo Tijhof [Mon, 10 Jun 2019 14:25:24 +0000 (15:25 +0100)]
resourceloader: Add coverage for DerivativeRLContext::getDirection inheritance
This was the only case not covered, possibly due to a copy-paste
mistake when writing the test.
Change-Id: I1d01a1191da15162f301cea4082c0f1f481cece7
Derick Alangi [Sun, 26 May 2019 21:46:15 +0000 (22:46 +0100)]
Use AtEase::quietCall() instead of Wikimedia\quietCall()
Wikimedia\quietCall() is deprecated and AtEase is here for use.
I would have loved to do restoreWarnings() and suppressWarnings()
in this same patch set but will continue the work for a later patch.
Bug: T182273
Change-Id: I43e3a5f378c99b5c40883b35ba133cbd126fc433
Fomafix [Wed, 5 Jun 2019 20:08:48 +0000 (22:08 +0200)]
jquery.suggestions: Combine two isRTL checks
Also update comment about the direction.
Change-Id: Iba9e925eef3148c2964d51cf5e55402dc85d65dc
jenkins-bot [Mon, 10 Jun 2019 13:48:27 +0000 (13:48 +0000)]
Merge "tidy: Remove unused var and define $parts var to avoid undefined error"
jenkins-bot [Mon, 10 Jun 2019 13:44:50 +0000 (13:44 +0000)]
Merge "jquery.suggestions: Use document.documentElement.clientWidth"
Fomafix [Wed, 5 Jun 2019 06:01:36 +0000 (08:01 +0200)]
jquery.suggestions: Load initial suggestions only when focused
Firefox restores the value of the search field on browser history back
on some special pages with OOUI search suggestions. In this case the
value of the search field gets also changed before JavaScript gets
initialized and the search suggestions get loaded.
This change loads the initial suggestions only when the search field is
focused and the value is changed before initializing JavaScript.
Bug: T224952
Change-Id: I30d334ae61b40666f14c2b6f82fe7f66ebc8fba0
jenkins-bot [Mon, 10 Jun 2019 13:41:20 +0000 (13:41 +0000)]
Merge "jquery.suggestions: Use Object.create( null )"
jenkins-bot [Mon, 10 Jun 2019 13:40:09 +0000 (13:40 +0000)]
Merge "jquery.suggestions: Remove public object $.suggestions"
Derick Alangi [Mon, 15 Apr 2019 16:07:31 +0000 (17:07 +0100)]
tidy: Remove unused var and define $parts var to avoid undefined error
Remove unused variable $parent in RemexCompatMunger::comment(). Also,
RemexMungerData::dump() could have a possibility that all checks fail
and $parts is not defined. There are two ways we can handle this, i.e.
either by doing `$parts = []`(setting $parts to an empty array) or by
safe guarding using an `isset()` check.
This patch uses the former so that $parts is defined and can be used
below in the code.
Change-Id: I4d601a6fe36a1dce0945686cb9880336d08338be
Fomafix [Wed, 29 May 2019 22:56:46 +0000 (00:56 +0200)]
jquery.suggestions: Use Object.create( null )
Object.create( null ) creates an Object without predefined methods like
hasOwnProperty or constructor. This allow to use
key in object
instead of
Object.prototype.hasOwnProperty.call( object, key )
even if the key is 'constructor'.
Change-Id: I6ef9019309022a2a990deda685ba71ca61b86df3
jenkins-bot [Mon, 10 Jun 2019 05:49:20 +0000 (05:49 +0000)]
Merge "Drop SpecialPage::getTitle()"
jenkins-bot [Sun, 9 Jun 2019 20:13:23 +0000 (20:13 +0000)]
Merge "registration: Deprecate ParserTestFiles in extension.json"
jenkins-bot [Sun, 9 Jun 2019 17:33:40 +0000 (17:33 +0000)]
Merge "objectcache: Make BagOStuff::getCurrentTime() public"
Lucas Werkmeister [Sat, 8 Jun 2019 16:30:20 +0000 (18:30 +0200)]
objectcache: Make BagOStuff::getCurrentTime() public
If another cache wraps a BagOStuff, it may need to know about the
BagOStuff’s notion of the current time, which may be mocked and differ
from the real time.
Change-Id: I40f4085d4cf549314394d3140cccb1fe4e48690a
jenkins-bot [Sun, 9 Jun 2019 16:54:59 +0000 (16:54 +0000)]
Merge "build: Set opcache.enable_cli=1 for Travis CI builds"
RazeSoldier [Thu, 6 Jun 2019 08:57:51 +0000 (08:57 +0000)]
build: Set opcache.enable_cli=1 for Travis CI builds
Make test process faster. The code refer <https://docs.travis-ci.com/user/languages/php/>.
Bug: T225078
Change-Id: I8c4e87f75108cfbece17506aa630b205aabaab4b
jenkins-bot [Sun, 9 Jun 2019 12:38:45 +0000 (12:38 +0000)]
Merge "Adjust type hints in database related classes"
jenkins-bot [Sun, 9 Jun 2019 12:16:37 +0000 (12:16 +0000)]
Merge "Use IResultWrapper in LinkBatch and BacklinkCache"
RazeSoldier [Sun, 9 Jun 2019 04:40:01 +0000 (04:40 +0000)]
Drop SpecialPage::getTitle()
Bug: T220656
Change-Id: I85935901a2101f8e5fa5211e54c26f31f9ff0aa1
jenkins-bot [Sat, 8 Jun 2019 22:41:47 +0000 (22:41 +0000)]
Merge "Print: Add padding on pre elements"
Translation updater bot [Sat, 8 Jun 2019 20:09:28 +0000 (22:09 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic243e28c02a6f791d269278c08a4deee105721c2
Derk-Jan Hartman [Sat, 8 Jun 2019 20:04:10 +0000 (22:04 +0200)]
Print: Add padding on pre elements
This is inline with their non-print styling and avoids the border and
the glyph being so close that it affects readability.
Bug: T225188
Change-Id: I0dcf09742483e28535d1d48641ccfba359e9f377
jenkins-bot [Sat, 8 Jun 2019 19:02:23 +0000 (19:02 +0000)]
Merge "Deprecate logout token on GET"
Reedy [Sat, 8 Jun 2019 12:22:12 +0000 (13:22 +0100)]
Remove RELEASE-NOTES-1.33
1.33.0-rc.0 is out, so probably not any more features being backported
It's already divered from the one in the REL1_33 branch, so has
little benefit staying in master
Change-Id: I21fa200e1c817099afa83062a357014b5481a18e
Fomafix [Wed, 5 Jun 2019 19:33:41 +0000 (21:33 +0200)]
jquery.suggestions: Use document.documentElement.clientWidth
On skins with a border and/or a margin on the <body> or the <html>
element the width of <body> is smaller than the width of the window.
Also use .appendTo( document.body ) instead of .appendTo( $( 'body' ) ).
Bug: T47668
Change-Id: I209eb6e3b95ba0fc6e7c5084242a90ca04c9e196
jenkins-bot [Sat, 8 Jun 2019 08:28:30 +0000 (08:28 +0000)]
Merge "Pass options as array to IDatabase::insert"
jenkins-bot [Fri, 7 Jun 2019 21:53:31 +0000 (21:53 +0000)]
Merge "Relax HTML sniffing checks on image upload"
Brion Vibber [Thu, 6 Jun 2019 21:54:29 +0000 (14:54 -0700)]
Relax HTML sniffing checks on image upload
Allows uploaded files to include some HTML tag strings that were
previously forbidden in the first 1k or so of the file:
* <a href
* <img
* <pre
* <table
* <title
They are now allowed as long as the IE MIME type detection heuristic
would not change their types. This should reduce the number of false
positive checks in JPEGs with EXIF data with links.
Also deprecates $wgAllowTitlesInSVG and allows it by default.
This should still protect against malformed PNG attacks on old IE
versions, though false positive checks are conceivable on PNG files
containing comments very close to the beginning of the file.
Adds $wgVerifyMimeTypeIE config var to allow disabling the IE checks
entirely, if desired, but leaves it in place by default. These are
more conservative than the checks that were removed.
Added test cases for the old IE5/6 bug and the particular sort of
JPEG metadata that struck false positives previously.
Bug: T27707
Change-Id: I66642a74fce1a1894cad67d62b0da61020db469a
Brad Jorsch [Fri, 24 May 2019 13:19:49 +0000 (09:19 -0400)]
API: Apply miser-mode namespace check for generator=redirects
Bug: T224246
Change-Id: Icad65fcc14ad91d302c8285e08d6a7ea299a90c6
Umherirrender [Fri, 7 Jun 2019 17:22:19 +0000 (19:22 +0200)]
Fix documentation of Maintenance::updateSearchIndex
Document callback as callable type and the results part as
IResultWrapper to match the implementation, which is passing return of
Database::query to this function
Change-Id: I63ee8d4907590a21ef34d0b761b8fabfe0ff2569
Umherirrender [Fri, 7 Jun 2019 17:12:35 +0000 (19:12 +0200)]
Pass options as array to IDatabase::insert
The documentation only allows arrays there
Change-Id: I00c6e47a817a70bed9a443aebc675ef4c3d6b1e5
Umherirrender [Fri, 7 Jun 2019 15:19:48 +0000 (17:19 +0200)]
Change array type on ApiQueryBase::addTables
This function results in passing its value to IDatabase::select as first
parameter $table.
The first parameter is documented as string|array, because it can take
more complex arrays:
* Joins using parentheses for grouping (since MediaWiki 1.31) may be
* constructed using nested arrays. For example,
*
* [ 'tableA', 'nestedB' => [ 'tableB', 'b2' => 'tableB2' ] ]
Update the type to allow also passing such complex arrays to this
function
ApiQueryBase::showHiddenUsersAddBlockInfo() is using this format
Change-Id: I8038243545bc1c79a1106ccc3bec7738e63c2e2e
Umherirrender [Mon, 3 Jun 2019 19:14:13 +0000 (21:14 +0200)]
Remove return value from SpecialUploadStash::execute
SpecialPage::execute never returns anything
Also remove the return value from the functions called here.
The special page is using exceptions instead of a bool to indicate
failure and success
Change-Id: Ia271fe06b8ce888a8448099020f7aedf23af30db
Lucas Werkmeister [Mon, 20 May 2019 15:09:37 +0000 (17:09 +0200)]
Normalize dir path in AutoLoaderStructureTest
The file paths we inspect are always normalized (File_Iterator_Facade
applies realpath()), but the directory we compare against may not be,
depending on how wfLoadExtension() was called. Normalize the directory
before we remove the directory prefix from each file, so that we don’t
end up stripping away the wrong parts of the path.
Change-Id: Ib272fb892c18d989f8d439ed50c6a5a8fd542cc9
jenkins-bot [Fri, 7 Jun 2019 08:11:27 +0000 (08:11 +0000)]
Merge "Add missing Title::newFromLinkTarget to api module compare"
jenkins-bot [Fri, 7 Jun 2019 08:05:54 +0000 (08:05 +0000)]
Merge "Fix ServiceOptions type in constructor documentation"
jenkins-bot [Fri, 7 Jun 2019 08:05:03 +0000 (08:05 +0000)]
Merge "WatchedItemStore::getWatchedItem returns a WatchedItem"
Reedy [Fri, 7 Jun 2019 01:31:44 +0000 (02:31 +0100)]
Add 1.27.7 to HISTORY
Change-Id: If41890454e3487b6b7803a1671915041c53f9561
Reedy [Fri, 7 Jun 2019 00:08:20 +0000 (01:08 +0100)]
Bring in HISTORY for 1.27.6/1.30.2/1.31.2/1.32.2
Bug: T205046
Change-Id: Ib4819bf71c22873a4b16c55b7e22d0f33aa07148
Thalia [Thu, 6 Jun 2019 21:29:02 +0000 (17:29 -0400)]
Fix spelling error in test function name
Change-Id: Ib9b83f6936a3ba86dbb7537d9cef7810c8bc36db
jenkins-bot [Thu, 6 Jun 2019 20:37:15 +0000 (20:37 +0000)]
Merge "SECURITY: resources: Patch jQuery 3.3.1 for CVE-2019-11358"
jenkins-bot [Thu, 6 Jun 2019 20:37:09 +0000 (20:37 +0000)]
Merge "SECURITY: Add permission check for user is permitted to view the log type"
jenkins-bot [Thu, 6 Jun 2019 20:36:18 +0000 (20:36 +0000)]
Merge "SECURITY: Add permission check for user is permitted to view the log type"
Translation updater bot [Thu, 6 Jun 2019 20:14:43 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I33e9fe577fee1d6203e2f91d143c25b1d2291bd5
Umherirrender [Thu, 6 Jun 2019 20:10:57 +0000 (22:10 +0200)]
Add missing Title::newFromLinkTarget to api module compare
The function getArticleID is not implemented by a LinkTarget as returned
by getPageAsLinkTarget, so this needs a wrapper to create a Title
object.
ApiQueryBase::addTitleInfo also needs a Title object to call
getPrefixedText
Change-Id: I8d1b4a77da8b3ce4eaf9e7e5100a3243669f2d3e