From: Moriel Schottlender <moriel@gmail.com>
Date: Wed, 28 Feb 2018 01:12:01 +0000 (-0800)
Subject: RCFilters: Actually apply the $autoCloseIgnore to the overlay
X-Git-Tag: 1.31.0-rc.0~494^2
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/modifier.php?a=commitdiff_plain;h=7339f798d037c49664569449472a97d49f12bf1e;p=lhc%2Fweb%2Fwiklou.git

RCFilters: Actually apply the $autoCloseIgnore to the overlay

The way we extended the configuration meant we overrided the
overlay $autoCloseIgnore with default rather than override the
default with the overlay.

Bug: T188459
Change-Id: If20bd400a8a206aa77c25c390d9e9ce5111b68cb
---

diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
index cbb4350357..d968f0c486 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
@@ -38,12 +38,12 @@
 		this.footers = [];
 
 		// Parent
-		mw.rcfilters.ui.MenuSelectWidget.parent.call( this, $.extend( {
+		mw.rcfilters.ui.MenuSelectWidget.parent.call( this, $.extend( config, {
 			$autoCloseIgnore: this.$overlay,
 			width: 650,
 			// Our filtering is done through the model
 			filterFromInput: false
-		}, config ) );
+		} ) );
 		this.setGroupElement(
 			$( '<div>' )
 				.addClass( 'mw-rcfilters-ui-menuSelectWidget-group' )