From: jrobson Date: Fri, 4 Apr 2014 00:58:56 +0000 (-0700) Subject: Vector: Simply style external links X-Git-Tag: 1.31.0-rc.0~16364 X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/modifier.php?a=commitdiff_plain;h=63c149370497045ae6ac3154c3e0c2304fe202d3;p=lhc%2Fweb%2Fwiklou.git Vector: Simply style external links These external link icons are extremely costly with little gain. During the typography experiment, these were removed, no one raised this as an issue during the 5 months it was live, suggesting that explicit pdf icons etc are not as useful as we like to believe. As a result of these findings posting this patch upstream. Bug: 54604 Change-Id: If985b16c4f682d737683597ed80951c6d6644c8f --- diff --git a/skins/vector/components/externalLinks.less b/skins/vector/components/externalLinks.less index 3e26a223c6..60792d580e 100644 --- a/skins/vector/components/externalLinks.less +++ b/skins/vector/components/externalLinks.less @@ -1,75 +1,9 @@ // FIXME: This size of this CSS is ridiculous. Please refactor (see bug 54604) @import "mediawiki.mixins.less"; - -div#content a.external { +// External links +.external { background-position: center right; background-repeat: no-repeat; - .background-image-svg('images/external-link-ltr-icon.svg', 'images/external-link-ltr-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="https://"], -.link-https { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/lock-icon.svg', 'images/lock-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="mailto:"], -.link-mailto { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/mail-icon.svg', 'images/mail-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="news:"] { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/news-icon.svg', 'images/news-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="ftp://"], -.link-ftp { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/file-icon.svg', 'images/file-icon.png'); - padding-right: 13px; -} -div#content a.external[href ^="irc://"], -div#content a.external[href ^="ircs://"], -.link-irc { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/talk-icon.svg', 'images/talk-icon.png'); - padding-right: 13px; -} -div#content a.external[href $=".ogg"], div#content a.external[href $=".OGG"], -div#content a.external[href $=".mid"], div#content a.external[href $=".MID"], -div#content a.external[href $=".midi"], div#content a.external[href $=".MIDI"], -div#content a.external[href $=".mp3"], div#content a.external[href $=".MP3"], -div#content a.external[href $=".wav"], div#content a.external[href $=".WAV"], -div#content a.external[href $=".wma"], div#content a.external[href $=".WMA"], -.link-audio { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/audio-icon.svg', 'images/audio-icon.png'); - padding-right: 13px; -} -div#content a.external[href $=".ogm"], div#content a.external[href $=".OGM"], -div#content a.external[href $=".avi"], div#content a.external[href $=".AVI"], -div#content a.external[href $=".mpeg"], div#content a.external[href $=".MPEG"], -div#content a.external[href $=".mpg"], div#content a.external[href $=".MPG"], -.link-video { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/video-icon.svg', 'images/video-icon.png'); - padding-right: 13px; -} -div#content a.external[href $=".pdf"], div#content a.external[href $=".PDF"], -div#content a.external[href *=".pdf#"], div#content a.external[href *=".PDF#"], -div#content a.external[href *=".pdf?"], div#content a.external[href *=".PDF?"], -.link-document { - background-position: center right; - background-repeat: no-repeat; - .background-image-svg('images/document-icon.svg', 'images/document-icon.png'); + .background-image-svg('images/external-link-ltr-icon.svg', 'images/external-link-ltr-icon.png' ); padding-right: 13px; } diff --git a/skins/vector/images/audio-icon.png b/skins/vector/images/audio-icon.png deleted file mode 100644 index 5a1d2f4325..0000000000 Binary files a/skins/vector/images/audio-icon.png and /dev/null differ diff --git a/skins/vector/images/audio-icon.svg b/skins/vector/images/audio-icon.svg deleted file mode 100644 index 91ca5c484d..0000000000 --- a/skins/vector/images/audio-icon.svg +++ /dev/null @@ -1,56 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - diff --git a/skins/vector/images/document-icon.png b/skins/vector/images/document-icon.png deleted file mode 100644 index 4d56572b70..0000000000 Binary files a/skins/vector/images/document-icon.png and /dev/null differ diff --git a/skins/vector/images/document-icon.svg b/skins/vector/images/document-icon.svg deleted file mode 100644 index fd05df80cf..0000000000 --- a/skins/vector/images/document-icon.svg +++ /dev/null @@ -1,69 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - diff --git a/skins/vector/images/file-icon.png b/skins/vector/images/file-icon.png deleted file mode 100644 index ed24669868..0000000000 Binary files a/skins/vector/images/file-icon.png and /dev/null differ diff --git a/skins/vector/images/file-icon.svg b/skins/vector/images/file-icon.svg deleted file mode 100644 index 98d9041da7..0000000000 --- a/skins/vector/images/file-icon.svg +++ /dev/null @@ -1,72 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - diff --git a/skins/vector/images/lock-icon.png b/skins/vector/images/lock-icon.png deleted file mode 100644 index a9ba8a7217..0000000000 Binary files a/skins/vector/images/lock-icon.png and /dev/null differ diff --git a/skins/vector/images/lock-icon.svg b/skins/vector/images/lock-icon.svg deleted file mode 100644 index bad5daf0ce..0000000000 --- a/skins/vector/images/lock-icon.svg +++ /dev/null @@ -1,73 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - diff --git a/skins/vector/images/mail-icon.png b/skins/vector/images/mail-icon.png deleted file mode 100644 index 0d93a2f839..0000000000 Binary files a/skins/vector/images/mail-icon.png and /dev/null differ diff --git a/skins/vector/images/mail-icon.svg b/skins/vector/images/mail-icon.svg deleted file mode 100644 index cab6304086..0000000000 --- a/skins/vector/images/mail-icon.svg +++ /dev/null @@ -1,69 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - diff --git a/skins/vector/images/news-icon.png b/skins/vector/images/news-icon.png deleted file mode 100644 index 6f27054be7..0000000000 Binary files a/skins/vector/images/news-icon.png and /dev/null differ diff --git a/skins/vector/images/news-icon.svg b/skins/vector/images/news-icon.svg deleted file mode 100644 index e5514a7ddb..0000000000 --- a/skins/vector/images/news-icon.svg +++ /dev/null @@ -1,67 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - diff --git a/skins/vector/images/talk-icon.png b/skins/vector/images/talk-icon.png deleted file mode 100644 index 0332054ee1..0000000000 Binary files a/skins/vector/images/talk-icon.png and /dev/null differ diff --git a/skins/vector/images/talk-icon.svg b/skins/vector/images/talk-icon.svg deleted file mode 100644 index d65d57a52d..0000000000 --- a/skins/vector/images/talk-icon.svg +++ /dev/null @@ -1,66 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - diff --git a/skins/vector/images/video-icon.png b/skins/vector/images/video-icon.png deleted file mode 100644 index ed852322a9..0000000000 Binary files a/skins/vector/images/video-icon.png and /dev/null differ diff --git a/skins/vector/images/video-icon.svg b/skins/vector/images/video-icon.svg deleted file mode 100644 index 0b3d3022e1..0000000000 --- a/skins/vector/images/video-icon.svg +++ /dev/null @@ -1,90 +0,0 @@ - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - - - - -