From: kaldari <rkaldari@wikimedia.org>
Date: Fri, 14 Nov 2014 18:34:50 +0000 (-0800)
Subject: Keep buttons from changing size when they change state
X-Git-Tag: 1.31.0-rc.0~13277^2
X-Git-Url: https://git.cyclocoop.org/%7B%24admin_url%7Dmembres/modifier.php?a=commitdiff_plain;h=2fc4fd0865b0e1ce6001f8d01f13a8b7d2c75c63;p=lhc%2Fweb%2Fwiklou.git

Keep buttons from changing size when they change state

Right now if a button changes from a light color to a dark color
based on some user action or state change, the button width also
changes, potentially reflowing the content and making the button
move to a completely different location. Both the height and width
need to stay the same (as was discussed in mw-ui standardization
meetings). The effect on the hover-shadow gimmick is virtually
imperceptable.

Bug: 73381
Change-Id: I27edeb4f1317c9d163bc87f54f35a161cdcd686e
---

diff --git a/resources/src/mediawiki.less/mediawiki.ui/mixins.less b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
index ec9888f27e..5d0fefbc88 100644
--- a/resources/src/mediawiki.less/mediawiki.ui/mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
@@ -77,11 +77,8 @@
 .button-colors(@bgColor) when (lightness(@bgColor) < 70%) {
 	color: #fff;
 	// border of the same color as background so that light background and
-	// dark background buttons are the same height (only top and bottom to
-	// make box shadow on hover cover the corners too)
+	// dark background buttons are the same height and width
 	border: 1px solid @bgColor;
-	border-left: none;
-	border-right: none;
 	text-shadow: 0 1px rgba(0, 0, 0, .1);
 
 	&:disabled {