Followup r70461 if PARAM_REQUIRED is set, use for missing param in getPossibleErrors...

All but ApiQueryBacklinks

diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index a1bb693..15a3a89 100644 (file)
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -1126,6 +1126,15 @@ abstract class ApiBase {
        public function getPossibleErrors() {
                $ret = array();
 
+               $params = $this->getFinalParams();
+               if ( $params ) {
+                       foreach ( $params as $paramName => $paramSettings ) {
+                               if( isset( $paramSettings[ApiBase::PARAM_REQUIRED] ) ) {
+                                       $ret[] = array( 'missingparam', $paramName );
+                               }
+                       }
+               }
+
                if ( $this->mustBePosted() ) {
                        $ret[] = array( 'mustbeposted', $this->getModuleName() );
                }

diff --git a/includes/api/ApiBlock.php b/includes/api/ApiBlock.php
index ac2daa4..2cd9bbd 100644 (file)
--- a/includes/api/ApiBlock.php
+++ b/includes/api/ApiBlock.php
@@ -173,7 +173,6 @@ class ApiBlock extends ApiBase {
 
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
-                       array( 'missingparam', 'user' ),
                        array( 'cantblock' ),
                        array( 'canthide' ),
                        array( 'cantblock-email' ),

diff --git a/includes/api/ApiEditPage.php b/includes/api/ApiEditPage.php
index 5b3afbe..819558d 100644 (file)
--- a/includes/api/ApiEditPage.php
+++ b/includes/api/ApiEditPage.php
@@ -350,7 +350,6 @@ class ApiEditPage extends ApiBase {
                global $wgMaxArticleSize;
 
                return array_merge( parent::getPossibleErrors(), array(
-                       array( 'missingparam', 'title' ),
                        array( 'missingtext' ),
                        array( 'invalidtitle', 'title' ),
                        array( 'createonly-exists' ),

diff --git a/includes/api/ApiEmailUser.php b/includes/api/ApiEmailUser.php
index 088f696..18159ec 100644 (file)
--- a/includes/api/ApiEmailUser.php
+++ b/includes/api/ApiEmailUser.php
@@ -114,8 +114,6 @@ class ApiEmailUser extends ApiBase {
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
                        array( 'usermaildisabled' ),
-                       array( 'missingparam', 'target' ),
-                       array( 'missingparam', 'text' ),
                ) );
        }
 

diff --git a/includes/api/ApiMove.php b/includes/api/ApiMove.php
index e3e7ab7..3e9c4cf 100644 (file)
--- a/includes/api/ApiMove.php
+++ b/includes/api/ApiMove.php
@@ -223,7 +223,6 @@ class ApiMove extends ApiBase {
 
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
-                       array( 'missingparam', 'to' ),
                        array( 'invalidtitle', 'from' ),
                        array( 'nosuchpageid', 'fromid' ),
                        array( 'notanarticle' ),

diff --git a/includes/api/ApiPatrol.php b/includes/api/ApiPatrol.php
index 461c2cd..e180b35 100644 (file)
--- a/includes/api/ApiPatrol.php
+++ b/includes/api/ApiPatrol.php
@@ -85,7 +85,6 @@ class ApiPatrol extends ApiBase {
 
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
-                       array( 'missingparam', 'rcid' ),
                        array( 'nosuchrcid', 'rcid' ),
                ) );
        }

diff --git a/includes/api/ApiProtect.php b/includes/api/ApiProtect.php
index 0b7e307..d9e55b6 100644 (file)
--- a/includes/api/ApiProtect.php
+++ b/includes/api/ApiProtect.php
@@ -196,8 +196,6 @@ class ApiProtect extends ApiBase {
 
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
-                       array( 'missingparam', 'title' ),
-                       array( 'missingparam', 'protections' ),
                        array( 'invalidtitle', 'title' ),
                        array( 'toofewexpiries', 'noofexpiries', 'noofprotections' ),
                        array( 'create-titleexists' ),

diff --git a/includes/api/ApiPurge.php b/includes/api/ApiPurge.php
index dc2bac0..afe7df7 100644 (file)
--- a/includes/api/ApiPurge.php
+++ b/includes/api/ApiPurge.php
@@ -102,7 +102,6 @@ class ApiPurge extends ApiBase {
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
                        array( 'cantpurge' ),
-                       array( 'missingparam', 'titles' ),
                ) );
        }
 

diff --git a/includes/api/ApiRollback.php b/includes/api/ApiRollback.php
index 71e62ee..bc108ff 100644 (file)
--- a/includes/api/ApiRollback.php
+++ b/includes/api/ApiRollback.php
@@ -120,8 +120,6 @@ class ApiRollback extends ApiBase {
 
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
-                       array( 'missingparam', 'title' ),
-                       array( 'missingparam', 'user' ),
                        array( 'invalidtitle', 'title' ),
                        array( 'notanarticle' ),
                        array( 'invaliduser', 'user' ),

diff --git a/includes/api/ApiUndelete.php b/includes/api/ApiUndelete.php
index 2551d05..a317adf 100644 (file)
--- a/includes/api/ApiUndelete.php
+++ b/includes/api/ApiUndelete.php
@@ -138,7 +138,6 @@ class ApiUndelete extends ApiBase {
 
        public function getPossibleErrors() {
                return array_merge( parent::getPossibleErrors(), array(
-                       array( 'missingparam', 'title' ),
                        array( 'permdenied-undelete' ),
                        array( 'blockedtext' ),
                        array( 'invalidtitle', 'title' ),

diff --git a/includes/api/ApiUpload.php b/includes/api/ApiUpload.php
index a6ba695..59a267d 100644 (file)
--- a/includes/api/ApiUpload.php
+++ b/includes/api/ApiUpload.php
@@ -397,7 +397,6 @@ class ApiUpload extends ApiBase {
                        array( 'invalid-session-key' ),
                        array( 'uploaddisabled' ),
                        array( 'badaccess-groups' ),
-                       array( 'missingparam', 'filename' ),
                        array( 'mustbeloggedin', 'upload' ),
                        array( 'badaccess-groups' ),
                        array( 'badaccess-groups' ),