Adding explantation for why to use User::incEditCount()
authorKaldari <rkaldari@wikimedia.org>
Fri, 28 Apr 2017 20:45:25 +0000 (13:45 -0700)
committerKaldari <rkaldari@wikimedia.org>
Fri, 28 Apr 2017 20:45:25 +0000 (13:45 -0700)
... rather than User::incEditCountImmediate() for most cases.

Change-Id: Ia16baabaeaca5c726e1dd1fc2506dc0b85500b6e

includes/user/User.php

index 3edd49f..3d6cbe4 100644 (file)
@@ -5077,6 +5077,9 @@ class User implements IDBAccessObject {
 
        /**
         * Deferred version of incEditCountImmediate()
+        *
+        * This function, rather than incEditCountImmediate(), should be used for
+        * most cases as it avoids potential deadlocks caused by concurrent editing.
         */
        public function incEditCount() {
                wfGetDB( DB_MASTER )->onTransactionPreCommitOrIdle(