Merge "Let deduplicateRootJob() accept JobSpecification for consistency"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Wed, 3 Jun 2015 17:38:35 +0000 (17:38 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Wed, 3 Jun 2015 17:38:35 +0000 (17:38 +0000)
1  2 
includes/jobqueue/JobQueueRedis.php

@@@ -402,14 -400,13 +402,14 @@@ LUA
  
        /**
         * @see JobQueue::doDeduplicateRootJob()
-        * @param Job $job
+        * @param IJobSpecification $job
         * @return bool
 -       * @throws MWException|JobQueueError
 +       * @throws JobQueueError
 +       * @throws LogicException
         */
-       protected function doDeduplicateRootJob( Job $job ) {
+       protected function doDeduplicateRootJob( IJobSpecification $job ) {
                if ( !$job->hasRootJobParams() ) {
 -                      throw new MWException( "Cannot register root job; missing parameters." );
 +                      throw new LogicException( "Cannot register root job; missing parameters." );
                }
                $params = $job->getRootJobParams();