Small code cleanups to MWCallableUpdate
authorAaron Schulz <aschulz@wikimedia.org>
Wed, 13 Jan 2016 17:00:16 +0000 (09:00 -0800)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 13 Jan 2016 17:00:16 +0000 (09:00 -0800)
Change-Id: I269199f65ffc6ad50d16cb984c28b51a815e9a8f

includes/deferred/CallableUpdate.php

index 808626d..4b19c20 100644 (file)
@@ -4,25 +4,20 @@
  * Deferrable Update for closure/callback
  */
 class MWCallableUpdate implements DeferrableUpdate {
-       /**
-        * @var Closure|callable
-        */
+       /** @var Closure|callable */
        private $callback;
 
        /**
         * @param callable $callback
-        * @throws MWException
+        * @throws InvalidArgumentException
         */
        public function __construct( $callback ) {
                if ( !is_callable( $callback ) ) {
-                       throw new MWException( 'Not a valid callback/closure!' );
+                       throw new InvalidArgumentException( 'Not a valid callback/closure!' );
                }
                $this->callback = $callback;
        }
 
-       /**
-        * Run the update
-        */
        public function doUpdate() {
                call_user_func( $this->callback );
        }