Removed $wgProto. Previously, setting this undocumented global variable to anything...
authorTim Starling <tstarling@users.mediawiki.org>
Thu, 16 Jun 2011 05:13:29 +0000 (05:13 +0000)
committerTim Starling <tstarling@users.mediawiki.org>
Thu, 16 Jun 2011 05:13:29 +0000 (05:13 +0000)
commit9420ff446e8e63bb3eb782e66369f43bdd9b4d2a
tree17b48b00b237988b9f096bf6e0aebf482e46fd6d
parent860cdbc0ff81626cdaedc924eb3a261b786b504c
Removed $wgProto. Previously, setting this undocumented global variable to anything other than the part of $wgServer before the first colon would cause various things to subtly screw up. Similarly, forgetting to set it when you override $wgServer in LocalSettings.php would break things too.

Exposing it in the default LocalSettings.php as I did in r90105 was not a good solution, really the only way to avoid breakage is to just get the protocol from $wgServer whenever you need the protocol.

Fixed $wgCookieSecure so that it will be enabled automatically if the user sets $wgServer to an https URL in LocalSettings.php. Added documentation for other cookie-related globals.

Grep indicates that $wgProto is not used by any extensions. $wgCookieSecure is used, hence the need for the Setup.php patch.
RELEASE-NOTES-1.18
includes/DefaultSettings.php
includes/GlobalFunctions.php
includes/Setup.php
includes/SkinTemplate.php
includes/installer/Installer.php
includes/installer/LocalSettingsGenerator.php
includes/resourceloader/ResourceLoaderStartUpModule.php