rdbms: avoid connections on more lazy DBConnRef methods
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 21 Mar 2019 12:51:28 +0000 (05:51 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Fri, 22 Mar 2019 00:35:27 +0000 (17:35 -0700)
commit4118762bbe609356d042e8746c5abbfe64e4696e
treef99ac01a2a238fc693221051ca34c4599d69d6a7
parent4ab8dc680e016d9b33c7f16188c14bf11c008e42
rdbms: avoid connections on more lazy DBConnRef methods

Also:
* Fixed LoadBalancer::getAnyOpenConnection for both
  DB_MASTER and DB_REPLICA, which are not real indexes.
* Lock down DBConnRef::close since it can only cause trouble.
* Relax DBConnRef restrictions on tablePrefix()/dbSchema()
  for the harmless "getter" mode case.
* Remove redundant DatabasePostgres::getServer definition.

Change-Id: Ia855d901cc3c28147e52284fdabb1645805d4466
includes/libs/rdbms/database/DBConnRef.php
includes/libs/rdbms/database/DatabasePostgres.php
includes/libs/rdbms/loadbalancer/LoadBalancer.php
tests/phpunit/includes/libs/rdbms/database/DBConnRefTest.php