From 29dbdc3a642587a2d458284380d44804e12f1386 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 24 Jun 2015 13:16:50 -0700 Subject: [PATCH] Made SqlBagOStuff set() wrap setMulti() * This also makes sure garbageCollect() is called on writes from time to time, since set() is used much more often Change-Id: I5b6cc686bd6204fc3d6ff8b003be8b8d6a493e24 --- includes/objectcache/SqlBagOStuff.php | 32 +-------------------------- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/includes/objectcache/SqlBagOStuff.php b/includes/objectcache/SqlBagOStuff.php index b8c1e75068..2847485c51 100644 --- a/includes/objectcache/SqlBagOStuff.php +++ b/includes/objectcache/SqlBagOStuff.php @@ -365,37 +365,7 @@ class SqlBagOStuff extends BagOStuff { * @return bool */ public function set( $key, $value, $exptime = 0 ) { - list( $serverIndex, $tableName ) = $this->getTableByKey( $key ); - try { - $db = $this->getDB( $serverIndex ); - $exptime = intval( $exptime ); - - if ( $exptime < 0 ) { - $exptime = 0; - } - - if ( $exptime == 0 ) { - $encExpiry = $this->getMaxDateTime( $db ); - } else { - $exptime = $this->convertExpiry( $exptime ); - $encExpiry = $db->timestamp( $exptime ); - } - // (bug 24425) use a replace if the db supports it instead of - // delete/insert to avoid clashes with conflicting keynames - $db->replace( - $tableName, - array( 'keyname' ), - array( - 'keyname' => $key, - 'value' => $db->encodeBlob( $this->serialize( $value ) ), - 'exptime' => $encExpiry - ), __METHOD__ ); - } catch ( DBError $e ) { - $this->handleWriteError( $e, $serverIndex ); - return false; - } - - return true; + return $this->setMulti( array( $key => $value ), $exptime ); } /** -- 2.20.1