jenkins-bot [Wed, 29 Nov 2017 22:17:19 +0000 (22:17 +0000)]
Merge "Shell: skip null parameters"
jenkins-bot [Wed, 29 Nov 2017 21:54:15 +0000 (21:54 +0000)]
Merge "Disallow setting DBO_IGNORE in Database for sanity"
jenkins-bot [Wed, 29 Nov 2017 21:37:03 +0000 (21:37 +0000)]
Merge "objectcache: use INTERIM_KEY_TTL constant in WANObjectCache for readability"
Aaron Schulz [Thu, 23 Nov 2017 10:17:14 +0000 (02:17 -0800)]
Disallow setting DBO_IGNORE in Database for sanity
In the off chance something called this, it would break all
sorts of code that expects that either query result functions
either succeed or throw an error.
Callers are not expected to have to check if the result of
a query is meaningful or false due to an error.
Change-Id: I0b4fe1403f55a399ffd40817ed12f857087d6f83
jenkins-bot [Wed, 29 Nov 2017 21:29:22 +0000 (21:29 +0000)]
Merge "Add ip_changes to postgres/tables.sql"
Reedy [Wed, 29 Nov 2017 21:02:22 +0000 (21:02 +0000)]
Add ip_changes to postgres/tables.sql
Follow-up Ic11c64813ee04e8520771bfa156f8e51404273e7
Bug: T177258
Change-Id: I69a278c1928ed91ef5cbe5b66e590eef629a2981
Translation updater bot [Wed, 29 Nov 2017 21:07:55 +0000 (22:07 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I71dd8b5115cb4c4db79542b25e00f0cbea8a1275
jenkins-bot [Wed, 29 Nov 2017 21:03:43 +0000 (21:03 +0000)]
Merge "Remove DEFAULT '' from postgres ip_changes.ipc_rev_timestamp"
jenkins-bot [Wed, 29 Nov 2017 20:54:00 +0000 (20:54 +0000)]
Merge "Increase Opera minimum for Grades A and C to 15"
jenkins-bot [Wed, 29 Nov 2017 20:46:09 +0000 (20:46 +0000)]
Merge "Remove moment.js bump from 1.31 release notes"
Max Semenik [Wed, 29 Nov 2017 02:51:25 +0000 (18:51 -0800)]
Shell: skip null parameters
Right now they're treated as empty strings, however
this doesn't allow skipping parameters in the middle like
$params = [
'foo',
$x ? '--bar' : null,
'--baz',
];
In some cases this matters, e.g. `ls` works while `ls ''` doesn't.
Also, fix spacing problems the new tests uncovered:
* Extra space when using params()
* Missing space when combining params() and unsafeParams()
Change-Id: Icb29d4c48ae7f92fb5635e3865346c98f47abb01
jenkins-bot [Wed, 29 Nov 2017 20:20:53 +0000 (20:20 +0000)]
Merge "mw.notifiction: Bring in some rules from Vector"
Reedy [Wed, 29 Nov 2017 20:19:27 +0000 (20:19 +0000)]
Remove moment.js bump from 1.31 release notes
Going to be backported to 1.30
Follows-up I7f89569c6ee6640d368af1378e84c5a9e725dad0
Change-Id: I691f5e0cf1f4685f8d1ff55a7ff76a1ad2587d89
jenkins-bot [Wed, 29 Nov 2017 20:13:19 +0000 (20:13 +0000)]
Merge "resources: Bump moment.js from 2.15.0 to 2.19.3"
Reedy [Wed, 29 Nov 2017 20:11:19 +0000 (20:11 +0000)]
Remove DEFAULT '' from postgres ip_changes.ipc_rev_timestamp
Follows-up Ic11c64813ee04e8520771bfa156f8e51404273e7
Bug: T181672
Change-Id: I58fe5edb1e7656773271634f702ed044c6036497
James D. Forrester [Wed, 29 Nov 2017 18:49:56 +0000 (10:49 -0800)]
resources: Bump moment.js from 2.15.0 to 2.19.3
Languages and locales now with support:
* bm
* de-ch
* gom-latn
* gu
* kn
* sd
* tet
* ur
* uz-latn
* yo
Skipped languages because we don't support them in MW:
* ar-dz
* ar-kw
* ar-ly
* en-ie
* en-nz
* es-do
* es-us
* fr-ch
* me
* nl-be
* tlh
* tzl
Also drop 'x-pseudo' which was included but not used.
Bug: T161732
Bug: T181547
Change-Id: I7f89569c6ee6640d368af1378e84c5a9e725dad0
jenkins-bot [Wed, 29 Nov 2017 19:28:02 +0000 (19:28 +0000)]
Merge "Align other review tools and saved filters buttons"
jenkins-bot [Wed, 29 Nov 2017 19:24:31 +0000 (19:24 +0000)]
Merge "Allow disabling exact input query in results in mw.widget.TitleWidget"
jenkins-bot [Wed, 29 Nov 2017 19:18:14 +0000 (19:18 +0000)]
Merge "Small change to "Other review tools" link"
petarpetkovic [Fri, 24 Nov 2017 14:14:15 +0000 (15:14 +0100)]
Allow disabling exact input query in results in mw.widget.TitleWidget
* Add configuration option to mw.widget.TitleWidget, to make
addition of exact input query to the results optional.
Change-Id: Ic7a3aaf38a3827917e4d349cc6b828f37cc64b67
jenkins-bot [Wed, 29 Nov 2017 19:04:21 +0000 (19:04 +0000)]
Merge "mediawiki.special.apisandbox.js: Apply JavaScript coding conventions"
Bartosz Dziewoński [Wed, 29 Nov 2017 16:25:57 +0000 (17:25 +0100)]
mw.debug: Avoid overlap between debug toolbar and OOUI dropdowns
Bug: T106095
Change-Id: Ia519205852324899430ac7a769ee7e81ed80c37f
Ed Sanders [Wed, 29 Nov 2017 15:53:11 +0000 (15:53 +0000)]
mw.notifiction: Bring in some rules from Vector
The larger padding makes sense as a default. Also increase
the specificity of the error/warn rules so they are overridden
by changes to the default state.
Change-Id: I157e41631c4a09842b869215b0d6dbb99c1a4d36
jenkins-bot [Wed, 29 Nov 2017 13:47:56 +0000 (13:47 +0000)]
Merge "Revert "Hide empty OOUI FieldsetLayout headers""
jenkins-bot [Wed, 29 Nov 2017 12:46:11 +0000 (12:46 +0000)]
Merge "Swap german alias order for img_thumbnail and img_manualthumb"
Aaron Schulz [Wed, 29 Nov 2017 05:59:28 +0000 (21:59 -0800)]
objectcache: use INTERIM_KEY_TTL constant in WANObjectCache for readability
Change-Id: I13936397def11a13849fe14491b752dd797f6759
James D. Forrester [Mon, 27 Nov 2017 20:39:17 +0000 (12:39 -0800)]
Increase Opera minimum for Grades A and C to 15
This drops into Grade X the Opera versions 12.10+ from Grade A,
and versions 10.x from Grade C.
Bug: T121517
Change-Id: Ie4df9c751bd0250581cd2e25cf1b38e69e67e82f
MusikAnimal [Mon, 13 Nov 2017 18:52:55 +0000 (13:52 -0500)]
Add SQL for postgres, and fail gracefully in populateIpChanges
If the ip_changes table doesn't exist, the populateIpChanges maintenance
script will fail gracefully, throwing a descriptive error.
The postgres SQL is untested.
Bug: T177258
Change-Id: Ic11c64813ee04e8520771bfa156f8e51404273e7
jenkins-bot [Wed, 29 Nov 2017 00:51:15 +0000 (00:51 +0000)]
Merge "Fix undefined $db"
Reedy [Wed, 29 Nov 2017 00:21:59 +0000 (00:21 +0000)]
Fix undefined $db
Bug: T181565
Change-Id: I286374d4ca0ab9435d7d54c4f8b9660a60e5f1e3
Bartosz Dziewoński [Thu, 16 Nov 2017 10:12:57 +0000 (10:12 +0000)]
Revert "Hide empty OOUI FieldsetLayout headers"
No longer needed after I79fe95e32272f013a1ce4e48a811fa9fbb53f4e6
(released in OOUI 0.24.3).
This reverts commit
382e366196b2b9aa7eb08c92776e6f716f8f5d65.
Depends-On: Ifdd44ead7d782288aaef0979322f0943f7304835
Change-Id: I37747b4b68801caf442b77e747f486053f279853
James D. Forrester [Wed, 29 Nov 2017 00:04:19 +0000 (16:04 -0800)]
Update OOjs UI to v0.24.3
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.3
Depends-On: Ifdd44ead7d782288aaef0979322f0943f7304853
Change-Id: Ifdd44ead7d782288aaef0979322f0943f7304835
jenkins-bot [Tue, 28 Nov 2017 21:34:33 +0000 (21:34 +0000)]
Merge "objectcache: only give current format keys getWithSetCallback() callbacks"
jenkins-bot [Tue, 28 Nov 2017 21:29:40 +0000 (21:29 +0000)]
Merge "Clean up formatting of SwiftFileBackend::sanitizeHdrsStrict()"
Aaron Schulz [Mon, 27 Nov 2017 02:45:09 +0000 (18:45 -0800)]
objectcache: only give current format keys getWithSetCallback() callbacks
Callback code that happens to make use of $oldValue might not be able
to handle missing, new, or changed fields due to key version changes.
Overhaul testGetWithSetCallback_versions() to be cleaner and cover the
case of unversioned => versioned keys.
Change-Id: If108a73078c530c985d30bdadcbfa9ddd53dc2be
Aaron Schulz [Mon, 27 Nov 2017 02:09:34 +0000 (18:09 -0800)]
objectcache: add more comments to WANObjectCache
Change-Id: I567f45fa7b33226b0ccf7d80440802eab71ff753
L10n-bot [Tue, 28 Nov 2017 20:58:23 +0000 (20:58 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Tue, 28 Nov 2017 20:58:12 +0000 (21:58 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8d6691b507556430230e527732387e7955f2c02c
jenkins-bot [Tue, 28 Nov 2017 20:58:08 +0000 (20:58 +0000)]
Merge "Use time forcing methods to avoid WANObjectCacheTest flakeiness"
petarpetkovic [Tue, 28 Nov 2017 14:32:05 +0000 (15:32 +0100)]
Small change to "Other review tools" link
- Reduce the separation between the label and the expand/collapse icon.
Bug: T179539
Change-Id: I0bfc8a72650325a815be930a64e472ae66f536f6
jenkins-bot [Tue, 28 Nov 2017 18:31:52 +0000 (18:31 +0000)]
Merge "Introduce ClearUserWatchlistJob"
addshore [Mon, 14 Mar 2016 21:07:39 +0000 (21:07 +0000)]
Introduce ClearUserWatchlistJob
Change-Id: Icea573a10078ea3f09dc2e4e9fdc737bf639935d
Aaron Schulz [Tue, 28 Nov 2017 17:07:37 +0000 (09:07 -0800)]
Clean up formatting of SwiftFileBackend::sanitizeHdrsStrict()
Change-Id: I5e411f4bf50836d22db01220853776494a9e69d5
Bartosz Dziewoński [Tue, 28 Nov 2017 15:26:51 +0000 (16:26 +0100)]
mw.special.preferences: Widen the dropdown of the "Time zone" field
Same styles as for the "Reason" field on Special:Block
(
b2a0e3aac8f70802a5f45cc7e7fbb0f9c517fb82).
Bug: T181433
Change-Id: I957226ce3764e1bcc14ea088cadf4531a1dd1886
Cormac Parle [Mon, 20 Nov 2017 11:25:20 +0000 (11:25 +0000)]
Do not strip Content-Type header for POST requests to swift
libcurl adds 'Content-Type: application/x-www-form-urlencoded'
to a POST request if the 'Content-Type' header is not set
manually. Because data in swift is updated via POST, the
Content-Type header must be set explicitly to stop a run of
refreshFileHeaders.php from changing the Content-Type of all
files in swift to application/x-www-form-urlencoded
Bug: T178849
Change-Id: I43c21bc1b73e37104cf07cd5f1c1557f472b9898
jenkins-bot [Tue, 28 Nov 2017 13:54:00 +0000 (13:54 +0000)]
Merge "Document how to run just one Selenium test"
jenkins-bot [Tue, 28 Nov 2017 13:38:15 +0000 (13:38 +0000)]
Merge "ESLint ecmaVersion setting is not needed if env is es6"
Željko Filipin [Tue, 28 Nov 2017 13:26:42 +0000 (14:26 +0100)]
Document how to run just one Selenium test
Bug: T139740
Change-Id: Ieb5f27285046c33d77b615159dc2000d80ef644a
petarpetkovic [Tue, 28 Nov 2017 12:23:06 +0000 (13:23 +0100)]
Align other review tools and saved filters buttons
Bug: T179825
Change-Id: I654d417072bb58a6518a1094061208788b64c1f8
jenkins-bot [Tue, 28 Nov 2017 09:46:30 +0000 (09:46 +0000)]
Merge "Allow file headers to be refreshed from database"
Aaron Schulz [Mon, 27 Nov 2017 18:51:32 +0000 (10:51 -0800)]
Use time forcing methods to avoid WANObjectCacheTest flakeiness
Use of microtime() is now just for baselines, and it is no longer
assumed to be increasing with each call. Such an assumption is
particuliarly bad on Windows.
I've done 100X run rounds with now failures on Windows.
Change-Id: Ica2a47982495bc95b10ca507414972744ea9507e
jenkins-bot [Tue, 28 Nov 2017 03:19:14 +0000 (03:19 +0000)]
Merge "logging: Abstract LogPager enforcing of action and performer restrictions"
cenarium [Mon, 25 Jan 2016 21:35:22 +0000 (22:35 +0100)]
logging: Abstract LogPager enforcing of action and performer restrictions
This avoids duplicating the code in the future, such as proposed for
I3ea2c050b6dd6c (T16711).
Change-Id: Ic53b074f542014f156b006864d91a138ba5fb22b
jenkins-bot [Tue, 28 Nov 2017 02:21:50 +0000 (02:21 +0000)]
Merge "objectcache: add "graceTTL" option to WANObjectCache::getWithSetCallback()"
Aaron Schulz [Mon, 27 Nov 2017 10:51:11 +0000 (02:51 -0800)]
objectcache: add "graceTTL" option to WANObjectCache::getWithSetCallback()
Also made worthRefreshExpiring() fully match the method documentation.
Change-Id: I48a4b1b9d006de100389b47c03c1185a9316abfc
jenkins-bot [Tue, 28 Nov 2017 01:01:22 +0000 (01:01 +0000)]
Merge "Add WebAssembly application/wasm MIME type"
jenkins-bot [Tue, 28 Nov 2017 00:26:37 +0000 (00:26 +0000)]
Merge "Use WANObjectCache::makeKey() in ChangesFeed"
jenkins-bot [Tue, 28 Nov 2017 00:23:09 +0000 (00:23 +0000)]
Merge "Graduate live update out of beta"
jenkins-bot [Tue, 28 Nov 2017 00:18:23 +0000 (00:18 +0000)]
Merge "Move seperators from digits transforms to seperator transforms"
jenkins-bot [Tue, 28 Nov 2017 00:14:32 +0000 (00:14 +0000)]
Merge "shell: Optionally restrict commands' access with firejail"
Roan Kattouw [Tue, 28 Nov 2017 00:11:44 +0000 (16:11 -0800)]
Graduate live update out of beta
Bug: T173614
Change-Id: I680b518fa3b8a0bb5ac3a6ec8347e57e70c26d20
Reedy [Fri, 24 Nov 2017 15:49:15 +0000 (15:49 +0000)]
Move seperators from digits transforms to seperator transforms
Change-Id: Iecc30b4eae9a5fe0f87d162c8118722ba5aab90c
jenkins-bot [Tue, 28 Nov 2017 00:08:16 +0000 (00:08 +0000)]
Merge "Change "Live update" button animation"
Kunal Mehta [Wed, 18 Oct 2017 06:54:19 +0000 (23:54 -0700)]
shell: Optionally restrict commands' access with firejail
Introduces a FirejailCommand class, which can be used to add additional
restrictions to a command, for increased security. For now, firejail
containment needs to be enabled on a per-command basis.
The following restrictions are implemented:
* NO_ROOT - disallows any root access, including via setuid binaries
* SECCOMP - block dangerous syscalls with seccomp
* PRIVATE_DEV - create a private /dev
* NO_NETWORK - deny all network access
* NO_EXECVE - block the execve syscall
A convenient Shell::RESTRICT_DEFAULT is equivalent to NO_ROOT | SECCOMP
| PRIVATE_DEV, with the expectation that more restrictions may be added
to it in the future.
In addition, specific paths can be whitelisted with
Command::whitelistPaths(). Any file/directory that isn't whitelisted in
that top level directory (e.g. /srv) won't exist inside the firejail.
$wgShellRestrictionMethod can be set to false for no restriction system,
'firejail' to explicitly use it, or 'autodetect' to autodetect whatever
system is available. In the future the default should be changed to
autodetection once firejail is tested more.
Bug: T173370
Change-Id: Id74df0dbba40e1e7c07c4368aacffb6eb06a17c5
jenkins-bot [Mon, 27 Nov 2017 21:28:00 +0000 (21:28 +0000)]
Merge "Remove math from $wgDefaultUserOptions as Math isn't in core"
Translation updater bot [Mon, 27 Nov 2017 21:07:34 +0000 (22:07 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I7b3081cef41dc283356ab30f835766a5f467cae0
jenkins-bot [Mon, 27 Nov 2017 20:57:36 +0000 (20:57 +0000)]
Merge "Soft deprecate $wgStyleVersion (add @deprecated)"
jenkins-bot [Mon, 27 Nov 2017 20:30:28 +0000 (20:30 +0000)]
Merge "mw.special.preferences: Make the "Basic information" section more compact"
Reedy [Mon, 27 Nov 2017 20:27:35 +0000 (20:27 +0000)]
Remove math from $wgDefaultUserOptions as Math isn't in core
Change-Id: Id8248d673cda342d6727a02cd5a440be87e7c0c1
jenkins-bot [Mon, 27 Nov 2017 20:15:03 +0000 (20:15 +0000)]
Merge "Minor code updates to SpecialListgrouprights"
Reedy [Fri, 24 Nov 2017 23:12:25 +0000 (23:12 +0000)]
Soft deprecate $wgStyleVersion (add @deprecated)
Bug: T181318
Change-Id: Ib5dce1c8d39a821aab0f96133780c18c827bde03
Aaron Schulz [Mon, 27 Nov 2017 20:03:47 +0000 (12:03 -0800)]
Use WANObjectCache::makeKey() in ChangesFeed
Change-Id: Ia029873e5d0883d177007555ad494cae9e00c407
petarpetkovic [Mon, 27 Nov 2017 19:59:03 +0000 (20:59 +0100)]
Change "Live update" button animation
- Extend the total length of the animation to 2.3 seconds.
- Redefine the transitions in the animation to be completed
already at the 80% point (instead of the current 100%),
in order to create a period of no change between repetitions.
Bug: T176474
Change-Id: Ibea7c74a90be0394223d8fa85324bbf4cee16c4d
Bartosz Dziewoński [Mon, 27 Nov 2017 19:01:40 +0000 (20:01 +0100)]
mw.special.preferences: Make the "Basic information" section more compact
Bug: T180538
Change-Id: Iddb73573637dd740fbebed52096cf82ef7c31c00
jenkins-bot [Mon, 27 Nov 2017 19:46:44 +0000 (19:46 +0000)]
Merge "objectcache: make adaptiveTTL() use getCurrentTime() for completeness"
jenkins-bot [Mon, 27 Nov 2017 18:00:39 +0000 (18:00 +0000)]
Merge "Add Pashto numerals based on Arabic"
Aaron Schulz [Mon, 27 Nov 2017 17:45:46 +0000 (09:45 -0800)]
objectcache: make adaptiveTTL() use getCurrentTime() for completeness
Change-Id: I5ba3c39ccaf412b0aaecd64d52ab15b2075bc76c
Reedy [Fri, 24 Nov 2017 00:02:58 +0000 (00:02 +0000)]
Add Pashto numerals based on Arabic
Bug: T181265
Change-Id: I19cf703edc90a1f57e7b083b3b29cffd77c45c90
jenkins-bot [Mon, 27 Nov 2017 16:39:07 +0000 (16:39 +0000)]
Merge "RELEASE-NOTES to HISTORY for 1.27.4/1.28.3/1.29.2"
Cormac Parle [Mon, 27 Nov 2017 15:01:37 +0000 (15:01 +0000)]
Allow file headers to be refreshed from database
Bug: T178849
Change-Id: I100458cdb55db10d49c586c83876b7d1645ec486
Cormac Parle [Mon, 27 Nov 2017 09:44:19 +0000 (09:44 +0000)]
Handle case when there is no handler for a file
Bug: T181365
Change-Id: Ia76b9e891eeb50071ef91e1768a7ad50f6fd7563
jenkins-bot [Mon, 27 Nov 2017 07:53:55 +0000 (07:53 +0000)]
Merge "Replace MimeMagic::singleton() calls"
Reedy [Mon, 27 Nov 2017 01:33:57 +0000 (01:33 +0000)]
Replace MimeMagic::singleton() calls
Change-Id: Ieed41b5d6b0f568fe2872e7754f2feae7868fe7a
Ian Marlier [Wed, 22 Nov 2017 17:02:26 +0000 (12:02 -0500)]
API:Siteinfo: Include wgCategoryCollation in Siteinfo response
Include the value of $wgCategoryCollation in the siteinfo general array. This will allow AWB to get this information without needing to scrape the NOC InitialiseSettings.php.txt file.
Bug: T179795
Change-Id: I76f85c71d2fe0d7a0482fb5eda0458708057e48d
jenkins-bot [Sun, 26 Nov 2017 21:55:46 +0000 (21:55 +0000)]
Merge "objectcache: add "staleTTL" into WANObjectCache::getWithSetCallback()"
Aaron Schulz [Tue, 21 Nov 2017 22:11:01 +0000 (14:11 -0800)]
objectcache: add "staleTTL" into WANObjectCache::getWithSetCallback()
This simply involves passing it through to the set() call
Also added some related commons to adaptiveTTL() involving
usage of this option.
Change-Id: Id5833a5d4efb6cad2eb646832e5b0188e86e12fc
jenkins-bot [Sun, 26 Nov 2017 21:39:32 +0000 (21:39 +0000)]
Merge "Reduce replication log spam from LoadBalancer"
jenkins-bot [Sun, 26 Nov 2017 21:34:42 +0000 (21:34 +0000)]
Merge "Make IDatabase return type documentation less confusing"
jenkins-bot [Sun, 26 Nov 2017 21:34:10 +0000 (21:34 +0000)]
Merge "objectcache: improve touchCheckKey()/resetCheckKey() comments"
Translation updater bot [Sun, 26 Nov 2017 20:54:12 +0000 (21:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia4a84786f3e85d400a9d2e947325d92923fda4f6
Umherirrender [Wed, 8 Nov 2017 17:58:36 +0000 (18:58 +0100)]
Swap german alias order for img_thumbnail and img_manualthumb
The shorter form is used more often in new code than the longer version.
Changed the default to the shorter form.
WikiEditor will than use the short version when embedding files.
Change-Id: I10797e99955f4776ec4f18ab82aa98eb03369959
Translation updater bot [Sat, 25 Nov 2017 20:58:38 +0000 (21:58 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I02c5bc7b5265db3f931e7f4ed980ff7893784cdb
Translation updater bot [Fri, 24 Nov 2017 21:22:51 +0000 (22:22 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ief16532a063d4ad132d0f2948f421d6346c8c7e3
jenkins-bot [Fri, 24 Nov 2017 13:00:45 +0000 (13:00 +0000)]
Merge "More user related Revision construction test cases"
jenkins-bot [Fri, 24 Nov 2017 08:31:47 +0000 (08:31 +0000)]
Merge "SpecialUnblock: Remove addModules( 'mediawiki.special' )"
Translation updater bot [Thu, 23 Nov 2017 21:29:53 +0000 (22:29 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I918d590d42a4095d3e9337db534cf604ea1c479b
jenkins-bot [Thu, 23 Nov 2017 21:10:19 +0000 (21:10 +0000)]
Merge "Remove unused WikiPageTestContentHandlerUseDB (test)"
Fomafix [Tue, 21 Nov 2017 18:14:44 +0000 (19:14 +0100)]
mediawiki.special.apisandbox.js: Apply JavaScript coding conventions
Do not use the jQuery constructor with second argument.
https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Pitfalls
Change-Id: I0c7e93438c78e234c6656b2e6499e674a0322cd3
addshore [Thu, 23 Nov 2017 19:09:15 +0000 (19:09 +0000)]
Remove method level @group Database tags
MessageTest did not have the group at class level
either so that is added in this patch.
Change-Id: Idb6213282d6854044f374c9df51ea32d0a5523e1
addshore [Thu, 23 Nov 2017 19:19:14 +0000 (19:19 +0000)]
Clarify the use of @group Database in MediaWikiTestCase
Only the class level doc comment is checked.
Adding @group Database to a method doc comment will do
nothing.
Change-Id: Ic0fff3636d6c44e7a27df8806c9712155ce81d8c