Raimond Spekking [Tue, 27 May 2008 16:33:20 +0000 (16:33 +0000)]
Add new right 'writeapi', introduced per r35399.
Aryeh Gregor [Tue, 27 May 2008 16:23:23 +0000 (16:23 +0000)]
Testing whether "!$this" is true makes absolutely no sense. Either we're in an object context, in which case it's always true; or we're not, like if the method was called statically, in which case the code is seriously buggy and *should* crash with a fatal error so we can fix it ASAP (which it will, now, on the next line when a method of $this is called).
Tim Starling [Tue, 27 May 2008 16:21:23 +0000 (16:21 +0000)]
Hook change required for r35409
Roan Kattouw [Tue, 27 May 2008 16:10:43 +0000 (16:10 +0000)]
Let's not return arrays of arrays of arrays here :O
Roan Kattouw [Tue, 27 May 2008 16:03:21 +0000 (16:03 +0000)]
Per Simetrical's suggestion, let Title::isValidMoveOperation() return all errors rather than bailing out at the first one. Also added some FIXMEs here and there: the point is that errors on file moves currently return wikitext. I'll poke Bryan (Tongh Minh) about that
Roan Kattouw [Tue, 27 May 2008 15:43:07 +0000 (15:43 +0000)]
* Added 'writeapi' right that controls access to the write API. Users who don't have this right won't be able to use the write API modules even if $wgEnableWriteAPI = true; and they have the other rights required
* Checking for 'writeapi' in ApiMain::requestWriteMode() and tweaking the noapiwrite error message a bit
* Granting this right to *, user and bot by default.
For extra clarity: to e.g. move pages through the API, a user needs to have the 'move' right AND the 'writeapi' right AND $wgEnableWriteAPI = true;
Roan Kattouw [Tue, 27 May 2008 14:42:51 +0000 (14:42 +0000)]
* Refactor Title::isValidMoveOperation() and Title::moveTo() to return an array of arrays like Title::getUserPermissionsErrors() does; other functions used by the write API have undergone similar refactoring earlier
* Handle these return values in MovePageForm::doSubmit() and ApiMove::execute()
* Remove separate AbortMove hook calls from MovePageForm and ApiMove; these were used to capture the hook error, but the new return type handles that. Also, it resulted in two calls to that hook for each move
* Remove comment about SpecialMovepageAfterMove hook from ApiMove::execute(): we don't need it, there's the TitleMoveComplete hook for that. SpecialMovepageAfterMove is a UI hook that doesn't belong in the API
* Add imagenocrossnamespace and imagetypemismatch errors to ApiBase::$messageMap
Roan Kattouw [Tue, 27 May 2008 10:18:28 +0000 (10:18 +0000)]
API: Make action=block return an ISO 8601 timestamp rather than a UNIX timestamp
Robert Leverington [Tue, 27 May 2008 09:19:24 +0000 (09:19 +0000)]
* Language::getFallbackFor() now returns 'en' when the passed language does not exist, rather than bool(false).
* Remove excess tab from end of one line.
Patch by Nike.
Siebrand Mazeland [Tue, 27 May 2008 09:08:30 +0000 (09:08 +0000)]
Localisation updates for core messages from Betawiki (2008-05-27 10:55 CEST)
Aaron Schulz [Tue, 27 May 2008 04:47:29 +0000 (04:47 +0000)]
Doc typo
Danny B [Tue, 27 May 2008 02:45:40 +0000 (02:45 +0000)]
+ Wikinews, Wikiversity, Wikispecies
Aryeh Gregor [Tue, 27 May 2008 00:36:39 +0000 (00:36 +0000)]
Prettify ternary operator a bit
Aaron Schulz [Tue, 27 May 2008 00:25:50 +0000 (00:25 +0000)]
Remove doc now
Aaron Schulz [Tue, 27 May 2008 00:21:53 +0000 (00:21 +0000)]
Fix order...that was confusing
Aaron Schulz [Tue, 27 May 2008 00:13:06 +0000 (00:13 +0000)]
Actually offset correctly
Aaron Schulz [Mon, 26 May 2008 23:56:40 +0000 (23:56 +0000)]
Fill in getDefaultQuery() for WLH/x links to carry title over in nav links
Aaron Schulz [Mon, 26 May 2008 22:43:42 +0000 (22:43 +0000)]
* Show if pages are both image linked/transcluded
* Remove comment: on second though, this can't happen
Aaron Schulz [Mon, 26 May 2008 22:10:44 +0000 (22:10 +0000)]
Grammar
Aaron Schulz [Mon, 26 May 2008 22:10:08 +0000 (22:10 +0000)]
Fix duplicate row removal
Aaron Schulz [Mon, 26 May 2008 21:32:53 +0000 (21:32 +0000)]
* Convert to using Pager and remove a bunch of ugly code. The order and distinctness is now all done by the DB
* Use linkbatch to avoid some O(n) query spam
* Break some long lines
Siebrand Mazeland [Mon, 26 May 2008 18:01:06 +0000 (18:01 +0000)]
* Rename 'right-hiderevision' to 'right-suppressrevision'
* Rebuilt all language files
Rotem Liss [Mon, 26 May 2008 17:31:11 +0000 (17:31 +0000)]
Update for he.
Raimond Spekking [Mon, 26 May 2008 15:06:43 +0000 (15:06 +0000)]
* Core: Rename 'right-hiderevison' to 'right-suppressrevision' per change in r35303
* Extension: Add 'right-hiderevison' as it it now a pure extension right.
Raimond Spekking [Mon, 26 May 2008 12:15:56 +0000 (12:15 +0000)]
Localisation updates German
Aryeh Gregor [Mon, 26 May 2008 12:15:21 +0000 (12:15 +0000)]
No, something that looks stupid *is* in fact ipso facto stupid -- unless it includes a comment to explain why it's not.
Rotem Liss [Mon, 26 May 2008 11:55:31 +0000 (11:55 +0000)]
Update.
Roan Kattouw [Mon, 26 May 2008 10:51:31 +0000 (10:51 +0000)]
Fixing timestamp conversion breakage: ignores the fact that !isset($params['timestamps']) means we wanna restore everything.
Roan Kattouw [Mon, 26 May 2008 10:14:58 +0000 (10:14 +0000)]
Partial revert of r35058: when something looks stupid, that doesn't mean it is. This is done because the function in question expects a reference.
Krzysztof Krzyzaniak [Mon, 26 May 2008 09:48:52 +0000 (09:48 +0000)]
$to could be array, replaced by $dest variable
Tim Starling [Mon, 26 May 2008 08:19:37 +0000 (08:19 +0000)]
Updates for the modern age
Shinjiman [Mon, 26 May 2008 06:06:53 +0000 (06:06 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Aryeh Gregor [Mon, 26 May 2008 00:17:25 +0000 (00:17 +0000)]
Yoris on IRC points out that it used to be standard practice for extensions to create files in the includes directory, ca. two and a half years ago: mediawiki.org/w/index.php?title=Manual:Special_pages&oldid=107180#Include_page Add a note to this effect to UPGRADE.
Siebrand Mazeland [Sun, 25 May 2008 23:06:38 +0000 (23:06 +0000)]
Localisation updates for core messages from Betawiki (2008-05-26 00:59 CEST)
Huji [Sun, 25 May 2008 19:09:28 +0000 (19:09 +0000)]
Localisation updates: Adding/updating Persian translations
Alexandre Emsenhuber [Sun, 25 May 2008 19:01:03 +0000 (19:01 +0000)]
(bug 12145) Kazakh message updates
Aaron Schulz [Sun, 25 May 2008 18:20:33 +0000 (18:20 +0000)]
Move 'NewRevisionFromEditComplete' to proper place (bug 14251)
Brion Vibber [Sun, 25 May 2008 17:08:25 +0000 (17:08 +0000)]
Revert patch credit removal in r35287.
VERY bad form, dude. VERY bad form.
Brion Vibber [Sun, 25 May 2008 17:00:38 +0000 (17:00 +0000)]
Revert r35277 (grayed-out paging links). IMHO this just doesn't look very good.
Alexandre Emsenhuber [Sun, 25 May 2008 14:47:39 +0000 (14:47 +0000)]
Per r35319: update messages.inc and rebuild MessagesEn.php
Leon Weber [Sun, 25 May 2008 14:06:55 +0000 (14:06 +0000)]
* (bug 14259) Localisation message for upload button on Special:Import is now 'import-upload'
instead of 'upload'
* -> German localisation update
Aaron Schulz [Sun, 25 May 2008 05:23:49 +0000 (05:23 +0000)]
Darking pager dead links a tad
Aaron Schulz [Sun, 25 May 2008 05:06:50 +0000 (05:06 +0000)]
* Wrap file into one nice move transaction with the rest
* Fix undefined variable error
Aaron Schulz [Sun, 25 May 2008 00:32:08 +0000 (00:32 +0000)]
Tweak comment
Aaron Schulz [Sun, 25 May 2008 00:31:28 +0000 (00:31 +0000)]
Rename 'hiderevision' to 'suppressrevision'
Aaron Schulz [Sat, 24 May 2008 23:56:07 +0000 (23:56 +0000)]
Extra sanity check
Roan Kattouw [Sat, 24 May 2008 21:54:57 +0000 (21:54 +0000)]
Add array support to wfArrayToCGI(): when receiving parameters in the form of &foo[]=bar&foo[]=baz, PHP automatically sets $_GET['foo'] = array(bar, baz); When feeding the original query back to wfArrayToCGI(), it used to choke on that. Now wfArrayToCGI() actually converts array('bar', 'baz'); back to the &foo[]=bar&foo[]=baz form.
Alexandre Emsenhuber [Sat, 24 May 2008 20:51:08 +0000 (20:51 +0000)]
Document ImagePageFindFile hook
Bryan Tong Minh [Sat, 24 May 2008 20:48:45 +0000 (20:48 +0000)]
On second thought file undeletion is supported; just not undeleting a specific file. Added relevant hook for this.
Bryan Tong Minh [Sat, 24 May 2008 20:44:49 +0000 (20:44 +0000)]
* Add wfRunHook calls where appropriate
* Fix handling of file redirects in ApiDelete
* Throw an error when a file is undeleted as this is not supported
Huji [Sat, 24 May 2008 19:40:07 +0000 (19:40 +0000)]
Localisation updates: Adding/updating Persian translations
Siebrand Mazeland [Sat, 24 May 2008 18:02:35 +0000 (18:02 +0000)]
Fix "oops" in previous commit.
Siebrand Mazeland [Sat, 24 May 2008 17:58:21 +0000 (17:58 +0000)]
* remove "Patch by <name>"
* remove end of line periods for consistency
* update localisations section
Aaron Schulz [Sat, 24 May 2008 16:57:51 +0000 (16:57 +0000)]
Add getRevisionId()
Ryan Schmidt [Sat, 24 May 2008 16:49:05 +0000 (16:49 +0000)]
* fixing bug 14241: pages can no longer be protected to levels you are not in
Bryan Tong Minh [Sat, 24 May 2008 16:36:52 +0000 (16:36 +0000)]
Rather than "fix a security leak", specify what this leak is.
Siebrand Mazeland [Sat, 24 May 2008 15:12:41 +0000 (15:12 +0000)]
Localisation updates for core messages from Betawiki (2008-05-24 16:53 CEST)
Leon Weber [Sat, 24 May 2008 14:55:54 +0000 (14:55 +0000)]
* Refactored Article::getAutosummary(), so there's not a very simple static function called for every
autosummary case, instead just include the appropriate code, which makes the whole thing much shorter
and cleaner.
* Removed Article::getRedirectAutosummary() and Article::getBlankingAutosummary(), which were obsolete
then.
* Article::getRedirectAutosummary() was called from EditPage::internalAttemptSave() as check if the page
being edited is a redirect. Replaced that function call with the one-line routine which was used in the
former Article::getRedirectAutosummary() function. We should have this check in some general static
function, though.
Shinjiman [Sat, 24 May 2008 12:55:06 +0000 (12:55 +0000)]
Update the Chinese conversion tables
Leon Weber [Sat, 24 May 2008 09:39:51 +0000 (09:39 +0000)]
Arg, of course I forgot that again.
Leon Weber [Sat, 24 May 2008 09:37:45 +0000 (09:37 +0000)]
Paging links on special pages now have CSS classes and are greyed out by default when disabled. Somehow related to bug 14244.
Leon Weber [Sat, 24 May 2008 08:32:42 +0000 (08:32 +0000)]
(bug 12145) Kazakh localisation updates, modified patch 4921 by AlefZet
Rotem Liss [Sat, 24 May 2008 06:43:48 +0000 (06:43 +0000)]
Update.
Shinjiman [Sat, 24 May 2008 03:51:10 +0000 (03:51 +0000)]
Localisation updates Cantonese, Chinese and Old/Late Time Chinese
Danny B [Sat, 24 May 2008 01:04:32 +0000 (01:04 +0000)]
* Bug 14245 - Bot flag not shown on RC IRC posts
* switching the M & N flags order
Aryeh Gregor [Fri, 23 May 2008 22:20:09 +0000 (22:20 +0000)]
Syntax error
Robert Leverington [Fri, 23 May 2008 22:18:57 +0000 (22:18 +0000)]
* Remove "DO NOT EDIT" notices from a couple of the message files, these should have been deleted a long time ago.
* Fix a typo in one of my previous commits.
Niklas Laxström [Fri, 23 May 2008 22:17:13 +0000 (22:17 +0000)]
* And the variable definition for my previous commit
Robert Leverington [Fri, 23 May 2008 22:15:13 +0000 (22:15 +0000)]
* These should also all be @ingroup, not @addtogroup.
Niklas Laxström [Fri, 23 May 2008 22:14:32 +0000 (22:14 +0000)]
* New option $wgPerLanguageCaching, for wikies with many translated system messages in MediaWiki namespace.
* Sidebar is now cached for all languages
Robert Leverington [Fri, 23 May 2008 22:12:06 +0000 (22:12 +0000)]
* Partially revert 35259; this should be @ingroup not @addtogroup.
Leon Weber [Fri, 23 May 2008 22:07:35 +0000 (22:07 +0000)]
* Updating RELEASE-NOTES for last commit, which accidently had no commit message.
Last commit message:
* (bug 14243) Fix security leak in edit api; patch 4920 by HardDisk
* (bug 12145) Kazakh localisation updates; part of patch 4919 by AlefZet
Leon Weber [Fri, 23 May 2008 22:02:23 +0000 (22:02 +0000)]
Aryeh Gregor [Fri, 23 May 2008 22:00:14 +0000 (22:00 +0000)]
Code simplification (-205 bytes :P):
* Add MWNamespace::hasSubpages() and use that instead of $wgNamespacesWithSubpages everywhere
* Put early returns first, and don't else { } the rest of the code
Aryeh Gregor [Fri, 23 May 2008 21:31:39 +0000 (21:31 +0000)]
Fix another bug pointed out by Brion, pseudo-subpages can get moved.
Aryeh Gregor [Fri, 23 May 2008 21:22:54 +0000 (21:22 +0000)]
Fix bug: we still need to move subpages if we're moving the talk page, and the talk namespace allows subpages.
Aaron Schulz [Fri, 23 May 2008 21:12:47 +0000 (21:12 +0000)]
Remove unused var
Brion Vibber [Fri, 23 May 2008 21:11:12 +0000 (21:11 +0000)]
restore movepage-page-moved from r35213, seems to have been removed by some subsequent update
Brion Vibber [Fri, 23 May 2008 20:31:41 +0000 (20:31 +0000)]
drop redundant wfTimestamp() call... we already got it formatted in TS_MW from decodeExpiry()
Alexandre Emsenhuber [Fri, 23 May 2008 20:06:25 +0000 (20:06 +0000)]
phpdoc -> doxygen
Brion Vibber [Fri, 23 May 2008 19:26:44 +0000 (19:26 +0000)]
add timestamps to runJobs output, should make it easier to track down stuck job queue runners
Alexandre Emsenhuber [Fri, 23 May 2008 18:14:11 +0000 (18:14 +0000)]
(bug 12145) Kazakh message updates
Niklas Laxström [Fri, 23 May 2008 17:40:06 +0000 (17:40 +0000)]
* Update plural for uk
Aryeh Gregor [Fri, 23 May 2008 17:15:33 +0000 (17:15 +0000)]
Reduce default max pages to move at once to 100, primarily to keep RC spam to sane levels until a more reasonable fix can be thought up.
Aryeh Gregor [Fri, 23 May 2008 17:09:28 +0000 (17:09 +0000)]
* Don't allow moving with subpages to a namespace that doesn't allow subpages. Such a move is only questionably reasonable, and even if reasonable it's not possible to revert it.
* Use a consistent test for whether a namespace permits subpages: empty(), not isset or boolean test with errors suppressed or a combination of those. The isset test alone (used in isSubpage()) is particularly broken because it returns true if the namespace is explicitly set to *not* allow namespaces, and only returns false if the entry is unset.
* Reshuffle some global declarations, simplify a conditional block
Aaron Schulz [Fri, 23 May 2008 16:55:52 +0000 (16:55 +0000)]
Add PageHistoryPager::getQueryInfo
Aaron Schulz [Fri, 23 May 2008 16:47:39 +0000 (16:47 +0000)]
* Add $wgFlaggedRevsVisible back. Made for third-party use.
* Add hook to JOIN for data for page history, rather than query spam
* Fix a panty load of E_STRICT errors
* Tweak variable name
Rotem Liss [Fri, 23 May 2008 15:27:19 +0000 (15:27 +0000)]
Update for he.
Alexandre Emsenhuber [Fri, 23 May 2008 15:08:33 +0000 (15:08 +0000)]
Update messages.inc and rebuild MessagesEn.php
Leon Weber [Fri, 23 May 2008 13:53:54 +0000 (13:53 +0000)]
German localisation updates. Patch by raymond.
Huji [Fri, 23 May 2008 10:55:54 +0000 (10:55 +0000)]
* Adding/updating Persian translations
* Adding an ignored message to the ingored messages list
Siebrand Mazeland [Fri, 23 May 2008 10:40:56 +0000 (10:40 +0000)]
Localisation updates. Messages imported from cv.wp and ln.wp
Andrew Garrett [Fri, 23 May 2008 10:34:11 +0000 (10:34 +0000)]
Core changes for GlobalBlocking and TorBlock extensions, plus some core refactoring work:
* Instead of saying 'do that' in a permissions error, actually list what the action is (drawn from the right-$1 messages). This isn't perfect - it says you don't have permission to edit pages when
you can't edit a single page, but it's better than 'do that'.
* Refactor out some code from various block files into Block::formatExpiry and Block::parseExpiryInput.
* Don't display 'you cannot edit special pages' when you're trying to execute, or create an account, or something like that.
* New AbortAutoblock hook (for use in TorBlock extension), which allows extensions to cancel autoblocks.
Tim Starling [Fri, 23 May 2008 09:03:49 +0000 (09:03 +0000)]
In FlaggedRevs:
* Moved the FlaggedRevs class to its own file
* Removed $wgFlaggedArticle, store an instance inside the Article object instead. Also store a reference in the Title object, since some hooks only have a Title available.
* Modified all hooks which were previously calling $wgFlaggedArticle directly to go via an instance loader function.
* Merged hook functions for ArticleViewHeader and DiffViewHeader
* Changed the way FlaggedRevs sets the right image version in ImagePage, to avoid a function call on startup
* Some coding style changes, such as consistent variable case, consistent indenting style, meaningful variable names, etc.
* Fixed typo in updateAutoPromote.php
* Removed the $wgFlaggedRevsVisible feature, this doesn't seem to be in keeping with our mission so I couldn't see the point in spending a lot of time fixing its bugs. Revert if necessary.
* Use Xml::encodeJsVar() to transfer data from PHP to JS, don't DIY
* Use OutputPage::addHeadItem() instead of an infinite-lifetime variable to ensure that only one copy of the header item is added. OutputPage objects may come and go.
Tim Starling [Fri, 23 May 2008 09:00:08 +0000 (09:00 +0000)]
Fixed sloppy usage of Database::selectField() in getPreviousRevisionID() and getNextRevisionID()
Tim Starling [Fri, 23 May 2008 08:54:19 +0000 (08:54 +0000)]
Clarify behaviour of wfGetDB(DB_SLAVE)
Aaron Schulz [Fri, 23 May 2008 07:33:35 +0000 (07:33 +0000)]
Remove shitty ass useless fucking ampersands that just make it harder to avoid fucking strict notices
Siebrand Mazeland [Fri, 23 May 2008 07:28:08 +0000 (07:28 +0000)]
Localisation updates. Rebuilt all language files.
Siebrand Mazeland [Fri, 23 May 2008 07:26:48 +0000 (07:26 +0000)]
Localisation updates. Rebuilt all language files.
Niklas Laxström [Fri, 23 May 2008 07:20:52 +0000 (07:20 +0000)]
* PHP Strict Standards: Only variables should be passed by reference in <>