Platonides [Tue, 30 Nov 2010 23:46:14 +0000 (23:46 +0000)]
Use constants. Add spacing.
Bryan Tong Minh [Tue, 30 Nov 2010 20:57:22 +0000 (20:57 +0000)]
(bug 26160) Upload description set by extensions are not propagated
Regression originating from the UploadForm rewrite; going to mark for 1.16
Raimond Spekking [Tue, 30 Nov 2010 20:47:01 +0000 (20:47 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-30 20:23:00 UTC)
Sam Reed [Tue, 30 Nov 2010 19:38:04 +0000 (19:38 +0000)]
Remove some redundant character escapes from regexes
Sam Reed [Tue, 30 Nov 2010 19:34:48 +0000 (19:34 +0000)]
Remove unused parameter documentation
Sam Reed [Tue, 30 Nov 2010 19:06:28 +0000 (19:06 +0000)]
Few braces and spaces
Fixing up documentation
Sam Reed [Tue, 30 Nov 2010 18:55:03 +0000 (18:55 +0000)]
Qualify call to autoConvertToAllVariants from convertLinkToAllVariants in FakeConverter
Sam Reed [Tue, 30 Nov 2010 18:52:49 +0000 (18:52 +0000)]
qualify call to array_to_obj
Followup r70608
Sam Reed [Tue, 30 Nov 2010 18:50:07 +0000 (18:50 +0000)]
int() isn't a function
Sam Reed [Tue, 30 Nov 2010 18:44:50 +0000 (18:44 +0000)]
More unused variables
Sam Reed [Tue, 30 Nov 2010 18:37:56 +0000 (18:37 +0000)]
Assignment to $messages ($message = $this->escapeForScript($message);) seemed wrong
Roan Kattouw [Tue, 30 Nov 2010 18:37:08 +0000 (18:37 +0000)]
Fixes for r77451 per CR: add UploadStashZeroLengthFileException to AutoLoader and add $wgUploadStashScalerBaseUrl to DefaultSettings.php
Sam Reed [Tue, 30 Nov 2010 18:33:59 +0000 (18:33 +0000)]
Remove a couple of unused variables, add spaces, wrap some long lines
Sam Reed [Tue, 30 Nov 2010 18:29:08 +0000 (18:29 +0000)]
Switch + to . for string concat
Sam Reed [Tue, 30 Nov 2010 18:26:52 +0000 (18:26 +0000)]
More JS documentation fixups
Platonides [Tue, 30 Nov 2010 18:24:02 +0000 (18:24 +0000)]
Document a bit what's going on and get rid of a warning.
Platonides [Tue, 30 Nov 2010 18:21:55 +0000 (18:21 +0000)]
Replace addslashes with Database::addQuotes()
Sam Reed [Tue, 30 Nov 2010 18:19:27 +0000 (18:19 +0000)]
Start fixing up javascript function documentation
Switching order, renaming parameters in documentation
Sam Reed [Tue, 30 Nov 2010 18:18:48 +0000 (18:18 +0000)]
Fixup $gt
Neil Kandalgaonkar [Tue, 30 Nov 2010 05:43:26 +0000 (05:43 +0000)]
forgot to change the function signature after refactor here
Neil Kandalgaonkar [Tue, 30 Nov 2010 04:47:00 +0000 (04:47 +0000)]
matching returns
Neil Kandalgaonkar [Tue, 30 Nov 2010 04:40:34 +0000 (04:40 +0000)]
better error checking, fixed a few bugs with remote content scaling
Neil Kandalgaonkar [Tue, 30 Nov 2010 04:40:05 +0000 (04:40 +0000)]
removed debug statement
Philip Tzou [Tue, 30 Nov 2010 03:04:47 +0000 (03:04 +0000)]
Select a friendly sub-language while acquiring system messages if the uselang has multiple variants available for use.
Neil Kandalgaonkar [Tue, 30 Nov 2010 02:45:10 +0000 (02:45 +0000)]
Dual strategy thumbnailing -- locally for development and simpler wikis, or in the cluster for setups like the WMF's
When we did our test deploy, we found that we could not scale thumbnails locally in the cluster (and this was undesirable anyway).
So, we moved UploadStash thumbnailing to occur on URL invocation, which is more like the usual MediaWiki model anyway. So the customized transform()
moved from UploadStash to just being a special case of how SpecialUploadStash does things.
Note that the Special:UploadStash url masks how the thumbnail is obtained. Unlike the regular Commons wiki, the user never sees the cluster's URL for the thumbnail.
A web request, or an imageMagick call, is performed right there and then, and the results are catted out to the client.
For consistency, we did not use wfStreamfile since we were in some cases streaming from contents obtained over the MWhttpRequest, not just local files.
Trevor Parscal [Tue, 30 Nov 2010 01:40:22 +0000 (01:40 +0000)]
Added missing name setting when initializing modules from preloaded info.
Platonides [Mon, 29 Nov 2010 16:34:28 +0000 (16:34 +0000)]
Fix potential html injection when the database server isn't available (bug 26164).
Wikis which set $wgServer in their LocalSettings or are in a virtual
host would never be vulnerable.
For sites which show the wiki in the default host, it will depend on how
forgiving is their webserver and php stack for that garbled input, although
some kind of foolable proxy —moreover wrongly caching errors (or the default
output buffering is disabled and something incorrectly sent a previous text)—
would also need to be present in order to make that useful for a
potential attacker.
Sam Reed [Mon, 29 Nov 2010 00:41:56 +0000 (00:41 +0000)]
Followup r77393, restore commented variable in SpecialPrefixindex as the variable is mentioned in a fixme comment below
Sam Reed [Mon, 29 Nov 2010 00:32:24 +0000 (00:32 +0000)]
Minor followup to r77393, change =&Method() to = &Method()
Sam Reed [Mon, 29 Nov 2010 00:28:04 +0000 (00:28 +0000)]
Fix spaces to tabs from r77393
Sam Reed [Mon, 29 Nov 2010 00:26:40 +0000 (00:26 +0000)]
Revert global removals in test/ from r77393
Aryeh Gregor [Mon, 29 Nov 2010 00:11:19 +0000 (00:11 +0000)]
Give image <gallery>s fluid width
Bug 3276. Patch by DieBuche, with style cleanups by me, plus a tweak
from comment 27 of the bug to fix spacing. This incidentally removes
the border around galleries, but this was hard to notice anyway, and
could be easily readded if desired. Tested in a few browsers, including
IE6, but more testing and/or input from CSS gurus would be appreciated.
Updates parser tests, including for Cite.
Aryeh Gregor [Mon, 29 Nov 2010 00:10:59 +0000 (00:10 +0000)]
Revert r42257 "Convert literal tabs to 	 when passing them through Tidy, to prevent them from being clobbered."
This caused bug 16108, and also broke the patch to bug 3276. The commit
doesn't explain why it's useful or what it fixes, although Platonides
asked on Code Review in 2008, so that's two problems it's caused with no
benefits I've seen.
Platonides [Sun, 28 Nov 2010 22:51:25 +0000 (22:51 +0000)]
Follow up r77407. Do it Right.
Fixes wfTimestamp() returning 0 instead of now.
Platonides [Sun, 28 Nov 2010 22:44:14 +0000 (22:44 +0000)]
Use always DatabaseBase::timestampoOrNull for user_newpass_time field, as done in loadFromRow()/saveSettings()
-- línea y las que están debajo serán ignoradas--
M User.php
Platonides [Sun, 28 Nov 2010 22:40:29 +0000 (22:40 +0000)]
Fix bug introduced in r77171
Platonides [Sun, 28 Nov 2010 22:27:50 +0000 (22:27 +0000)]
Follow up r77401.
Mixture of null/false.
Happens to also fix the parsertests issue.
Platonides [Sun, 28 Nov 2010 21:59:16 +0000 (21:59 +0000)]
Fix bug discovered in r77171 from the user data in If-Modified-Since passed by resource loader.
Added in wfTimestamp reading support for the three http date formats.
Increased conformance reading rfc2822 dates (read support added in r71750/r71751). We may not want full compliance with rfc2822, though.
The only provider of rfc2822 dates is probably http and that uses a subset (it's rfc822 + 4-digit years from rfc1123).
Make wfTimestamp() return false in case of a wrong input, according to CR.
Raimond Spekking [Sun, 28 Nov 2010 20:45:25 +0000 (20:45 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-28 20:30:00 UTC)
Sam Reed [Sun, 28 Nov 2010 16:13:13 +0000 (16:13 +0000)]
Remove some unused variables and globals
Sam Reed [Sun, 28 Nov 2010 16:05:41 +0000 (16:05 +0000)]
ImagePage subclasses Article, therefore use parent::getContent()
Sam Reed [Sun, 28 Nov 2010 16:04:48 +0000 (16:04 +0000)]
Fix 1 deprecated method call in SpecialPage, and 3 non static methods called statically
Sam Reed [Sun, 28 Nov 2010 15:40:15 +0000 (15:40 +0000)]
Tweak some documentation
Andrew Garrett [Sun, 28 Nov 2010 03:21:16 +0000 (03:21 +0000)]
Remove isValidPassword check from User::checkPassword. It is hugely annoying to suddenly have the system decide that your password is not strong enough and decide that, as a consequence, you are not allowed to log in anymore. Password strength checking should only be there for changing passwords, not using them!
Roan Kattouw [Sat, 27 Nov 2010 22:39:56 +0000 (22:39 +0000)]
Fix bug in load balancer: filter out non-replicating slaves (or slaves otherwise not reporting their lag) even if no max lag is specified
Roan Kattouw [Sat, 27 Nov 2010 22:36:05 +0000 (22:36 +0000)]
Fix typo in LoadBalancer.php
Raimond Spekking [Sat, 27 Nov 2010 22:30:05 +0000 (22:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-27 22:16:00 UTC)
Bryan Tong Minh [Sat, 27 Nov 2010 19:24:48 +0000 (19:24 +0000)]
(bug 10268) Added linktodiffs parameter on action=feedwatchlist
Antoine Musso [Sat, 27 Nov 2010 19:01:51 +0000 (19:01 +0000)]
Stylize. No differences when using: svn diff -x -wu
Bryan Tong Minh [Sat, 27 Nov 2010 18:51:17 +0000 (18:51 +0000)]
(bug 26125) prop=imageinfo&iiprop=size now returns the page count if the file is a multi-page file
Also fix blatant lie in File::pageCount()
Sam Reed [Sat, 27 Nov 2010 15:35:57 +0000 (15:35 +0000)]
Revert r77358, didn't have intended affect, and broke unittests
Sam Reed [Sat, 27 Nov 2010 15:25:57 +0000 (15:25 +0000)]
Create instance of Maintenance class after AutoLoader and Defines
Reason: We might want to use class stuff in the Maintenance constructor (re r77355)
Victor Vasiliev [Sat, 27 Nov 2010 14:55:54 +0000 (14:55 +0000)]
Fix r77309 per CR: use appropriate function in ResourceLoaderWikiModule to check the validity of CSS user subpage.
Sam Reed [Sat, 27 Nov 2010 14:18:54 +0000 (14:18 +0000)]
$options doesn't exist in PurgeList
Change to getOptions, and addOption in Constructor
Antoine Musso [Sat, 27 Nov 2010 11:29:23 +0000 (11:29 +0000)]
Test normalizeForSearch and commafy
See bug 23156 and r64981
Raimond Spekking [Fri, 26 Nov 2010 21:52:21 +0000 (21:52 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-26 21:27:00 UTC)
Platonides [Fri, 26 Nov 2010 19:16:28 +0000 (19:16 +0000)]
Fix per r76545 CR.
Platonides [Fri, 26 Nov 2010 15:47:51 +0000 (15:47 +0000)]
Follow up r77171
Sam Reed [Fri, 26 Nov 2010 12:06:50 +0000 (12:06 +0000)]
Set blank $fname
Philip Tzou [Fri, 26 Nov 2010 07:48:41 +0000 (07:48 +0000)]
Add a new method 'spamPageWithContent' to class EditPage. User can be allowed to view his/her diff and submitted text when hit the spam-filter. The changes to extension SpamBlacklist will be followed up soon.
Antoine Musso [Fri, 26 Nov 2010 07:45:12 +0000 (07:45 +0000)]
doc comments: fix grammar and return parameter. fu r77296
Mark A. Hershberger [Fri, 26 Nov 2010 02:37:28 +0000 (02:37 +0000)]
revert r77271 since it was an expensive fix to a non-existant problem.
Mark A. Hershberger [Fri, 26 Nov 2010 01:16:52 +0000 (01:16 +0000)]
follow r77243 and r77315 which claimed to fix, but didn't -- fix the unit test was that accidently hide the bug
Mark A. Hershberger [Fri, 26 Nov 2010 00:21:36 +0000 (00:21 +0000)]
follow r77243 -- unit test was coded to hide the bug... doh! fix it up
Victor Vasiliev [Thu, 25 Nov 2010 23:12:05 +0000 (23:12 +0000)]
* Show "skin does not exist error" only when the skin is inputted in the wrong case. This seems to be the original intention. Otherwise it renders the warning on the completely legitimate subpages with user scripts.
* Deprecate isValidUserCssJSSubpage() as having a very confusing title. User scripts *are* valid user JS subpages.
Sam Reed [Thu, 25 Nov 2010 22:24:28 +0000 (22:24 +0000)]
More reversion of r77297, 2 of 2 commits to keep it readable in CR (hopefully)
Sam Reed [Thu, 25 Nov 2010 22:24:11 +0000 (22:24 +0000)]
More reversion of r77297, 1 of 2 commits to keep it readable in CR (hopefully)
Sam Reed [Thu, 25 Nov 2010 22:22:53 +0000 (22:22 +0000)]
Revert r77297, Won't be reverting MimeMagic
Mainly whitespace reverts here
Raimond Spekking [Thu, 25 Nov 2010 20:06:18 +0000 (20:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-25 19:50:00 UTC)
Antoine Musso [Thu, 25 Nov 2010 20:01:34 +0000 (20:01 +0000)]
revert r76464
* mixed style changes and variable removing
* logic changes
* useful comments removed
Antoine Musso [Thu, 25 Nov 2010 19:47:24 +0000 (19:47 +0000)]
consistent incr() return value in case of error. follow up 74579
Roan Kattouw [Thu, 25 Nov 2010 15:12:04 +0000 (15:12 +0000)]
Fix indentation in Block::infinity()
Roan Kattouw [Thu, 25 Nov 2010 12:34:21 +0000 (12:34 +0000)]
Fix r77261 by adding the parentheses already added in 1.16wmf4 in r77264
Alexandre Emsenhuber [Thu, 25 Nov 2010 09:38:04 +0000 (09:38 +0000)]
Fix for r77231: correct variable name, was throwing fatal errors
Raimond Spekking [Thu, 25 Nov 2010 08:25:12 +0000 (08:25 +0000)]
Remove redundant link 'Existing blocks for $1' because the blog log is shown since r16287
And in case the user is already blocked the message "$1 is already blocked. Do you want to change the settings?" is shown
Mark A. Hershberger [Thu, 25 Nov 2010 07:39:51 +0000 (07:39 +0000)]
Give SQLite a translation for MySQL's UNIX_TIMESTAMP() functions. Pg will probably need something similar.
Roan Kattouw [Wed, 24 Nov 2010 22:50:46 +0000 (22:50 +0000)]
Fix strange bug in ImageMagick call: if $params['comment'] was set to '' (which is explicitly done by the code in certain cases), the command line will contain -set comment -depth 8, causing the comment to be set to '-depth' and the file '8' to be read. Fix this by not adding the -set comment part at all if the comment is empty
Raimond Spekking [Wed, 24 Nov 2010 21:26:50 +0000 (21:26 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-24 21:05:00 UTC)
Mark A. Hershberger [Wed, 24 Nov 2010 19:52:59 +0000 (19:52 +0000)]
followup r65504 — actually check that we hav errors before returnning from checkUserBlock when short circuited.
Neil Kandalgaonkar [Wed, 24 Nov 2010 19:05:32 +0000 (19:05 +0000)]
more debug log messages for errors which have to be cryptic (we don't want people knowing paths on the server)
Neil Kandalgaonkar [Wed, 24 Nov 2010 18:59:16 +0000 (18:59 +0000)]
generate debug messages, trying to fix a problem on testwiki
Alexandre Emsenhuber [Wed, 24 Nov 2010 15:40:25 +0000 (15:40 +0000)]
Moved switches in Special:Unusedimages and Special:Ancientpages to extract a unix timestamp from a fielf to DatabaseBase and related classes to avoid code duplication
Alexandre Emsenhuber [Wed, 24 Nov 2010 12:24:14 +0000 (12:24 +0000)]
$wgJQuery* variables were removed with the merge of the resource loader
Alexandre Emsenhuber [Wed, 24 Nov 2010 11:45:01 +0000 (11:45 +0000)]
WikiImport no longer returns a WikiError since the rewrite to use XmlReader
Sam Reed [Tue, 23 Nov 2010 23:58:57 +0000 (23:58 +0000)]
Spaces to tab, add a couple of braces
Sam Reed [Tue, 23 Nov 2010 23:53:49 +0000 (23:53 +0000)]
* Sysops now have the "suppressredirect" right by default
Platonides [Tue, 23 Nov 2010 23:30:49 +0000 (23:30 +0000)]
Release notes for r77171, which was slightly based on t.glaser
patch at http://bug-attachment.wikimedia.org/attachment.cgi?id=7736
Alexandre Emsenhuber [Tue, 23 Nov 2010 22:42:24 +0000 (22:42 +0000)]
WikiImport no longer returns a WikiError since the rewrite to use XmlReader
Bryan Tong Minh [Tue, 23 Nov 2010 22:05:27 +0000 (22:05 +0000)]
(bug 25174) Add equal sign to boolean parameters in examples, so that the examples work immediately when posted
Sam Reed [Tue, 23 Nov 2010 21:43:56 +0000 (21:43 +0000)]
Explicit variable definition, tweak documentation
Sam Reed [Tue, 23 Nov 2010 21:37:27 +0000 (21:37 +0000)]
* (bug 26089) add block expiration to blockinfo
Antoine Musso [Tue, 23 Nov 2010 20:39:04 +0000 (20:39 +0000)]
dieout() now default to empty text. follow up r76165
Raimond Spekking [Tue, 23 Nov 2010 20:20:45 +0000 (20:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-11-22 20:11:00 UTC)
Sam Reed [Tue, 23 Nov 2010 19:57:04 +0000 (19:57 +0000)]
testRegisteringNullModuleThrowsAnException - $this->markTestIncomplete( "Broken by r77011" );
Just to shut codurr up
Ilmari Karonen [Tue, 23 Nov 2010 19:26:36 +0000 (19:26 +0000)]
bug 9675: sitemap-index doesn't include full location path
Platonides [Tue, 23 Nov 2010 18:25:00 +0000 (18:25 +0000)]
Bug 25451: time and date calculation in 32-bit
Follow up r75761. Now calculation is right (passes all tests)
on php 32 bits when using PHP >= 5.2
without prejudice to PHP 32/64 bits < 5.2 on the 32 bit range
(regardless of architecture)
Chad Horohoe [Tue, 23 Nov 2010 16:11:28 +0000 (16:11 +0000)]
rm unused and (seemingly) broken factory function
Chad Horohoe [Tue, 23 Nov 2010 16:01:09 +0000 (16:01 +0000)]
(bug 26068) Document $wgUseETag better
Max Semenik [Tue, 23 Nov 2010 14:30:01 +0000 (14:30 +0000)]
Fixed another wrong function name
Max Semenik [Tue, 23 Nov 2010 14:08:46 +0000 (14:08 +0000)]
Fix PHP 5.2 compatibility for r77144