Chad Horohoe [Tue, 7 Sep 2010 11:37:37 +0000 (11:37 +0000)]
Partial revert r72527, unrelated/unfinished changes
Chad Horohoe [Tue, 7 Sep 2010 11:34:34 +0000 (11:34 +0000)]
Comment fix
Tim Starling [Tue, 7 Sep 2010 10:38:19 +0000 (10:38 +0000)]
Fixes for r72024:
* Renamed MediaHandler::verifyFileHook() to verifyUpload() since it isn't a hook and the fact that it operates on files is obvious.
* Separated some concerns by simply passing verifyUpload() function a file path instead of an UploadBase object and MIME type. This simplifies the implementation of subclasses, makes the function accessible to non-UploadBase callers, and avoids breaking the interface constantly due to UploadBase changes.
* Have verifyUpload() return a Status object instead of allowing the idiosyncratic and feature-poor error array convention from UploadBase to infect MediaHandler.
The required update to PagedTiffHandler will be in a subsequent commit.
Raimond Spekking [Mon, 6 Sep 2010 19:28:27 +0000 (19:28 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-0^6 19:05:00 UTC)
Andrew Garrett [Mon, 6 Sep 2010 12:11:57 +0000 (12:11 +0000)]
Rewrite User::getSkin, broken in r49493 because requesting the skin for a particular title had the side-effect of changing the title associated with the stored Skin object, causing weirdness like the wrong namespace tabs.
Bryan Tong Minh [Mon, 6 Sep 2010 10:18:53 +0000 (10:18 +0000)]
Follow-up r70137: Made asynchronous upload working a bit more. It now fully works from the API; works still needs to be done for the normal UI. PHPUnit tests are updated and should cover most code paths that can be called from the API.
ApiUpload:
* Added "statuskey" parameter; this is the key that is returned by an async upload
* Refactored warnings transformation into its own function
* filename is no longer required on all uploads
UploadFromUrlJob:
* Moved upload results to its own entry in $_SESSION, instead of using the one from upload
* Fix storing in session by calling wfSetupSession and session_write_close where needed
Tests:
* Set $wgUser in ApiSetup, so that individual tests don't have to do this for themselves
* Added tests to cover most code paths from the API
* Fixed UploadFromUrlTestSuite so that its tests are included in a regular phpunit invocation (something strange with the AutoLoader; not sure what)
Other files:
* Allow passing session id to wfSetupSession
* Explicitly close the session before doing jobs, so that jobs can't manipulate the current session
Jens Frank [Sun, 5 Sep 2010 21:54:01 +0000 (21:54 +0000)]
Firefox interpretes links starting with // as if they would start with . If the wiki is installed in /, we get // as path
Aryeh Gregor [Sun, 5 Sep 2010 20:43:00 +0000 (20:43 +0000)]
Get rid of Language::usesFirstLettersInLists()
Added by me in r69810, but never used. It's not clear to me if it's
needed, but if so, it can be re-added later.
Raimond Spekking [Sun, 5 Sep 2010 19:25:47 +0000 (19:25 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-05 18:56:00 UTC)
Jack Phoenix [Sun, 5 Sep 2010 18:35:34 +0000 (18:35 +0000)]
coding style tweaks
Jack Phoenix [Sun, 5 Sep 2010 18:00:33 +0000 (18:00 +0000)]
trim trailing spaces
Aryeh Gregor [Sun, 5 Sep 2010 17:40:47 +0000 (17:40 +0000)]
Suggest running update.php on database error
This is a pretty frequently asked question in #mediawiki -- most
database errors are probably due to not running update.php.
Rotem Liss [Sun, 5 Sep 2010 14:42:05 +0000 (14:42 +0000)]
Localization update for he.
Alexandre Emsenhuber [Sun, 5 Sep 2010 13:31:34 +0000 (13:31 +0000)]
Fixed some doxygen warnings
Platonides [Sun, 5 Sep 2010 13:21:04 +0000 (13:21 +0000)]
(bug 24977) Remove the duplicate Access Key to compare selected revision in history
Bryan Tong Minh [Sun, 5 Sep 2010 13:16:23 +0000 (13:16 +0000)]
Made user global constants class constants so that autoloader magic can be used.
Alexandre Emsenhuber [Sun, 5 Sep 2010 13:15:48 +0000 (13:15 +0000)]
* Standardised file description headers
* added @file where needed
* added file description headers where needed
Alexandre Emsenhuber [Sun, 5 Sep 2010 10:02:59 +0000 (10:02 +0000)]
* added file description header
* added @ingroup Database
Platonides [Sat, 4 Sep 2010 22:25:59 +0000 (22:25 +0000)]
Remove usage of deprecated makeKnownLinkObj().
Added a parserTest for each call of the old makeKnownLinkObj (and checked that they pass now with linkKnown).
Platonides [Sat, 4 Sep 2010 21:44:50 +0000 (21:44 +0000)]
Fix parsertests after r72349.
Platonides [Sat, 4 Sep 2010 21:35:23 +0000 (21:35 +0000)]
Follow up r72394. Remove global line.
Platonides [Sat, 4 Sep 2010 21:33:49 +0000 (21:33 +0000)]
Move dumpInterwiki.inc over dumpInterwiki.php
Platonides [Sat, 4 Sep 2010 21:32:28 +0000 (21:32 +0000)]
Converting dumpInterwiki.php into new Maintenance. In two steps to get better diffs.
dumpInterwiki.inc is copied from rebuildInterwiki.inc + diverging changes.
Prepare rebuildInterwiki.php to use the specials db list like dumpInterwiki (r19198, bug 3529). We need to somewhere get where are they really hosted.
Max Semenik [Sat, 4 Sep 2010 19:54:39 +0000 (19:54 +0000)]
load.php5 support for r72349
Max Semenik [Sat, 4 Sep 2010 19:20:21 +0000 (19:20 +0000)]
Tweaked Rusyn language name per request on TWN
Platonides [Sat, 4 Sep 2010 19:15:42 +0000 (19:15 +0000)]
Port rebuildInterwiki to the new Maintenance system.
Platonides [Sat, 4 Sep 2010 18:46:18 +0000 (18:46 +0000)]
Follow up r36814. Make the deprecated function call the non-deprecated one instead of the other way around.
Platonides [Sat, 4 Sep 2010 18:31:37 +0000 (18:31 +0000)]
Make happy check-vars. This shows it that getQuery() returns an ApiQuery (more specifically, that getQuery() doesn't return an article)
Alexandre Emsenhuber [Sat, 4 Sep 2010 18:13:18 +0000 (18:13 +0000)]
* added file description headers
* changed a @ingroup Media to FileRepo
Platonides [Sat, 4 Sep 2010 15:09:08 +0000 (15:09 +0000)]
Follow-up r72340. Remove functions defined twice.
Alexandre Emsenhuber [Sat, 4 Sep 2010 15:08:02 +0000 (15:08 +0000)]
Fixed some doxygen warnings
Robin Pepermans [Sat, 4 Sep 2010 14:03:19 +0000 (14:03 +0000)]
Correcting "Remember my login on this computer" to "Remember my login in this browser" because it is browser-specific
Platonides [Sat, 4 Sep 2010 13:55:13 +0000 (13:55 +0000)]
(Bug 20697) - Decrease size (area) of remove.png and add.png for aesthetic reasons
Follows r56032.
Siebrand Mazeland [Sat, 4 Sep 2010 13:48:16 +0000 (13:48 +0000)]
More whitespace updates for files touched in r72342:
* stylize.php run
* code formatting updates
* updated a few comments
* added braces where not used
Platonides [Sat, 4 Sep 2010 13:45:14 +0000 (13:45 +0000)]
Use canonical class name.
Platonides [Sat, 4 Sep 2010 13:27:12 +0000 (13:27 +0000)]
Follow-up r72349.
Remove unused globals $wgStylePath, $wgStyleVersion, $wgUser and the no longer used $wgJQueryOnEveryPage.
Siebrand Mazeland [Sat, 4 Sep 2010 12:53:01 +0000 (12:53 +0000)]
Stylize files added in r72349
Platonides [Sat, 4 Sep 2010 11:51:11 +0000 (11:51 +0000)]
Force User.php include for EDIT_TOKEN_SUFFIX
Trevor Parscal [Sat, 4 Sep 2010 10:53:57 +0000 (10:53 +0000)]
Better solution for r72367, this allows file modules to always be written in ltr, while site modules are written in whatever $wgContLang is.
Trevor Parscal [Sat, 4 Sep 2010 10:28:41 +0000 (10:28 +0000)]
Only flip CSS if dir is different from $wgContLang
Trevor Parscal [Sat, 4 Sep 2010 10:24:23 +0000 (10:24 +0000)]
Allow flipping skin output on $wgLang rather than $wgContLang. Resource loader gracefully flips CSS for us, so this is finally an option.
Trevor Parscal [Sat, 4 Sep 2010 10:20:57 +0000 (10:20 +0000)]
Fixes bug introduced r71767 - the stripping of = from the right side of data URLs. Aparently this was misdiagnosed and Firefox was tollerant of it. By removing it, as suggested by Nikerabbit, images are working in Gecko and Webkit.
Trevor Parscal [Sat, 4 Sep 2010 10:13:06 +0000 (10:13 +0000)]
Removing remnants of merging mistakes. These files are way out of date and not in use.
Alexandre Emsenhuber [Sat, 4 Sep 2010 09:50:56 +0000 (09:50 +0000)]
And while I'm a it, moved $wgLivePasswordStrengthChecks with other similar settings
Trevor Parscal [Sat, 4 Sep 2010 09:44:01 +0000 (09:44 +0000)]
Temporarily disable data URL embedding by default until we figure out how to make this work reliably. At least Chrome and possibly Opera were having issues with data URLs.
Alexandre Emsenhuber [Sat, 4 Sep 2010 09:29:25 +0000 (09:29 +0000)]
Removed trailing spaces
Trevor Parscal [Sat, 4 Sep 2010 09:01:22 +0000 (09:01 +0000)]
Delete resources/mw directory, seems to be a remnant of a botched merge
Trevor Parscal [Sat, 4 Sep 2010 08:38:45 +0000 (08:38 +0000)]
Fix a bug in the resource loader causing it to return no Content-Type header for 304s. Firefox doesn't care but Chrome seems to, so we always set the right Content-Type
Trevor Parscal [Sat, 4 Sep 2010 07:54:55 +0000 (07:54 +0000)]
Followup to r72349: fix database error caused by update.php indirectly (via LocalisationCache::recache() and MessageBlobStore::clear()) trying to clear out the msg_resource table before it's even created it.
Alexandre Emsenhuber [Sat, 4 Sep 2010 06:46:50 +0000 (06:46 +0000)]
* simplified file description header or load.php
* and while I'm a it: svn:eol-style native (!)
Trevor Parscal [Sat, 4 Sep 2010 06:25:42 +0000 (06:25 +0000)]
Fixed server path being built wrongly, appending load.php. This was masked by PHP's path info. Fixes issue in r72349.
Alexandre Emsenhuber [Sat, 4 Sep 2010 06:17:07 +0000 (06:17 +0000)]
* added @file
* whitespaces fixes
* double quotes to simple quotes where possible
Raimond Spekking [Sat, 4 Sep 2010 06:08:21 +0000 (06:08 +0000)]
Follow-up r72340: Special page and its user rights have gone
Raimond Spekking [Sat, 4 Sep 2010 05:53:45 +0000 (05:53 +0000)]
Follow-up r72340: Special page has gone
OverlordQ [Sat, 4 Sep 2010 04:14:51 +0000 (04:14 +0000)]
Followup to r72349, PG table def + updater for module_deps
OverlordQ [Sat, 4 Sep 2010 04:10:23 +0000 (04:10 +0000)]
Followup to r72349, PG tables + updater
Roan Kattouw [Sat, 4 Sep 2010 04:00:09 +0000 (04:00 +0000)]
Merging resourceloader branch into trunk. Full documentation is at mediawiki.org/wiki/ResourceLoader and a general overview has been posted on wikitech-li <http://lists.wikimedia.org/pipermail/wikitech-l/2010-September/049253.html>. One important change is that all JS is now loaded at the bottom, so any scripts assuming things from wikibits or whatever are present will fail.
Sam Reed [Sat, 4 Sep 2010 03:43:33 +0000 (03:43 +0000)]
Braces and spaces
Mark A. Hershberger [Sat, 4 Sep 2010 01:06:34 +0000 (01:06 +0000)]
w/s changes
Mark A. Hershberger [Sat, 4 Sep 2010 01:02:56 +0000 (01:02 +0000)]
Add changes that I missed in r72340
Mark A. Hershberger [Sat, 4 Sep 2010 00:58:57 +0000 (00:58 +0000)]
* Remove $wg*Selenium* globals as they are only used for testing.
* mglaser said the SpecialSelenium page wasn't needed so I'm removing it – I suggest its functionality be put in an extension if needed.
* Add verbose option (requires patch to Testing_Selenium) to RunSeleniumTests.
* TODO: add .ini file to hold local configuration
* TODO: add ability to sniff available browsers from Grid server instead of hard-coding.
Mark A. Hershberger [Sat, 4 Sep 2010 00:18:01 +0000 (00:18 +0000)]
re r72335: forgot to include this 'global' keyword.
Conrad Irwin [Sat, 4 Sep 2010 00:03:45 +0000 (00:03 +0000)]
Bug 6204 - TOC not properly rendered when using $wgMaxTocLevel
Credit for mini-patch to Brandon Ooi
Mark A. Hershberger [Sat, 4 Sep 2010 00:01:30 +0000 (00:01 +0000)]
* add wfRunMaintenance() script to simplify maint script writing
* replace use of array_key_exists with isset()
* add helloWorld example to go with http://www.mediawiki.org/wiki/Manual:Writing_maintenance_scripts
Sam Reed [Fri, 3 Sep 2010 22:58:09 +0000 (22:58 +0000)]
Only display Examples section if it's got anything in the array
Platonides [Fri, 3 Sep 2010 22:10:07 +0000 (22:10 +0000)]
Follow-up r72319. Use linkKnown() and skip a few parameters.
Platonides [Fri, 3 Sep 2010 22:07:46 +0000 (22:07 +0000)]
Follow-up r65504. Use canonical class name.
Platonides [Fri, 3 Sep 2010 21:53:02 +0000 (21:53 +0000)]
Remove call to deprecated function Linker::makeKnownLink from function specialLink.
Raimond Spekking [Fri, 3 Sep 2010 21:48:42 +0000 (21:48 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-09-03 21:31:00 UTC)
Platonides [Fri, 3 Sep 2010 21:39:50 +0000 (21:39 +0000)]
Follow-up r70970. There's no StubUser any more, so no point in showing the wfDebug on each request.
OverlordQ [Fri, 3 Sep 2010 21:17:33 +0000 (21:17 +0000)]
Fix sequence renaming to be backwards-compat with older versions of PG. Needs merged with 1.16
Chad Horohoe [Fri, 3 Sep 2010 21:14:52 +0000 (21:14 +0000)]
Comment fix
Greg Sabino Mullane [Fri, 3 Sep 2010 21:08:16 +0000 (21:08 +0000)]
Bump cl_collation from smallint to a text
Aryeh Gregor [Fri, 3 Sep 2010 20:52:08 +0000 (20:52 +0000)]
Further categorylinks schema changes
Per review by Tim, I made two changes:
1) Fix cl_sortkey to be varbinary(255).
2) Expand cl_collation to varbinary(32), and change $wgCollationVersion
to $wgCategoryCollation, to account for the variety of collations we
might have. tinyint is too small. I could have gone with int, but
that's annoyingly inscrutable in practice, as we all know from namespace
fields.
To make the upgrade easier for non-trunk users, I updated the old patch
file to incorporate the new changes, using the updatelog table so that
people upgrading from 1.16 won't have to do two alters on categorylinks.
I didn't test the upgrade-from-1.16 code path yet, so if anyone tests
that and it seems not to break, commenting to that effect would be
appreciated.
Also removed wfDeprecated() from archive(). Do *not* add this to
functions that are still actively used in core. If you think this
function is so terrible that it really mustn't be used, remove callers
yourself, don't pester every single developer with messages in the hope
that someone else will do it for you.
Chad Horohoe [Fri, 3 Sep 2010 19:40:01 +0000 (19:40 +0000)]
Address comment on r63710, rm unused paramters
Alexandre Emsenhuber [Fri, 3 Sep 2010 18:53:19 +0000 (18:53 +0000)]
Moved OracleUpdater to its own file so that I can stop asking me why this file is missing
Alexandre Emsenhuber [Fri, 3 Sep 2010 18:24:42 +0000 (18:24 +0000)]
added file description header
Sam Reed [Fri, 3 Sep 2010 16:00:58 +0000 (16:00 +0000)]
Followup r72238, remove &
Sam Reed [Fri, 3 Sep 2010 15:53:08 +0000 (15:53 +0000)]
Followup r72234, pass $this->mConn instead of null
Chad Horohoe [Fri, 3 Sep 2010 14:24:40 +0000 (14:24 +0000)]
Followup r72108, put the history file in $IP/maintenance rather than the cwd. Also add it to svnignore.
Platonides [Fri, 3 Sep 2010 14:04:50 +0000 (14:04 +0000)]
Follow up r72164. The list was still there.
Platonides [Fri, 3 Sep 2010 14:00:01 +0000 (14:00 +0000)]
Follow up r72202 rename of Message::key() to wfMessage()
Sam Reed [Fri, 3 Sep 2010 01:06:06 +0000 (01:06 +0000)]
Widen header documentation
Priyanka Dhanda [Fri, 3 Sep 2010 00:57:56 +0000 (00:57 +0000)]
Fixing bad cpmmand to make phpunit work r72250
Trevor Parscal [Fri, 3 Sep 2010 00:48:22 +0000 (00:48 +0000)]
Actually does what r72249 claimed to do.
Trevor Parscal [Fri, 3 Sep 2010 00:41:52 +0000 (00:41 +0000)]
Fixed PHPUnit < 3.5 compatibiliy breaking change r72248, now we automatically use the new/old way by checking for 'PHPUnit/Autoload.php'.
Trevor Parscal [Fri, 3 Sep 2010 00:31:52 +0000 (00:31 +0000)]
Using PHPUnit/Autoload.php instead of trying to include everything by hand all the time.
Sam Reed [Thu, 2 Sep 2010 23:43:14 +0000 (23:43 +0000)]
Partial revert of r72240
Sam Reed [Thu, 2 Sep 2010 23:37:15 +0000 (23:37 +0000)]
Align URL's
Sam Reed [Thu, 2 Sep 2010 23:12:47 +0000 (23:12 +0000)]
Remove unused global
Simplify some logic
Sam Reed [Thu, 2 Sep 2010 22:20:00 +0000 (22:20 +0000)]
Comment out some unused array declarations
Move some comments
Sam Reed [Thu, 2 Sep 2010 22:15:20 +0000 (22:15 +0000)]
Add some $retval = '' before some wfShellExec
Sam Reed [Thu, 2 Sep 2010 22:11:32 +0000 (22:11 +0000)]
$file->group to $this->group
Sam Reed [Thu, 2 Sep 2010 22:08:09 +0000 (22:08 +0000)]
$result = '' in Title->checkPermissionHooks
Fixup $session in ApiWatchTest
Jack Phoenix [Thu, 2 Sep 2010 21:56:14 +0000 (21:56 +0000)]
coding style tweaks
Sam Reed [Thu, 2 Sep 2010 21:54:53 +0000 (21:54 +0000)]
Fixup some method calls with missing parameters
Jack Phoenix [Thu, 2 Sep 2010 21:43:04 +0000 (21:43 +0000)]
trim trailing whitespace
Sam Reed [Thu, 2 Sep 2010 21:38:45 +0000 (21:38 +0000)]
Followup r72207, uc isn't static
Sam Reed [Thu, 2 Sep 2010 20:52:01 +0000 (20:52 +0000)]
Per r72181, refactor isInCategory into ArticleAssessmentPilot
Sam Reed [Thu, 2 Sep 2010 20:48:02 +0000 (20:48 +0000)]
Simplify some returns, remove some whitespace
Indent on a switch