Paul Copperman [Wed, 4 May 2011 11:50:34 +0000 (11:50 +0000)]
Remove references from function parameters in Wiki.php. They aren't needed for objects and sometimes cause warnings when called with non-vars.
Paul Copperman [Wed, 4 May 2011 11:48:47 +0000 (11:48 +0000)]
Follow-up r87266: Fix parser test
Paul Copperman [Wed, 4 May 2011 11:46:28 +0000 (11:46 +0000)]
Follow-up r87210: Add MediaWikiLangTestCase to the autoloader and make the class abstract.
Daniel Friesen [Wed, 4 May 2011 10:43:40 +0000 (10:43 +0000)]
Drop the $out params I added before I added context to Skin, as well deprecate some of the $out params in other methods.
Jure Kajzer [Wed, 4 May 2011 10:43:34 +0000 (10:43 +0000)]
* fixed tableName handling for internal purposes (bug if using sharedDB as i need raw table name)
Tim Starling [Wed, 4 May 2011 02:09:16 +0000 (02:09 +0000)]
Some release notes updates:
* Removed the obsolete part about continuous integration models. I already removed it in the 1.16 branch and will shortly remove it from the 1.17 branch.
* Updated the information about supported databases.
* Removed the part about XHTML support since we target HTML 5 now.
* Say what mediawiki-l is instead of saying what it isn't.
Daniel Friesen [Wed, 4 May 2011 01:53:05 +0000 (01:53 +0000)]
Add proper $out setting to Skin::getCategories which is present in the other similar methods. Replaces r87380.
Chad Horohoe [Wed, 4 May 2011 01:43:03 +0000 (01:43 +0000)]
Add hack to shut up fatals when getCategories() is called without an actual OutputPage
Platonides [Tue, 3 May 2011 22:37:14 +0000 (22:37 +0000)]
Follow up r87210
Platonides [Tue, 3 May 2011 22:15:57 +0000 (22:15 +0000)]
Remove unused global
Platonides [Tue, 3 May 2011 22:14:52 +0000 (22:14 +0000)]
Use canonical case
Krinkle [Tue, 3 May 2011 21:57:33 +0000 (21:57 +0000)]
mw.util.test fixes
* Remove hiding of rows after the test, in almost all cases someone will want to unhide these, especially in case of an error; Plus, there were some inconsistencies in firefox with the hovering of the last (non-collapsible) row.
* Changing mw.util.addCSS to a style that is actually visible on the action=mwutiltest page.
* Making the entire row red in case of errors (easier finding of the error)
* Moving $.isDomElement tests to mw.util.test instead of in comments
* Adding missing tests for all mw.util properties
* Fix bug where $.isDomElement fails if the passed argument isn't an object at all (eg. null or undefined). Check variable first before checking object property (<code>$.isDomElement( document.getElementById('notexist') );</code> returned TypeError: Result of expression 'el' [null] is not an object.)
** Adding test for this
* Try/Catch the evaluation
** Reports catched exceptions through mw.log instead of using throw. This way non-consoled browsers can be easily debugged through mw.log's console.
** Fixes: (bug 28803) mw.util.test doesn't handle exceptions
* Using a canonical variable instead of a localized one in the tests.
** Fixes: (bug 28788) 2 tests related to wgTitle in mediawiki.util.test are broken for non-English wikis.
Leo Koppelkamm [Tue, 3 May 2011 21:26:30 +0000 (21:26 +0000)]
r87345: Restore black link color
Chad Horohoe [Tue, 3 May 2011 21:08:44 +0000 (21:08 +0000)]
(bug 19408) user_properties.up_property: 32 bytes is not enough.
Increased it to 255 bytes to be like page titles
Some minor tweaks to modifyField() in the installer to make it more useful and added insertUpdateRow()
Raimond Spekking [Tue, 3 May 2011 20:29:05 +0000 (20:29 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-02 20:13:00 UTC)
Russ Nelson [Tue, 3 May 2011 19:55:49 +0000 (19:55 +0000)]
Only one extension was using getThumbnail
Platonides [Tue, 3 May 2011 19:53:13 +0000 (19:53 +0000)]
Follow up r87220. r86795 tests are now embedded into PreprocessorTest.php
Chad Horohoe [Tue, 3 May 2011 19:49:20 +0000 (19:49 +0000)]
(bug 22227) Special:Listfiles no longer throws an error on bogus file entries
Platonides [Tue, 3 May 2011 19:48:50 +0000 (19:48 +0000)]
We can't check if it's a parentNode->type == name_node so early, since
it may be just a single } and end up being a literal.
Leo Koppelkamm [Tue, 3 May 2011 19:11:23 +0000 (19:11 +0000)]
Revert r86473 and redo more cleanly. Fix black link color complained about in Bug 28690
Alexandre Emsenhuber [Tue, 3 May 2011 17:23:17 +0000 (17:23 +0000)]
Moved "printfooter" and debug HTML away from "bodytext" so that they can be easily modified by extensions with the SkinTemplateOutputPageBeforeExec hook; always moved generation of debug HTML just before executing the hook so that it includes more items
Mark A. Hershberger [Tue, 3 May 2011 17:21:43 +0000 (17:21 +0000)]
Fixes bug #28694: Set maxlength of revisiondelete comment to 100.
Max Semenik [Tue, 3 May 2011 16:54:16 +0000 (16:54 +0000)]
Added a function that returns the list of supported formats to ApiMain
Paul Copperman [Tue, 3 May 2011 13:18:57 +0000 (13:18 +0000)]
Fix Bug 28354: Edit tab is shown as "view source" for blocked users, which breaks squid caching
* Skip user block checks for Title::quickUserCan(). This restores the behavior from 1.16 rsp. before r65504.
* Remove unnecessary check for "$short && count($errors)", this is already handled by getUserPermissionsErrorsInternal().
Leo Koppelkamm [Tue, 3 May 2011 11:44:35 +0000 (11:44 +0000)]
Tablesorter: Add a title attribute to sort arrows ( Bug 21453 )
Leo Koppelkamm [Tue, 3 May 2011 11:09:10 +0000 (11:09 +0000)]
Fix Bug 26315: White pixels around user-icon
Alexandre Emsenhuber [Tue, 3 May 2011 09:43:34 +0000 (09:43 +0000)]
Removed Skin::$usercss, always false, nothing sets this
Platonides [Mon, 2 May 2011 22:36:14 +0000 (22:36 +0000)]
Remove empty files left by r16526, r29128 and r83029
Raimond Spekking [Mon, 2 May 2011 21:56:28 +0000 (21:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-02 21:42:00 UTC)
Sam Reed [Mon, 2 May 2011 21:38:48 +0000 (21:38 +0000)]
Kill & from r87290
Sam Reed [Mon, 2 May 2011 20:29:44 +0000 (20:29 +0000)]
* (bug 20468) User::invalidateCache throws 1205: Lock wait timeout exceeded
Severly limit the number of calls that actually update the database (for no gain!). Leaving stuff that needs to update memcached
Still, there's probably quite a lot of these calls which are still superfluous
Sam Reed [Mon, 2 May 2011 20:14:17 +0000 (20:14 +0000)]
Add makeInsertOptions
Allow Sqlite to OR IGNORE on UPDATE or INSERT
Leo Koppelkamm [Mon, 2 May 2011 19:56:28 +0000 (19:56 +0000)]
Switching arrows in Special:FileList to match the usual behaviour in MW. Bug 18962
Chad Horohoe [Mon, 2 May 2011 18:54:31 +0000 (18:54 +0000)]
(bug 28375) When using existing DB user, grants aren't added to new tables
Russ Nelson [Mon, 2 May 2011 18:48:35 +0000 (18:48 +0000)]
Fix and add some comments.
Rotem Liss [Mon, 2 May 2011 18:35:17 +0000 (18:35 +0000)]
Localization fix for he.
Rotem Liss [Mon, 2 May 2011 18:33:13 +0000 (18:33 +0000)]
Localization fixes for he, and updating links in en.
Happy-melon [Mon, 2 May 2011 18:31:42 +0000 (18:31 +0000)]
Follow-up r83795: fix E_NOTICE due to undefined array member.
Leo Koppelkamm [Mon, 2 May 2011 18:00:09 +0000 (18:00 +0000)]
Adjust maxwidth calculation for galleries. Bug 27577
Roan Kattouw [Mon, 2 May 2011 17:57:24 +0000 (17:57 +0000)]
Fix r87203: don't use a for..in loop on an array
Alexandre Emsenhuber [Mon, 2 May 2011 17:39:29 +0000 (17:39 +0000)]
Typo Typo Typo
Sam Reed [Mon, 2 May 2011 17:32:42 +0000 (17:32 +0000)]
A few minor RSD changes
Alexandre Emsenhuber [Mon, 2 May 2011 17:30:17 +0000 (17:30 +0000)]
* Removed Skin::reallyGenerateUserStylesheet() nothing uses it and nothing overrides it
* Corrected Skin::generateUserJs() and Skin::generateUserStylesheet()'s comments: nothing override them anymore, also marked them as deprecated, only usage is action=raw&gen=(css|js)
Sam Reed [Mon, 2 May 2011 16:58:29 +0000 (16:58 +0000)]
Documentation
Chad Horohoe [Mon, 2 May 2011 16:40:44 +0000 (16:40 +0000)]
Followup r87253, doc tweak for trunk (this is in 1.17 rel-notes now)
Alexandre Emsenhuber [Mon, 2 May 2011 15:32:20 +0000 (15:32 +0000)]
Moved Skin::$mWatchLinkNum to SkinLegacy since it's only used there and made it protected per documentation (nothing else apart SkinLegacy uses it)
Alexandre Emsenhuber [Mon, 2 May 2011 15:26:19 +0000 (15:26 +0000)]
Get the revision ID from the OutputPage object instead of making a copy
Leo Koppelkamm [Mon, 2 May 2011 11:55:45 +0000 (11:55 +0000)]
Tablesorter: use mw.config.get() to access globals; force mdy for english contentlang
Leo Koppelkamm [Mon, 2 May 2011 11:31:45 +0000 (11:31 +0000)]
Make jquery.tablesorter more resilient by checking multiple cells before assuming a type. Fixes Bug 28775
Sam Reed [Mon, 2 May 2011 11:12:48 +0000 (11:12 +0000)]
Followup r87225
Best to rename everything when you rename something
Brian Wolff [Mon, 2 May 2011 07:42:14 +0000 (07:42 +0000)]
Follow up r86363 - Missing a dollar sign.
Fixes the: Notice: Use of undefined constant i - assumed 'i' in /var/www/w/phase3/includes/db/LoadBalancer.php on line 745
Sam Reed [Sun, 1 May 2011 23:59:41 +0000 (23:59 +0000)]
Make a method static per the comment, update the only non static usage (in Parser) itself
Sam Reed [Sun, 1 May 2011 23:54:41 +0000 (23:54 +0000)]
Documentation tweaks, additions and updates
Platonides [Sun, 1 May 2011 23:02:27 +0000 (23:02 +0000)]
Follow up r87210
Sam Reed [Sun, 1 May 2011 22:11:05 +0000 (22:11 +0000)]
* (bug 28265) allow outputting of comments for action=expandtemplates
Sam Reed [Sun, 1 May 2011 21:56:02 +0000 (21:56 +0000)]
* (bug 27185) API: Add Special:ComparePages
Chad Horohoe [Sun, 1 May 2011 21:48:15 +0000 (21:48 +0000)]
When we failed to detect a DB driver, put the help info in the failure box, rather than hiding it in a little help box nobody's going to find
Platonides [Sun, 1 May 2011 21:33:16 +0000 (21:33 +0000)]
Convert r86795 tests into a dataProvider
Sam Reed [Sun, 1 May 2011 21:28:00 +0000 (21:28 +0000)]
Refactor out common code
Max Semenik [Sun, 1 May 2011 21:19:40 +0000 (21:19 +0000)]
Use HTML5 for formatted API output
Chad Horohoe [Sun, 1 May 2011 21:14:32 +0000 (21:14 +0000)]
(bug 28343) Kill unused contextlines/contextchars
Raimond Spekking [Sun, 1 May 2011 20:17:55 +0000 (20:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-01 20:01:00 UTC)
Krinkle [Sun, 1 May 2011 19:46:09 +0000 (19:46 +0000)]
Added wgIsMainPage (Title->isMainPage) to mw.config
* Instead of ugly javascript construction to compare href-attributes or re-constructing proper pagenames, let's use Title->isMainPage which does this much better
* Kept function for compatibility. mw.util.isMainPage() was never released, should probably be removed before 1.18 branch point.
Platonides [Sun, 1 May 2011 19:32:49 +0000 (19:32 +0000)]
Fix the old XmlTest.php test bug in the dateMenu() when the wiki is configured for a languange other than English
Other tests were running before and messing with the Language objects.
Platonides [Sun, 1 May 2011 19:31:18 +0000 (19:31 +0000)]
Cosmetic change
Krinkle [Sun, 1 May 2011 19:20:31 +0000 (19:20 +0000)]
(bug 27916) Don't prefix wgServer in mw.util.wikiGetlink
The check is not needed, if wgArticlePath is undefined there's probably a much bigger issue.
The wgServer doesn't need to be prefixed to the link (if someone really needs it (ie. external tools using the script and somehow defining wgServer in mw.config) they can surely prefix wgServer themselfs.
In most if not all cases this is used to create anchor tags, which are interprated by browsers relatively to the current window location and in some browsers it even auto-prefixes the current environment when setting the href/src attribute.
I did a grep search for "wikiGetlink" in /trunk (including ./extensions), there was one usage that assumed the wgServer prefix. Turned out that was actually a workaround untill this bug was fixed. I remove that workaround ( in mw.util.isMainPage).
Roan Kattouw [Sun, 1 May 2011 18:41:42 +0000 (18:41 +0000)]
(bug 28738) Implement request splitting in mw.loader so ResourceLoader requests with query strings longer than a certain value are split up. The maximum query string length is configurable, and this behavior is disabled by default. It's needed in rare cases where there is a query string length or GET variable length limit in place that the wiki admin can't raise.
Sam Reed [Sun, 1 May 2011 11:20:14 +0000 (11:20 +0000)]
Remove unneeded manual quoting from r87180
Sam Reed [Sun, 1 May 2011 00:24:39 +0000 (00:24 +0000)]
* (bug 28225) Allow hiding of user groups in list=allusers
Yay, a LEFT OUTER JOIN
Sam Reed [Sun, 1 May 2011 00:17:39 +0000 (00:17 +0000)]
$db is already defined, don't use $this->getDB() again
Sam Reed [Sat, 30 Apr 2011 23:18:34 +0000 (23:18 +0000)]
Followup r85884
Fixup the APIs strange way of doing table aliases on a join....
Only used in very few places
Bryan Tong Minh [Sat, 30 Apr 2011 22:12:51 +0000 (22:12 +0000)]
Fix bug in Status::getItemXML
Bryan Tong Minh [Sat, 30 Apr 2011 21:35:09 +0000 (21:35 +0000)]
Add --include-files option to dumpBackup.php to include the uploaded files in the XML stream. Uses new backend features from r85911.
Raimond Spekking [Sat, 30 Apr 2011 21:21:47 +0000 (21:21 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-30 20:50:00 UTC)
Leo Koppelkamm [Sat, 30 Apr 2011 19:49:57 +0000 (19:49 +0000)]
Bug 27047: Nicer design for pre elements in Vector
Bryan Tong Minh [Sat, 30 Apr 2011 18:50:37 +0000 (18:50 +0000)]
(bug 28076) Thumbnail height limited to 360 pixels on Special:Listfiles
Sam Reed [Sat, 30 Apr 2011 16:52:28 +0000 (16:52 +0000)]
Followup r87150
Reuse SpecialVersions arrayToString (made it explicitly public!) in an array_amp for the formatting of arrays/objects (Yay for all the different ways we accept things ;P)
Sam Reed [Sat, 30 Apr 2011 16:38:59 +0000 (16:38 +0000)]
Followup r87147, let the formatters do teh escaping
Alexandre Emsenhuber [Sat, 30 Apr 2011 15:50:05 +0000 (15:50 +0000)]
Per Siebrand: fix typo in RELEASE-NOTES
Alexandre Emsenhuber [Sat, 30 Apr 2011 15:14:12 +0000 (15:14 +0000)]
I have no idea where that count() pass in r87165
Alexandre Emsenhuber [Sat, 30 Apr 2011 15:12:33 +0000 (15:12 +0000)]
Properly escape the ouput in action=credits (and in page footer), using wfMessage() to be able to replace some parameters before and some after
Alexandre Emsenhuber [Sat, 30 Apr 2011 14:08:12 +0000 (14:08 +0000)]
Recommit r87129 and follow-ups but with a fix for the bug Brion found (sorry)
Daniel Friesen [Sat, 30 Apr 2011 12:04:00 +0000 (12:04 +0000)]
Use a reversed magnify image for framed image thumbnails when on a RTL wiki.
Brion Vibber [Fri, 29 Apr 2011 23:57:28 +0000 (23:57 +0000)]
Revert r87129 "(bug 21196) Article::getContributors() no longer fail on PostgreSQL" -- breaks stuff under MySQL like this:
SkinTemplate::makeTalkUrlDetails given invalid pagename User:
Backtrace:
#0 /var/www/trunk/includes/SkinTemplate.php(691): SkinTemplate->makeTalkUrlDetails('User:')
#1 /var/www/trunk/includes/SkinTemplate.php(495): SkinTemplate->buildPersonalUrls(Object(OutputPage))
#2 /var/www/trunk/includes/OutputPage.php(1906): SkinTemplate->outputPage(Object(OutputPage))
#3 /var/www/trunk/includes/Wiki.php(402): OutputPage->output()
#4 /var/www/trunk/index.php(146): MediaWiki->finalCleanup()
#5 {main}
Seen trivially by going to login page while not logged in; some user check is failing and ending up with an improperly initialized object.
Sam Reed [Fri, 29 Apr 2011 23:34:37 +0000 (23:34 +0000)]
Tweak documentation
Add braces
Sam Reed [Fri, 29 Apr 2011 23:33:38 +0000 (23:33 +0000)]
* Get a list of all subscribed hooks, and those subscribers
Essentially what SpecialVersion will give you if wgSpecialVersionShowHooks is true
Sam Reed [Fri, 29 Apr 2011 23:02:10 +0000 (23:02 +0000)]
* (bug 27179) API: List of extension tags
* Get a list of function hooks through meta=siteinfo
Chad Horohoe [Fri, 29 Apr 2011 22:40:31 +0000 (22:40 +0000)]
Make this private since nothing outside here calls it
Chad Horohoe [Fri, 29 Apr 2011 22:40:12 +0000 (22:40 +0000)]
(bug 28752) XCache doesn't work in CLI mode
OverlordQ [Fri, 29 Apr 2011 22:38:30 +0000 (22:38 +0000)]
Fix group by for Special:MostLinkedTemplates
OverlordQ [Fri, 29 Apr 2011 22:27:34 +0000 (22:27 +0000)]
Followup to r85907, correctly quote table names.
Followup to r87129, add handling of arrayed GROUP BY/ORDER BY options to match core class so that this will indeed work.
Chad Horohoe [Fri, 29 Apr 2011 22:08:58 +0000 (22:08 +0000)]
Add cdb.php for inspecting cdb cache files. Format is stolen from mcc.php
Jeroen De Dauw [Fri, 29 Apr 2011 22:05:36 +0000 (22:05 +0000)]
small doc fix
Sam Reed [Fri, 29 Apr 2011 21:46:17 +0000 (21:46 +0000)]
Followup r87132, per Bryan, still return the "limit" to be the current users limit, but return high/low limit
Jeroen De Dauw [Fri, 29 Apr 2011 21:29:20 +0000 (21:29 +0000)]
added since tag for people that care about compat
Sam Reed [Fri, 29 Apr 2011 20:52:57 +0000 (20:52 +0000)]
* (bug 28238) paraminfo: output both limits for multi param
Raimond Spekking [Fri, 29 Apr 2011 20:09:54 +0000 (20:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-29 19:47:00 UTC)
Alexandre Emsenhuber [Fri, 29 Apr 2011 18:27:44 +0000 (18:27 +0000)]
* (bug 21196) Article::getContributors() no longer fail on PostgreSQL
Changed User::loadFromRow() to allow partial row (user_id, user_name, user_real_name can be set independently from other fields) userand removed User::$mDataLoaded, replaced by User::$mLoadedItems (marked as private) that can be an array with already loaded items or true when all data has been loaded. Changed GlobalFunctions.php and Database.php accordingly, no use of User::$mDataLoaded in extensions.
Sam Reed [Fri, 29 Apr 2011 17:51:50 +0000 (17:51 +0000)]
Followup r86800, add missing ()
Platonides [Fri, 29 Apr 2011 16:26:20 +0000 (16:26 +0000)]
The $wgLocalisationCacheConf was being overwritten by the default value.
Restores the ability to run databaseless tests broken by r86775