Happy-melon [Mon, 18 Apr 2011 21:25:06 +0000 (21:25 +0000)]
Cleanup in SpecialPage.php:
* Enforce private access for member variables suggested since at least 1.4. Didn't do $mName because grepping for "->mName" gave far too many results to check.
* Move the stuff related to redirects (getRedirect(), getRedirectQuery(), $mAllowedRedirectParams and $mAddedRedirectParams) to SpecialRedirectToSpecial and adjust callers
* Document stuff
* Mark getFile() as deprecated
* Group together getListed(), setListed() and listed() to draw attention to the fact that all three have been there since 1.6 and that we need to pick one and deprecate the other(s)
* add isIncludable() getter
* mark as deprecated and evil the mutators added in 1.6 for things which *really* shouldn't be mutating anywhere. AFAICT they're not actually used many places. Didn't deprecate including() as it's in wide use and it's legitimately set in SpecialPageFactory::executePath().
Happy-melon [Mon, 18 Apr 2011 21:07:30 +0000 (21:07 +0000)]
Warn that SpecialPage::execute() will be made abstract at some point in the future, which is the endpoint of getting rid of the define-special-pages-by-global-functions structure. Committing this separate to the other changes because it should be backported to 1.17.
Raimond Spekking [Mon, 18 Apr 2011 20:25:13 +0000 (20:25 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-18 19:57:00 UTC)
Happy-melon [Mon, 18 Apr 2011 19:44:52 +0000 (19:44 +0000)]
Follow-up r86255: getTitleFor() was not migrated.
Leo Koppelkamm [Mon, 18 Apr 2011 19:20:02 +0000 (19:20 +0000)]
r86088: Get rid of eval by implemting a MergeSort algorithm. It's a few ms slower on very large tables, but is stable-sorting in all browsers
Sam Reed [Mon, 18 Apr 2011 19:03:46 +0000 (19:03 +0000)]
Revert avars deprecation in r11308
Swap a couple of name() to getName()
Happy-melon [Mon, 18 Apr 2011 19:03:14 +0000 (19:03 +0000)]
(bug 28583) chase down and beat to death external calls of functions marked /*private*/, and make those declarations actually binding. Patch by yuvipanda.
Sam Reed [Mon, 18 Apr 2011 19:00:48 +0000 (19:00 +0000)]
Revert r86236
Alexandre Emsenhuber [Mon, 18 Apr 2011 17:59:32 +0000 (17:59 +0000)]
* (bug 28592) Wrong timestamp were displayed in old revisions
Alexandre Emsenhuber [Mon, 18 Apr 2011 17:51:16 +0000 (17:51 +0000)]
* Use $this->getTitle() instead of SpecialPage::getTitleFor( $this->name() )
* Fix whitespace issue
Sam Reed [Mon, 18 Apr 2011 17:39:07 +0000 (17:39 +0000)]
Update all core calls of SpecialPage->getName();
Max Semenik [Mon, 18 Apr 2011 17:28:35 +0000 (17:28 +0000)]
E_STRICT in DB2. Ping r85885.
Chad Horohoe [Mon, 18 Apr 2011 17:04:50 +0000 (17:04 +0000)]
Per CR on r78824 (#c12467): Some query pages are useless/redundant, since we already output them elsewhere in the API, so we shouldn't expose them.
Alexandre Emsenhuber [Mon, 18 Apr 2011 16:43:20 +0000 (16:43 +0000)]
* Use DatabaseBase::selectField() to build the query instead of throwing a raw query in DatabaseBase::query()
* Use MWNamespace::getContentNamespaces() instead of $wgContentNamespaces
Alexandre Emsenhuber [Mon, 18 Apr 2011 16:33:16 +0000 (16:33 +0000)]
Use MWNamespace::getContentNamespaces() instead of $wgContentNamespaces in case of misconfiguration of the latter
Sam Reed [Mon, 18 Apr 2011 14:02:13 +0000 (14:02 +0000)]
Followup rr86304
We need a title object for parsing, do one against the message key
Doesn't seem to be the best way, but it's the most applicable. If I abused $wgTitle, Chad would come and beat me too ;)
Sam Reed [Mon, 18 Apr 2011 13:53:24 +0000 (13:53 +0000)]
Followup r86304
Things won't just happily accept a ParserOutput object when they were getting strings before
Add missing calling parameter
Sam Reed [Mon, 18 Apr 2011 13:18:15 +0000 (13:18 +0000)]
Few more comment/whitespace issues from r86169
Sam Reed [Mon, 18 Apr 2011 13:08:20 +0000 (13:08 +0000)]
Few style/whitespace/comment issues from r86169
Sam Reed [Mon, 18 Apr 2011 12:59:50 +0000 (12:59 +0000)]
Replace $wgMessageCache with MessageCache::singleton()
Fix some tab/space issues
Follows up r86304
Leo Koppelkamm [Mon, 18 Apr 2011 12:54:28 +0000 (12:54 +0000)]
Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup
Sam Reed [Mon, 18 Apr 2011 12:43:53 +0000 (12:43 +0000)]
* (bug 28532) wfMsgExt() and wfMsgWikiHtml() use $wgOut->parse()
* (bug 16129) Transcluded special pages expose strip markers when they output parsed messages
Also adding some related documentation during my travels around the code
Sam Reed [Mon, 18 Apr 2011 12:00:20 +0000 (12:00 +0000)]
Revert unintended changes from r86302
Sam Reed [Mon, 18 Apr 2011 11:42:44 +0000 (11:42 +0000)]
* (bug 28586) YAML: strings that are the same as boolean literals
* (bug 28591) Update/replace/supplement spyc (YAML parsing library)
* YAML API output is now 1.2 compliant, using JSON as the formatter
YAML 1.2 spec is a JSON subset - "The primary objective of this revision is to bring YAML into compliance with JSON as an official subset. YAML 1.2 is compatible with 1.1 for most practical applications - this is a minor revision." [1] Per discussion with Tim, switch YAML to use the JSON formatter
Was originally going to delete the ApiFormatYaml per Tim, but class needed to keep nicer (and apparent) output in API help page
Hence made subclass ApiFormatJson, minimal method overriding
spyc.php deleted from libs
[1] http://www.yaml.org/spec/1.2/spec.html#id2803629
Siebrand Mazeland [Mon, 18 Apr 2011 11:32:25 +0000 (11:32 +0000)]
Update messages files for r86294: revert of r86186, r86187, r86227, r86276.
* also contains recent translations from http://translatewiki.net.
Leo Koppelkamm [Mon, 18 Apr 2011 09:35:14 +0000 (09:35 +0000)]
Followup to r85021: Fix changed ID name
Tim Starling [Mon, 18 Apr 2011 08:42:59 +0000 (08:42 +0000)]
(bug 28590) Temporary revert of r86186, r86187, r86227, r86276: caused instant breakage of Wikimedia websites via LocalisationUpdate due to the introduction of the recentchanges-summary message.
Happy-melon [Sun, 17 Apr 2011 23:42:22 +0000 (23:42 +0000)]
Tidy and reorganise the AutoLoader array, because its almost-alphabetical-but-not-quite status was annoying me inordinately... :D classes are now divided strictly by subfolder, the subfolders are in alphabetical order, and classes within each subfolder are strictly in alphabetical order.
Happy-melon [Sun, 17 Apr 2011 20:34:25 +0000 (20:34 +0000)]
Follow-up r86255: rm duplicated config list
Happy-melon [Sun, 17 Apr 2011 20:29:24 +0000 (20:29 +0000)]
Rename Special:Resetpass to Special:ChangePassword. "pass" is vague and unintuitive, "reset" is only half of the page's function, and I'd quite like "Special:ResetPassword" for a much cleaner implementation of the 'enter-something-to-be-sent-a-reset-email' interface for bug 28244, bug 13015, etc. Diff looks much worse than it is because I had to update 95 language files...
Raimond Spekking [Sun, 17 Apr 2011 19:56:58 +0000 (19:56 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-17 19:30:00 UTC)
Happy-melon [Sun, 17 Apr 2011 19:25:30 +0000 (19:25 +0000)]
Follow-up r85929: update MediaWiki::articleFromTitle() calls in extensions (and a few edgecases which were missed in core)
Alexandre Emsenhuber [Sun, 17 Apr 2011 14:14:52 +0000 (14:14 +0000)]
* Display the "blanknamespace" in user's language, as in all other places
* Don't transform it since this will be done by the addWikiMsg() call
Leo Koppelkamm [Sun, 17 Apr 2011 13:48:38 +0000 (13:48 +0000)]
Followup to r86202 per CR: Add href=# to trigger hand cursor
Roan Kattouw [Sun, 17 Apr 2011 12:41:29 +0000 (12:41 +0000)]
API: BREAKING CHANGE: (bug 28541) Output of binary ICU sortkeys is broken. Change sortkey fields in prop=categories and list=categorymembers to hexadecimal strings, that way we don't have any issues with scary binary stuff. Also change cmcontinue to take hex-encoded sortkeys and swap the order back to normal (previously sortkey was at the end because it could contain pipe characters, but that's not an issue with hex).
Happy-melon [Sun, 17 Apr 2011 11:31:11 +0000 (11:31 +0000)]
Refactor the factory/i18n/list/etc static methods from SpecialPage into their own class; there's no reason we need to be parsing them in every single SpecialPage subclass. Leave all the methods as stubs in SpecialPage.php; if we required PHP 5.3 they could be replaced by a a __callStatic() magic method, but that doesn't work on PHP 5.2.
Also make a few changes to the functions available. SpecialPageFactory::resolveAlias() now takes an optional subpage and returns array(<name>,<subpage>). Similarly merge getPage() and getPageByAlias(). There were many examples of (extensions particularly) making dubious assumptions about the presence or absence of subpages or canonical-ness.
I didn't deprecate SpecialPage::getTitleFor() as it's got over six hundred calls. I'm rather undecided on the best position of getPage()/executePath(). Although the latter needs cleanup anyway.
Roan Kattouw [Sun, 17 Apr 2011 10:49:27 +0000 (10:49 +0000)]
Remove debugging code accidentally committed in r86253
Roan Kattouw [Sun, 17 Apr 2011 10:48:17 +0000 (10:48 +0000)]
Fix broken check for bad JSON encoders, had been broken since inception and caused the native JSON encoder to always be bypassed in favor of Services_JSON.
Happy-melon [Sun, 17 Apr 2011 10:44:44 +0000 (10:44 +0000)]
Tidy up some more uses of SpecialPage static methods
Alexandre Emsenhuber [Sun, 17 Apr 2011 07:59:58 +0000 (07:59 +0000)]
* (bug 28511) Use [] syntax instead of {} for string offset access
Max Semenik [Sun, 17 Apr 2011 05:46:41 +0000 (05:46 +0000)]
Back out r86054 and part of r86059 for now, I'd like to evaluate the possibility of integrating NeilK's work into the core now
Happy-melon [Sat, 16 Apr 2011 23:23:28 +0000 (23:23 +0000)]
Some more documentation and replacing static Skin calls
Happy-melon [Sat, 16 Apr 2011 22:05:54 +0000 (22:05 +0000)]
Fix some type hints, documentation and potentially-undefined-variables which PhpStorm was complaining about.
Chad Horohoe [Sat, 16 Apr 2011 21:59:01 +0000 (21:59 +0000)]
method signatures, E_STRICT, blah blah blah
Happy-melon [Sat, 16 Apr 2011 21:43:32 +0000 (21:43 +0000)]
More deprecated calls to Skin static methods, update to use Linker methods instead.
Happy-melon [Sat, 16 Apr 2011 20:22:18 +0000 (20:22 +0000)]
Fix fatal in Standard skin.
Happy-melon [Sat, 16 Apr 2011 20:01:39 +0000 (20:01 +0000)]
Update Skin.php to not call the now-separate Linker methods via $this->foo().
Chad Horohoe [Sat, 16 Apr 2011 19:30:50 +0000 (19:30 +0000)]
Followup r86228 (profiling cleanup):
* Move autoloader up in Maintenance as well
* Add setInstance() method to Profiler, dumpHTML will need it
* Move get/setProfileId() up a level to Profiler. ProfilerSimple subclasses use it, behavior is harmless for Stub.
Chad Horohoe [Sat, 16 Apr 2011 19:23:45 +0000 (19:23 +0000)]
Followup r86228 (profiling cleanup):
* Move autoloader up in Maintenance as well
* Add setInstance() method to Profiler, dumpHTML will need it
Siebrand Mazeland [Sat, 16 Apr 2011 19:11:20 +0000 (19:11 +0000)]
Localisation updates from translatewiki.net. Support for Angika, Brahui, Central Dusin, Jamaican Creole English and Khowar added.
Chad Horohoe [Sat, 16 Apr 2011 19:00:54 +0000 (19:00 +0000)]
More profiler cleanup:
* Move autoloader up a little bit so the profiler classes can use it
* Make Profiler into a singleton so it's lazy-constructed, $wgProfiler is now a configuration array (used 'visible' in ProfilerSimpleText as an example of other globals we can move into this array). If $wgProfiler is set to an object, it'll use that for back-compat
* Maintenance: rather than setting up the profiler and then disabling it, just disable it from the start
* Kill $wgProfiling -> now that ProfilerStub overrides profileIn() and profileOut(), it's not needed
* dumpHTML needs some fixes still
Siebrand Mazeland [Sat, 16 Apr 2011 18:53:10 +0000 (18:53 +0000)]
Localisation updates from translatewiki.net.
Brian Wolff [Sat, 16 Apr 2011 18:34:24 +0000 (18:34 +0000)]
follow-up r86195 (Sort of). Make sure the string there can really be exploded before calling explode on it.
I originally had the two variables that r86195 removed there to catch the case of a malformed
png file that didn't have a null byte where it was supposed to. However, just declaring the default
for those variables wouldn't have been enough to prevent the warning from list( blah, blah) = explode(..
So now explicitly check the null byte is there like it should be.
Brian Wolff [Sat, 16 Apr 2011 17:25:48 +0000 (17:25 +0000)]
(follow-up r86169) per Reedy, the $val = $val thing is weird.
Most of these were actually here going way way back to the dark ages
(although they were hidden as $tags[$tag] = $val; with $val being the same as $tags[$tag])
Siebrand Mazeland [Sat, 16 Apr 2011 17:22:15 +0000 (17:22 +0000)]
Consistent casing for PLURAL.
Brian Wolff [Sat, 16 Apr 2011 16:59:59 +0000 (16:59 +0000)]
(follow-up r86169) I had {{plural}} screwed up in Exif-gpsaltitude-below-sealevel and Exif-gpsaltitude-above-sealevel
Thank you to DCLXVI from translatewiki for pointing this out to me :)
Brian Wolff [Sat, 16 Apr 2011 16:23:08 +0000 (16:23 +0000)]
follow-up r86195 - That $valid really was reachable :P
follow-up r86169 - It appears when merging PNGMetadataExtractor.php, I somehow deleted $duration (whoops!)
Brian Wolff [Sat, 16 Apr 2011 15:53:08 +0000 (15:53 +0000)]
(Follow-up r86169) Needed supress warnings around iconv
Also make it try to detect if a jpeg file comment has textual data, or is random binary stuff.
Brian Wolff [Sat, 16 Apr 2011 15:32:19 +0000 (15:32 +0000)]
(follow-up r86130) the normalizer_normalize function doesn't replace things like U+0001
which causes all sorts of pain and suffering if inserted into a page.
(discovered at translatewiki)
Leo Koppelkamm [Sat, 16 Apr 2011 14:44:18 +0000 (14:44 +0000)]
Give fieldsets in vector preferences the same look in JS and non-JS version. This gets rid of the flash of blue borders before the preference JS ran
Leo Koppelkamm [Sat, 16 Apr 2011 14:03:07 +0000 (14:03 +0000)]
Move timezone preference functions to mediawiki.special.preferences.js & remove their wikibits dependencies
Platonides [Sat, 16 Apr 2011 12:59:08 +0000 (12:59 +0000)]
Revert r85006
Siebrand Mazeland [Sat, 16 Apr 2011 12:02:52 +0000 (12:02 +0000)]
Fix syntax error in r86201
Leo Koppelkamm [Sat, 16 Apr 2011 11:54:43 +0000 (11:54 +0000)]
Free metadata toggle script from wikibits.js dependencies; rename to mediawiki.action.view.metadata.js
Siebrand Mazeland [Sat, 16 Apr 2011 11:36:03 +0000 (11:36 +0000)]
Update $wgEXIFMessages for r86169.
Sam Reed [Sat, 16 Apr 2011 11:28:35 +0000 (11:28 +0000)]
Remove some unused variables/globals
Fix another unreachable statement
Siebrand Mazeland [Sat, 16 Apr 2011 11:27:11 +0000 (11:27 +0000)]
Rebuild all language files.
Removes messages removed from MessagesEn.php in r86146, r86155, r86157, r86169.
Sam Reed [Sat, 16 Apr 2011 11:25:37 +0000 (11:25 +0000)]
Fix missing abstract methods, logging against r86001
Siebrand Mazeland [Sat, 16 Apr 2011 11:22:21 +0000 (11:22 +0000)]
Remove trailing whitespace.
Sam Reed [Sat, 16 Apr 2011 11:22:14 +0000 (11:22 +0000)]
Fix $row = $row = $.... and unused variable from r85885
Sam Reed [Sat, 16 Apr 2011 11:17:14 +0000 (11:17 +0000)]
Remove some unused variables
Fix typo in wfDeprecated usage
Fix some more unreachable code
Sam Reed [Sat, 16 Apr 2011 11:11:49 +0000 (11:11 +0000)]
Followup r86169, move unreachable debug statement
Sam Reed [Sat, 16 Apr 2011 11:09:20 +0000 (11:09 +0000)]
Fix autoloader from r86175
Alexandre Emsenhuber [Sat, 16 Apr 2011 09:03:44 +0000 (09:03 +0000)]
Fix for r86169: added missing items in messages.inc and rebuilt MessagesEn.php
Max Semenik [Sat, 16 Apr 2011 08:47:37 +0000 (08:47 +0000)]
moar syntax errors
Max Semenik [Sat, 16 Apr 2011 08:45:57 +0000 (08:45 +0000)]
Fixed syntax error in message docs
Leo Koppelkamm [Sat, 16 Apr 2011 08:44:33 +0000 (08:44 +0000)]
Followup to r86047: Fix empty button on pages with only one rev
Alexandre Emsenhuber [Sat, 16 Apr 2011 08:37:08 +0000 (08:37 +0000)]
Fix for r86186: correct check
Alexandre Emsenhuber [Sat, 16 Apr 2011 08:34:01 +0000 (08:34 +0000)]
* (bug 25946) The message on the top of Special:RecentChanges is now displayed in user language instead of content language
Moved 'recentchangestext' message to 'recentchanges-summary'; left 'recentchangestext' empty by default for wikis that would like to display things in content language on the top of Special:RecentChanges
Alexandre Emsenhuber [Sat, 16 Apr 2011 07:46:47 +0000 (07:46 +0000)]
* (bug 28568) Entries in the iwlinks table are now removed on page deletion
Max Semenik [Sat, 16 Apr 2011 07:39:41 +0000 (07:39 +0000)]
Prevent bug 17790 from reappearing on Special:Preferences
Chad Horohoe [Sat, 16 Apr 2011 02:19:40 +0000 (02:19 +0000)]
First step of reorganizing profiling files:
* Move them all to includes/profiling/* - If you're using StartProfiler, you'll need to update that
* Make ProfileStub subclass the Profiler rather than duplicating function definitions conditionally
* Removed unused params to wfGetProfilingOutput(), only used in the stub, and they didn't do anything with them
* TODO: Kill $wgProfiling, make $wgProfiler a config array and move the various options to that. Also make into a singleton, rather than global (not much calls it outside of core)
Brian Wolff [Sat, 16 Apr 2011 02:19:05 +0000 (02:19 +0000)]
(Follow-up r86169) Fix three minor issues Reedy found.
* Some strings were using double quotes needed the dollar sign escaped.
(the strings had to do with detecting obscure text encodings for IPTC)
* FormatMetadata::collapseContactInfo should be static (for some reason I never got any E_STRICT on this. I think the api suppresses E_STRICT somehow...)
* Exif::get/makeFormattedMetadata method (which appears to no longer be used, and
never was used, but kept in for compatability just in case) called
another function without required argument. Also got changed from public
to private somehow (which is generally a bad idea, especially when its only
reason for being there is to preserve back-compat). Marked these functions
as deprecated while I'm at it since they really should not be used.
Brian Wolff [Sat, 16 Apr 2011 01:31:37 +0000 (01:31 +0000)]
(Follow-up r86169) Add release notes for img metadata changes.
Sam Reed [Sat, 16 Apr 2011 01:29:39 +0000 (01:29 +0000)]
Fix whitespace issues at top of file
Brian Wolff [Sat, 16 Apr 2011 01:23:15 +0000 (01:23 +0000)]
Merge to trunk everything in img_metadata branch.
Hope I did this in an ok fashion. svn merge --re-integrate was giving me issues
so I just essentially over-wrote my working copy with the version at img_metadata.
Sam Reed [Sat, 16 Apr 2011 00:23:07 +0000 (00:23 +0000)]
Revert r85536 pending a better fix
Chad Horohoe [Sat, 16 Apr 2011 00:16:02 +0000 (00:16 +0000)]
Revert r82922 (adding eml files to mime types). Per CR, these should be accompanied by appropriate sanity checks on upload
Chad Horohoe [Fri, 15 Apr 2011 23:38:34 +0000 (23:38 +0000)]
Merge r81445 from 1.17: revert r70520 (js password complexity checker)
Chad Horohoe [Fri, 15 Apr 2011 23:28:13 +0000 (23:28 +0000)]
Merge r81448 from REL1_17: reverting RevisionMove feature back out until somebody has the time to work on it again. Reverts r67094 and its followups in trunk: r67099, r67111, r67112, r67115, r67398, r81425, r81427
Aaron Schulz [Fri, 15 Apr 2011 22:58:00 +0000 (22:58 +0000)]
* Made __construct() protected
* Minor style and doc cleanups
Chad Horohoe [Fri, 15 Apr 2011 22:49:03 +0000 (22:49 +0000)]
Revert r77555 and followups r77563, r77572, r78116 (merge DisableAccount to core).
Per CR at the time: this creates a nearly irreversable action that is not nearly well documented enough (even if disabled by default).
We already have the $wgBlockDisablesLogin kludge in place for this. If we're going to do more work on this idea, it should be well thought out, not another hack.
Leo Koppelkamm [Fri, 15 Apr 2011 22:36:09 +0000 (22:36 +0000)]
r85922: Fixing another table bordercase
Happy-melon [Fri, 15 Apr 2011 22:11:33 +0000 (22:11 +0000)]
Follow-up r86041: fix redirect in PurgeAction, and pass query parameters through the form so they can be put back on to the redirect at the end.
Brian Wolff [Fri, 15 Apr 2011 21:53:55 +0000 (21:53 +0000)]
(follow-up r86121) Use strict comparision.
Third times the charm...
Brian Wolff [Fri, 15 Apr 2011 20:57:24 +0000 (20:57 +0000)]
(bug 28561 - follow-up r4185) remove rule .small * {font-size: 94%} causes anything nested to be super-small
I'm not sure what the intent was, but this rule will make something like:
<span class="small">fo<b>o</b></span>
have the second o in foo be smaller then the first. Even without this rule, nested instances
of class="small" will still be smaller than a single instance, so it only causes weirdness.
Raimond Spekking [Fri, 15 Apr 2011 20:02:58 +0000 (20:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-04-15 19:40:00 UTC)
Aaron Schulz [Fri, 15 Apr 2011 18:40:25 +0000 (18:40 +0000)]
* Pass around parser options instead of users and made some parser options consistency fixes
* Moved makeParserOptions to Article.php
* Renamed currentIncludeVersions -> getRevIncludes
* Renamed updatePageCache -> setPageCache
* Moved FlaggedRevs::getCacheKey up
Brian Wolff [Fri, 15 Apr 2011 18:39:43 +0000 (18:39 +0000)]
(follow-up r69626) Make it so the intl normalizer_normalize function is not
fed an invalid sequence in UtfNormal::cleanUp
normalizer_normalize seems to return false if fed an invalid unicode sequence (Which is quite different
from what our built in normalization functions do). So use quickIsNFC if it returns false.
(Noticed when investigating bug 28541).
Chad Horohoe [Fri, 15 Apr 2011 18:06:03 +0000 (18:06 +0000)]
Followup r83755: You removed them, you didn't deprecate them (there is a difference). If you're going to remove them, go the whole way rather than having people think they might still work.