Krinkle [Mon, 27 Feb 2012 00:03:14 +0000 (00:03 +0000)]
[mediawik.special.changeslist] Remove ugly arrow swapping hack
* Use CSS and change the background image, instead of displaying 2 <img> tags and hiding one based on the parent element's class
* touches bug 17616 a bit, although it doesn't address the focus issue yet, but does improve the overal structure of this module
* Also speeds up by:
- Outputting less markup
- Having 1 embedded images in the CSS file instead of (N changes)*<img> tags
* jquery.makeCollapsible:
Krinkle [Sun, 26 Feb 2012 23:47:22 +0000 (23:47 +0000)]
Release notes for added feature in r112451 which fixed bug 33952
Tim Starling [Sun, 26 Feb 2012 23:03:45 +0000 (23:03 +0000)]
Re-add the exception log removed in r88392: unlike Chrome, the current Firebug displays exceptions dumped in this way with full details, including a backtrace
Tim Starling [Sun, 26 Feb 2012 22:46:40 +0000 (22:46 +0000)]
* Fix r111983 (bug 34662): make mw.toolbar.addButton() work even after DOM ready
* Don't use an empty array as the default for $toolbar, use false which will throw an exception on a logic error.
* Fix exception handling in mw.loader: have handlePending() rethrow its exception so that the exception handler in execute() can run, so that the exception gets logged. But don't rethrow the exception in execute(), because that may break other modules.
Raimond Spekking [Sun, 26 Feb 2012 19:55:37 +0000 (19:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sun, 26 Feb 2012 17:19:11 +0000 (17:19 +0000)]
Pass __METHOD__ to DatabaseBase::begin(), DatabaseBase::commit() and DatabaseBase::rollback()
Derk-Jan Hartman [Sun, 26 Feb 2012 16:52:37 +0000 (16:52 +0000)]
Add lang and hreflang tags to the variants in the variant menu's. This fixes bug 24742.
I have not added the rel 'alternate' links, because they are also present in the <head>
Krinkle [Sun, 26 Feb 2012 15:57:01 +0000 (15:57 +0000)]
[mediawiki.api.watch] Re-use watch() in unwatch().
- Fix dependency issue. In practice not an issue due to user.tokens being in the HTML output before the first mw.loader.load()
- Follows-up r107969, r107350
Niklas Laxström [Sun, 26 Feb 2012 14:16:53 +0000 (14:16 +0000)]
Added @since annotations
Siebrand Mazeland [Sun, 26 Feb 2012 14:02:54 +0000 (14:02 +0000)]
Use local context ( $this->msg() ) instead of global method wfMessage() per IAlex. Follows-up r112433.
Alexandre Emsenhuber [Sun, 26 Feb 2012 13:34:58 +0000 (13:34 +0000)]
Use local context to get messages
Siebrand Mazeland [Sun, 26 Feb 2012 13:08:41 +0000 (13:08 +0000)]
(bug 34702) Localised parentheses are now used in more special pages.
Amir E. Aharoni [Sun, 26 Feb 2012 12:26:16 +0000 (12:26 +0000)]
Follow up r112423, added release note.
Siebrand Mazeland [Sun, 26 Feb 2012 12:11:35 +0000 (12:11 +0000)]
Wow. Messy. Follow-up r112426, r112424: Fix incorrect calls. Should have been escaped() instead of escape().
Siebrand Mazeland [Sun, 26 Feb 2012 12:07:21 +0000 (12:07 +0000)]
Follow-up r112424: Per IAlex on IRC: Use escape() instead of plain() for improved security.
Siebrand Mazeland [Sun, 26 Feb 2012 11:49:01 +0000 (11:49 +0000)]
Follow-up r112410, r112412: Cheaper processing using plain().
Amir E. Aharoni [Sun, 26 Feb 2012 11:39:49 +0000 (11:39 +0000)]
Fixes bug 34723: applies the English language to CSS/JS both as a user subpage and a MediaWiki space page, and consequently applies LTR to JS and CSS in the textarea.
Antoine Musso [Sat, 25 Feb 2012 21:39:54 +0000 (21:39 +0000)]
rename test file to end with Test.php :D
Antoine Musso [Sat, 25 Feb 2012 21:22:49 +0000 (21:22 +0000)]
basic tests for bug 34508
Siebrand Mazeland [Sat, 25 Feb 2012 20:53:54 +0000 (20:53 +0000)]
Follow-up r112410: (bug 34702) Use localised parentheses for comment, too.
Siebrand Mazeland [Sat, 25 Feb 2012 20:42:08 +0000 (20:42 +0000)]
(bug 34702) Use localised parentheses in Special:Contributions.
Raimond Spekking [Sat, 25 Feb 2012 20:36:21 +0000 (20:36 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Derk-Jan Hartman [Sat, 25 Feb 2012 20:30:38 +0000 (20:30 +0000)]
Fixes bug 34715 Image redirects show the "redirected from" subtitle twice.
ImagePage no longer needs to set the "redirectedfrom" header by itself. Seems Article.php is taking care of it now. I suspect this was caused by the refactoring of WikiPage, Article, etc.
Krinkle [Sat, 25 Feb 2012 16:36:43 +0000 (16:36 +0000)]
release-notes 1.19: Mark .wikitable change as BREAKING-CHANGES
Alexandre Emsenhuber [Sat, 25 Feb 2012 16:00:26 +0000 (16:00 +0000)]
Forgot to commit this file in r112396
Alexandre Emsenhuber [Sat, 25 Feb 2012 15:59:12 +0000 (15:59 +0000)]
* (bug 34246) Display MediaWiki:Whatlinkshere-summary again in Special:Whatlinkshere
Alexandre Emsenhuber [Sat, 25 Feb 2012 15:23:45 +0000 (15:23 +0000)]
* (bug 34528) Don't parse section name in edit section tooltips
Alexandre Emsenhuber [Sat, 25 Feb 2012 13:23:43 +0000 (13:23 +0000)]
Pass __METHOD__ to DatabaseBase::begin(), DatabaseBase::commit() and DatabaseBase::rollback()
Alexandre Emsenhuber [Sat, 25 Feb 2012 13:21:26 +0000 (13:21 +0000)]
Use local context to get messages
Ryan Kaldari [Sat, 25 Feb 2012 03:02:23 +0000 (03:02 +0000)]
fixing bug 34609 - datepicker should always be set to display:none by default
Aaron Schulz [Sat, 25 Feb 2012 02:01:35 +0000 (02:01 +0000)]
Fixed $headers check in streamFile() to use isset()
Aaron Schulz [Sat, 25 Feb 2012 01:43:20 +0000 (01:43 +0000)]
More file streaming related profiling
Aaron Schulz [Sat, 25 Feb 2012 00:53:56 +0000 (00:53 +0000)]
Added some StreamFile profiling
Arthur Richards [Fri, 24 Feb 2012 23:39:42 +0000 (23:39 +0000)]
Attempting to address bug 34653; It seems ApiQueryLogEvents has not kept up with changes to the Logging classes. I've changed some aspects of the ApiQueryLogEvents to use a DatabaseLogEntry object when extracting log row information and updated addLogParams to use this new scheme for handling parameters. I have not been able to sufficiently test this and I am still concerned about backwards compatibility with old parameter formats for older log records as well as parameter handling for the 'rights' and 'block' log types.
Krinkle [Fri, 24 Feb 2012 23:32:36 +0000 (23:32 +0000)]
[mw.loader] Remove 'media' type support in addInlineCSS
* This was never used in practice because the server only gives css text strings for media type "" or "all". Because server side concatenates everything together during pre-processing and e.g. print-stylesheet parts of it are wrapped in @media print {}
* Follows-up r110988
Krinkle [Fri, 24 Feb 2012 23:22:30 +0000 (23:22 +0000)]
[mw.loader] Refactor addInlineCSS's logic, fixing various bugs
* Using mw.util.addCSS as base to instance of bug 33305 automatically
* Expose as mw.loader.addStyleTag
* Re-use the code in mw.util.addCSS
* Drop the "text > Cdata > element > jQuery object > innerHTML", in favor of setting cssText or appending a text node (html escapement isn't a problem when working with text nodes directly).
* Appending this way also works in IE, no need for the dispose/re-create style-tag logic in the try-catch().
* Follows-up r110988 (fixme)
Krinkle [Fri, 24 Feb 2012 23:14:02 +0000 (23:14 +0000)]
[JSTesting] actually commit the file (follows-up r112368)
Krinkle [Fri, 24 Feb 2012 23:13:24 +0000 (23:13 +0000)]
[JSTesting] Add more mw.loader tests
* Follows-up r12279, r112281
* Follows-up r110988: Adds test for @import (currently failing: bug 34669)
* Adding StyleTest.css.php for making this easier and re-usable
Raimond Spekking [Fri, 24 Feb 2012 21:11:11 +0000 (21:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Raimond Spekking [Fri, 24 Feb 2012 20:31:11 +0000 (20:31 +0000)]
r112128: Comment out dupe message keys
Antoine Musso [Fri, 24 Feb 2012 20:30:55 +0000 (20:30 +0000)]
avoid test suite file leaks
Aaron Schulz [Fri, 24 Feb 2012 20:22:16 +0000 (20:22 +0000)]
r100315: removed now redundant code
Ryan Kaldari [Fri, 24 Feb 2012 20:13:30 +0000 (20:13 +0000)]
wikistandard.css is not a common skin file, it is only used by the classic/standard skin. moving from skins/common/ to skins/standard
Aaron Schulz [Fri, 24 Feb 2012 20:10:36 +0000 (20:10 +0000)]
In FSFileBackend:
* Removed some error suppression as display_errors should never be enabled for production sites and the suppression hid useful log information.
Ryan Kaldari [Fri, 24 Feb 2012 20:03:40 +0000 (20:03 +0000)]
follow-up to r111861, fixing classic skin
Max Semenik [Fri, 24 Feb 2012 18:49:48 +0000 (18:49 +0000)]
Test that verifies uniqueness of query module prefixes
Sam Reed [Fri, 24 Feb 2012 18:45:24 +0000 (18:45 +0000)]
More __METHOD__ in our madness
Sam Reed [Fri, 24 Feb 2012 18:38:04 +0000 (18:38 +0000)]
Improve documentation
Sam Reed [Fri, 24 Feb 2012 17:00:52 +0000 (17:00 +0000)]
More __METHOD__ into db related methods
Antoine Musso [Fri, 24 Feb 2012 16:54:48 +0000 (16:54 +0000)]
better structure filename error output
When dumping an array, PHPUnit limit the number of characters shown. That would
just hide the relevant part of the path:
1) StructureTest::testUnitTestFileNamesEndWithTest
[...]
Array (
+ 0 => '/some/path/tests/phpunit/incl...ge.php'
+ 1 => '/some/path/tests/phpunit/incl...ki.php'
)
By stripping the common path ( /some/path/tests/phpunit ), we end up with a
more useful output:
Array (
+ 0 => 'includes/RecentChange.php'
+ 1 => 'includes/Wiki.php'
)
Antoine Musso [Fri, 24 Feb 2012 15:43:11 +0000 (15:43 +0000)]
avoid exif tests file leakage
Exif test are leaking files heavily on our test server. This quick patch make
it sure we delete temporary files.
Ideally, we should have something like a temporary filesystem backend that
would self destruct :-D
requires r112326: wfRecursiveRemoveDir()
Antoine Musso [Fri, 24 Feb 2012 15:41:06 +0000 (15:41 +0000)]
move wfRecursiveRemoveDir to global functions
That useful method was hidden in SeleniumWebSettings. I need it to clean
up test files leakages.
Alexandre Emsenhuber [Fri, 24 Feb 2012 14:47:49 +0000 (14:47 +0000)]
Pass __METHOD__ to DatabaseBase::begin(), DatabaseBase::commit() and DatabaseBase::rollback()
Alexandre Emsenhuber [Fri, 24 Feb 2012 12:52:42 +0000 (12:52 +0000)]
Use local context to get message
Daniel Friesen [Fri, 24 Feb 2012 11:31:36 +0000 (11:31 +0000)]
Fix bug 34684 in my PathRouter code:
- Update the tests to test extra characters and patterns like like \\ and $1
- Also update the tests to make sure that matches that don't have enough data to work fail
- Replace the str_replace and preg_match based code with code based on preg_replace_callback.
Tim Starling [Fri, 24 Feb 2012 04:29:50 +0000 (04:29 +0000)]
ContribsPager can't accept multiple namespaces, passing an array causes a warning in DatabaseMysql::strencode(). Not sure if/how this worked in 1.18 but it's broken in 1.19wmf1. Tested.
Sam Reed [Fri, 24 Feb 2012 02:06:39 +0000 (02:06 +0000)]
Examples can just be a string
So if it's not false, it can be string|array, if it's a string, just put it in an array
Krinkle [Fri, 24 Feb 2012 01:00:54 +0000 (01:00 +0000)]
[JSTesting] mock/restore mw.messages as well, like mw.config
Krinkle [Fri, 24 Feb 2012 00:44:33 +0000 (00:44 +0000)]
[JSTesting] Refactor mw.loader test to be more extendable
Aaron Schulz [Thu, 23 Feb 2012 23:00:38 +0000 (23:00 +0000)]
Improved profiling of a few functions a bit
Jeroen De Dauw [Thu, 23 Feb 2012 22:58:11 +0000 (22:58 +0000)]
fix doc, this is not an array
Jeroen De Dauw [Thu, 23 Feb 2012 22:26:38 +0000 (22:26 +0000)]
docs++
Alexandre Emsenhuber [Thu, 23 Feb 2012 20:01:17 +0000 (20:01 +0000)]
Pass __METHOD__ to DatabaseBase::begin(), DatabaseBase::commit() and DatabaseBase::rollback()
Alexandre Emsenhuber [Thu, 23 Feb 2012 19:57:42 +0000 (19:57 +0000)]
Use local context to get messages
Krinkle [Thu, 23 Feb 2012 02:45:45 +0000 (02:45 +0000)]
Bug 34604 - [mw.config] wgActionPaths should be an object instead of a numeral array JavaScript
Krinkle [Thu, 23 Feb 2012 02:43:57 +0000 (02:43 +0000)]
release-notes-1.19
* Update some bug summaries to clearer versions (to lessen ambiguity as to whether it describes the removed behavior or the added one).
* Removed "Some deprecated presentational html attributes will now be automatically
converted to css." duplicate entry of "Most presentational html attributes like valign are now converted to inline css style rules."
* Removed bug 24037, which was reverted.
Krinkle [Thu, 23 Feb 2012 01:25:14 +0000 (01:25 +0000)]
Follow-up r112172: fix inline-block support for IE6/IE7
Sam Reed [Thu, 23 Feb 2012 01:23:53 +0000 (01:23 +0000)]
Swap Fran Rogers to Fran McCrory per request
Krinkle [Thu, 23 Feb 2012 01:00:06 +0000 (01:00 +0000)]
Follow-up r112172: embed
Brion Vibber [Thu, 23 Feb 2012 00:53:29 +0000 (00:53 +0000)]
* (bug 33045) Use locally-sourced spinner image for mediawiki.feedback module instead of Commons image
Switched from an <img> with a hardcoded Commons link to a <span>, a stylesheet, and a locally-hosted copy of the image.
Krinkle [Thu, 23 Feb 2012 00:39:15 +0000 (00:39 +0000)]
[mw.util] bug fix and minor clean up
* Fixes bug 34603 (Patch by Rainer <Rainer@Rillke.eu>) and other instances of the same bug
-- Use 'util' instead of 'this' to allow re-usage of the method in a different context
* Use ternary operator instead of the default operator in mw.util.wikiGetlink to check it for type instead of thruthy-ness (so that falsy-values such as '' work, and thruthy non-string values such as objects fail).
Brion Vibber [Thu, 23 Feb 2012 00:37:21 +0000 (00:37 +0000)]
bug 34599: special:uploadwizard loading insecure content from commons
This is in mediawiki.feedback module which is hosted in core.
A quick fix to load this spinner image protocol-relative. Should be replaced with CSS and a locally-hosted image.
Roan Kattouw [Wed, 22 Feb 2012 23:34:08 +0000 (23:34 +0000)]
Fix spacing in r111809
Roan Kattouw [Wed, 22 Feb 2012 21:43:59 +0000 (21:43 +0000)]
(bug 34600) Older skins using useHeadElement=false were broken in 1.18 . Modified patch by Vitaliy Flippov
Raimond Spekking [Wed, 22 Feb 2012 20:00:19 +0000 (20:00 +0000)]
r112128: Add new message keys to maintenance files otherwise the next run of the translatewiki.net export script would kick them.
But ignore them for translation per Nikerabbit: "I don't want these messages to be translated." https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112061#c31329
Niklas Laxström [Wed, 22 Feb 2012 19:01:02 +0000 (19:01 +0000)]
Followup, restore the irctext variable just in vase, ping r112132
Niklas Laxström [Wed, 22 Feb 2012 18:56:14 +0000 (18:56 +0000)]
Uglier than ugly hack to fix block log any many others by not having the username prepended on the messages
Rob Lanphier [Wed, 22 Feb 2012 18:29:18 +0000 (18:29 +0000)]
r112045/bug 34508: Make upload/upload and overwrite match old IRC format
Alexandre Emsenhuber [Wed, 22 Feb 2012 15:53:21 +0000 (15:53 +0000)]
Use local context to get messages
Raimond Spekking [Wed, 22 Feb 2012 11:33:56 +0000 (11:33 +0000)]
r112061: Add new message keys to maintenance files otherwise the next run of the translatewiki.net export script would kick them.
But ignore them for translation per Nikerabbit: "I don't want these messages to be translated." https://www.mediawiki.org/wiki/Special:Code/MediaWiki/112061#c31329
Tim Starling [Wed, 22 Feb 2012 06:14:57 +0000 (06:14 +0000)]
This script uses about 550MB of RAM on 1.19wmf1. Increase memory limit appropriately.
Aaron Schulz [Wed, 22 Feb 2012 02:28:17 +0000 (02:28 +0000)]
* General log formatting fixes, like using the content language, for IRC feeds (works similar to LogPage::actionText). Use getPrefixedText() for the log title, not just the non-namespace part.
* Made patrol log IRC code behave as it did pre-r97495.
Tim Starling [Wed, 22 Feb 2012 02:09:05 +0000 (02:09 +0000)]
Output directory option, to allow messages to be put directly into /h/w/c
Aaron Schulz [Wed, 22 Feb 2012 00:36:31 +0000 (00:36 +0000)]
Made getIRCActionText() public again...since the old LogPage still uses it, ugh
Aaron Schulz [Wed, 22 Feb 2012 00:26:29 +0000 (00:26 +0000)]
Made use of new getIRCActionComment() function so that comments are back in IRC lines.
Sam Reed [Wed, 22 Feb 2012 00:00:44 +0000 (00:00 +0000)]
Move parameters were backwards
Ping r112061
Aaron Schulz [Tue, 21 Feb 2012 23:51:18 +0000 (23:51 +0000)]
r112062: updated LogEntry publish() function too
Aaron Schulz [Tue, 21 Feb 2012 23:42:10 +0000 (23:42 +0000)]
r112062: swap the getPlainActionText() for IRC with new getIRCActionText() function
Aaron Schulz [Tue, 21 Feb 2012 23:39:14 +0000 (23:39 +0000)]
Separate out an IRC actionText field for RecentChange. The two are currently the same but that will change soon.
Sam Reed [Tue, 21 Feb 2012 23:38:08 +0000 (23:38 +0000)]
Bug 34508 - [Regression] IRC string output for log messages no longer compatible
Update messages/MessagesEn.php
Add large backcompat switch conditional thing
Alexandre Emsenhuber [Tue, 21 Feb 2012 22:27:33 +0000 (22:27 +0000)]
Added $performer parameter to PatrolLog::record() and pass it from WikiPage::doEdit() and RecentChange::doMarkPatrolled() since the performer is not necessarily $wgUser
Trevor Parscal [Tue, 21 Feb 2012 22:08:23 +0000 (22:08 +0000)]
Adds a supportsURLLoading method which returns false to user tokens and user options modules. This prevents them from being linked to direction which fixes an issue where in debug mode logged in users were being served anon tokens and options. This should resolve bug #34469.
Alexandre Emsenhuber [Tue, 21 Feb 2012 22:04:43 +0000 (22:04 +0000)]
Per Aaron, follow-up r112036: add __METHOD__ to DatabaseBase::rollback() too
Arthur Richards [Tue, 21 Feb 2012 22:00:58 +0000 (22:00 +0000)]
Refactors the check if a particular IP is in the list of configured squid servers into its own function.
Sam Reed [Tue, 21 Feb 2012 21:54:27 +0000 (21:54 +0000)]
Effectively revert r112042
Followup r112045, remove the irc key name changes
Sam Reed [Tue, 21 Feb 2012 21:27:39 +0000 (21:27 +0000)]
consistently use $entry
Sam Reed [Tue, 21 Feb 2012 21:26:15 +0000 (21:26 +0000)]
First merge of the rest of the code from bug 34508 patch 1 and patch 3
Raimond Spekking [Tue, 21 Feb 2012 21:17:58 +0000 (21:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Tue, 21 Feb 2012 21:15:05 +0000 (21:15 +0000)]
Improve documentation
Fix whitespace
Fix weird conditional loading of DB_MASTER from specials/SpecialEditWatchlist.php
Sam Reed [Tue, 21 Feb 2012 21:12:24 +0000 (21:12 +0000)]
Part 1 for bug 34508, commit all the messages added in patch 3